ERM Sprint 148

ERM Sprint 148

Sprint Goal / Focus

  • 16 Sep: Orchid Release Plans

Sprint Schedule

  • Sprint: 147

  • Release: 2022.3 Nolana  

    • Sprint 8 of 9 since Release Development Cycle Starts (Sprint 142) to Feature Freeze (Sprint 150)

    • Sprint 151: Module Release Deadline [FOLREL-549]

      • Backend 26 Oct 2022

      • Frontend 28 Oct2022

    • Sprint: Bugfix Release Deadline (2 Dec 2022) [FOLREL-550]

Development Meetings

Sprint Capacity

Team AvailabilitySchedule | Calendar

Notes / Exceptions:

  • Monireh: A/L Sprint Week 1 (5-9 Sep)

  • Peter: A/L Sprint Week 2 (12-16 Sep)

Lead Roles:

  • Code Review: @Ethan Freestone

  • QA:  @Owen Stephens 

QA Environment: folio-snapshot

Present

  • @Jag Goraya 

  • @Ethan Freestone 

  • @Peter Böhm 

  • @Owen Stephens 

  • @Claudia Malzer 

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?

  • What front and back end components are affected?

  • What changes need to be made? (additions, removals or modifications)

  • What development tests need to be written?  

  • What data does the developer need to verify their work?

  • What are the known unknowns? 

  • What is needed to QA? (environment, data, scripts)

Navigation

  1. Sprint Goal / Focus

  2. Sprint Capacity

  3. Review sprint candidates 

  4. Agree technical approach / define key implementation tasks

  5. Finalise estimates / costings

  6. Confirm sprint scope

  7. Confirm first actions

 

 

 


Sprint Planning  

 - not in sprint

 or @ - in sprint 

 

Planning Notes Template

  • Approach

  • Components and Changes

    • Frontend

    • Backend

  • Tests / Data

  • Dependencies

  • Known Unknowns

  • QA: snapshot | local | testing | other

  • Development Estimate

Sprint Focus

https://folio-org.atlassian.net/browse/UXPROD-3754

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/ERM-2332

@Owen Stephens 

No dev action for now. Potentially can drop secondary lookup for Gokb and speed up job performance.

https://folio-org.atlassian.net/browse/UXPROD-3776

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/ERM-2333

@Owen Stephens 

No dev action for now. May result in UI changes. 

https://folio-org.atlassian.net/browse/UXPROD-3116

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/ERM-2334

@Owen Stephens 

Fallout from ERM-2314

Currently :

  • Every single user has a default dashboard on first Dashboard access

Issue;

  • Cannot rely on existing mydashboard  default

  • Not all users will have a mydashboard 

TBD:

  • Prompt to create a dashboard or assign an existing dashboard as default when accessing Dashboard app

  • Owen to review desired behaviour

https://folio-org.atlassian.net/browse/UXPROD-3756

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/ERM-2330

  • Approach

    • keep flat route to support easy migration in future: no change except to where (not what) stuff is displayed

    • read header url

      • if in Agreements or Agreements Line > Agreement Search

      • if in eResources or LocalKB Search > eResource Search (defaulting as normal)

    • this also determines what the primary is

  • Components and Changes

    • Frontend: ui-agreements

    • Backend

  • Tests / Data / Dependencies / Known Unknowns: NA

  • QA: snapshot

  • Development Estimate: <1d

No Feature

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

Release Tasks (Nolana)

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

Maintenance

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

Brought In

Issue ID

Sprint Backlog?

Notes / Estimates / Action

Issue ID

Sprint Backlog?

Notes / Estimates / Action

https://folio-org.atlassian.net/browse/ERM-2337

@Claudia Malzer 

  • Approach

    • normally happens when a field is missing the  name

    • possibly a KiwtFieldArray / finalForm issue

    • reproduce locally for better stacktrace

    • if not, check snapshot is up to date

  • Components and Changes

    • Frontend: ui-erm-comparison, comparison.fieldArray

    • Backend: none

  • Tests / Data: NA

  • Dependencies: NA

  • Known Unknowns

  • QA: snapshot | local 

  • Development Estimate: ??

https://folio-org.atlassian.net/browse/ERM-2338

@Monireh Rasouli 

  • Approach

    • AL type options are not from the same field, but constructed, in a way that it could 

  • Components and Changes

    • Frontend: ui-agreements, AgreementLineFilters (or one step above)

    • Backend: none

  • Tests / Data

  • Dependencies

  • Known Unknowns

  • QA: snapshot 

  • Development Estimate: ??

https://folio-org.atlassian.net/browse/ERM-2340

  • Approach

    • Filter is gone, but option is not cleared from display and not removable

    • Logic to display is separate to lookup logic

    • Throws up an issue with the 

    • Preferably clear if not set (ie if URL is clear).  If not, intercept Reset All and clear all. 

    • Need to check for looping behaviour

  • Components and Changes

    • Frontend: 

    • Backend: none

  • Tests / Data

  • Dependencies

  • Known Unknowns

  • QA: snapshot | local | testing | other

  • Development Estimate: ??

https://folio-org.atlassian.net/browse/ERM-2341

Owen to re-check and confirm to close as Won't Do, as behaviour is currently to show a single confirmation modal after all deletion choices are mode. 

https://folio-org.atlassian.net/browse/ERM-2345

 

https://folio-org.atlassian.net/browse/ERM-2335

@Claudia Malzer 

  • Approach

  • Components and Changes

    • Frontend: ui-agreements

    • Backend: none

  • Tests / Data / Dependencies

  • Known Unknowns

  • QA: snapshot 

  • Development Estimate

https://folio-org.atlassian.net/browse/ERM-2339

@Ethan Freestone 

  • Approach

    • query parameters will include sort

    • inspect query object handed by sasquery (or, preferably kiwt

    • if it includes filter/terms, enable initial query - add enabled prop to the useInfiniteFetch (or useBatchedFetch or useQuery) options parameter (in ALroute - see line 53-54) 

    • if not, do not enable infiniteFetch (enabled = filter settings; line 77)

    • when isIdle is returned from query, show the prompt to select a filter

  • Components and Changes

    • Frontend: ui-agreements (agreementLineRoute)

    • Backend: none

  • Tests / Data /

  • Dependencies

  • Known Unknowns

  • QA: snapshot | local | testing | other

  • Development Estimate

https://folio-org.atlassian.net/browse/ERM-2336

@Claudia Malzer 

  • Approach

    • Expected

      • if no other filters, should set to default filters

      • if default, clear filters

    • may be state-driven, in which case it needs to be url-driven

      • ie, remove custom logic

      • (search and sort query will handle defaults as expected)

    • Check impacts on other filters

  • Components and Changes

    • Frontend: ui-agreements

    • Backend

  • Tests / Data

  • Dependencies

  • Known Unknowns

  • QA: snapshot | local | testing | other

  • Development Estimate

Removed

Sprint Backlog

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/UXPROD-3754

https://folio-org.atlassian.net/browse/ERM-2307

  • Approach

    • explicitly comment the behaviour /  business rule in the code

    • Add logic (if / elseif) inside adaptor

  • Components and Changes

    • Frontend: none

    • Backend: mod-agreements (adaptor)

  • Tests / Data: none

  • Dependencies:

    • requires ERM-2306

    • enables ERM-2308

  • Known Unknowns: none

  • QA: snapshot

  • Development Estimate: == ERM-2311

https://folio-org.atlassian.net/browse/UXPROD-3754

https://folio-org.atlassian.net/browse/ERM-2310

  • Approach

    • add new logic to packageIngestService lines 212-218

    • ensure save after block

    • use existing patterns for updating PTI

  • Components and Changes

    • Frontend: none

    • Backend: mod-agreements packageIngestService 

  • Tests / Data: package test data

  • Dependencies: no

  • Known Unknowns: none

  • QA: snapshot 

  • Development Estimate: small

 

 

 

 

Issue ID

Deferred to

Notes / Estimates / Actions

Issue ID

Deferred to

Notes / Estimates / Actions

 

 

 

 

 

 

Planning Notes Template

  • Current State

  • TODO

  • Development Estimate

Rolled Over From Previous Sprint

In Development

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/UXPROD-3754

https://folio-org.atlassian.net/browse/ERM-2288

@Peter Böhm 

  • Current State: 

  • TODO

    • fix removeFrom error