/
ERM Sprint 129

ERM Sprint 129

Sprint Goal / Focus

  • Remote KB Harvest Sync (Settings)

Sprint Schedule

  • Sprint: 129
    • Start Mon 6 Dec
    • Finish Fri 17 Dec
    • Sprint Board
    • Jira Sprint: 1114
  • Release: 2022.1 Lotus  
    • Sprint 133: Module Release Deadline
      • Backend 16 Feb 2022
      • Frontend 18 Feb 2022
    • Sprint 136: Bugfix Deadline (25 March 2022)

Sprint Capacity

Team AvailabilitySchedule | Calendar

Notes / Exceptions:

  • None

Lead Roles:

QA Environment: folio-snapshot

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?
  • What front and back end components are affected?
  • What changes need to be made? (additions, removals or modifications)
  • What development tests need to be written?  
  • What data does the developer need to verify their work?
  • What are the known unknowns? 
  • What is needed to QA? (environment, data, scripts)

Navigation

 Sprint Planning Agenda
  1. Sprint Goal / Focus
  2. Sprint Capacity
  3. Review sprint candidates 
  4. Agree technical approach / define key implementation tasks
  5. Finalise estimates / costings
  6. Confirm sprint scope
  7. Confirm first actions





Sprint Planning  

(error) - not in sprint

(tick) or @ - in sprint 


Planning Notes Template

  • Approach
  • Components and Changes
    • Frontend
    • Backend
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA: local | testing | snapshot | other
  • Development Estimate

Sprint Focus

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

UXPROD-3337 - UX improvements for Licenses R1 2022 Closed

UXPROD-3338 - UX improvements for Agreements R1 2022 Closed

ERM-1906 - Re-work Supplementary Properties settings screen to use list that can be filtered and fourth pane display Closed

ERM-1907 - On License Terms settings screen ensure "New" button is always visible to user Closed

ERM-1908 - Swap Agreements Pick lists settings screen to single 4 pane based layout Closed

ERM-1909 - On Local KB Admin External Data sources settings screen ensure "New" button is always visible to user Closed

ERM-1910 - Swap Licenses Pick lists settings screen to single 4 pane based layout Closed

ERM-1911 - On Local KB Admin Proxy server settings screen ensure "New" button is always visible to user Closed

(error)

Needs conversation between Owen and Gill. 

Will push back to new year, which may force a quick fix. 

UXPROD-3339 - Experiment with different title match process for Agreements KB Closed

ERM-1799 - Store "match key" information on PTI and PCI Closed

  • Approach
    • most identifiers are stored on TI, not PCI or PTI
      • this change duplicates it in multiple places
    • add new class (collection of matchkey information) to ermResource abstract class
    • tweak ingest to assign class to PCI and PTI
    • enact this where the entry points converge
      • creation of TIs happens in TitleInstanceResolver -
      • PCI and PTIs are created in a shared process during the ingest
    • store as domain class (matchkey/value string pair) rather than json
  • Components and Changes
    • Frontend: none
    • Backend: mod-agreements
  • Tests / Data
    • won't need to expose through api
    • locally verify with SQL queries to ensure appear in 
  • Dependencies: none
  • Known Unknowns: not yet
  • QA: local vagrant
  • Development Estimate: 

ERM-1923 - Invalid json for /erm/entitlements owner.id filter Closed

ERM-1920 - Call /erm/entitlements?filters=owner%3D{id} results in 500 Closed
(question)
  • Ethan to refer to Steve

ERM-1948 - Error on accessing /erm/eresources Closed

Owen Stephens In QA

UXPROD-3338 - UX improvements for Agreements R1 2022 Closed

ERM-1949 - Reset cursor for remote KB Closed  

ERM-1950 - Reset syncStatus for remote KB Closed
Claudia Malzer 
  • 1949: cursor
    • cursor is the change point for differential updates
    • collapse existing buttons to incorporate 
    • reset to null (rather than with value)
  • 1950: syncStatus
    • issue
      • syncStatus has two states (idle or in-process)
      • can sometimes stick at in-process
    • add option to conditionally confirm sync reset for jobs updated over 24 hours earlier
      • date checking within 24 hours: convert difference from milliseconds
    • user needs Settings privileges
  • Components and Changes
    • Frontend:
      • ui-local-kb-admin
    • Backend: none
  • Tests / Data
    • no RTL/JEST or integration tests to be added
    • test locally with, eg, 5 minutes rather than 24 hours
    • use postman to update time via API
  • Dependencies / Known Unknowns : none
  • QA: snapshot 
  • Development Estimate: code review for Wed
FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1484 - Add test coverage for ui-agreements <UrlCustomizerCreateRoute> Closed

ERM-1485 - Add test coverage for ui-agreements <UrlCustomizerEditRoute> Closed

ERM-1486 - Add test coverage for ui-agreements <UrlCustomizerViewRoute> Closed


UXPROD-3338 - UX improvements for Agreements R1 2022 Closed


ERM-1922 - Display "-" in Count column for Agreement lines that do not link to a resource Closed

Pending UX input








Rolled Over From Previous Sprint

For Development


Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1483 - Add test coverage for ui-agreements <PlatformsRoute> Closed

In Progress

TODO: not seeing the data

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1480 - Add test coverage for ui-agreements <NoteViewRoute> Closed

For Code Review

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1482 - Add test coverage for ui-agreements <PlatformViewRoute> Closed

For Code Review

ERM-1937 - Support order-lines 3.0 interface Closed

Changed are as expected.

Transferred to QA


ERM-1938 - Abstract and subclass existing toolkit FileObject (for Agreements) Closed

ERM-1939 - S3 File Storage Regression Testing Closed

  • Owen to review

ERM-1940 - Add AppSettings panel to Agreements Closed

  • Ethan to progress
  • Approach
    • add controller
    • check regression / translations
  • Components and Changes
    • Frontend: ui-agreements
      • settings index
      • translations
    • Backend: mod-agreements
      • expose Controller 
  • Tests / Data
    • stripes-kint-component
  • Dependencies: none
  • Known Unknowns: 
    • not been unit/integration tested before, so current is unknown
  • QA: snapshot 
  • Development Estimate: Thu or Mon 

ERM-1850 - In e-resources search and sort results only include results that have entitlementOptions Closed

Reviewed example with Ethan

Vagrant issues

Making progress on subquery

Expected for code review end of Wednesday

No dependencies




ERM-1912 - In the case of a package harvested from GOKb/external source lacking key information about the package, log the issue and fail gracefully Closed

Test Approach: 

  • Source data has been fixed, so testing without faking the data is going to be problematic (faking or proxying)
  • Set internal value to empty
  • TODO: run integration tests
  • QA: regression test 

ERM-1921 - Display selected status of single title resources from eHoldings in Agreement Line Closed

Complete, but not raised as done as part of 1922

Will separate into new branch for code review today.


ERM-1904 - Resource appears twice in "Dropped" list for agreement Closed

(error)Pending input from Ian

ERM-1922 - Display "-" in Count column for Agreement lines that do not link to a resource Closed

(error)Pending input from Gill

ERM-1929 - Support configuration of document storage in agreement settings Closed

(error)Pending input from Gill

For QA

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions


ERM-1927 - Cannot select options in option switcher in widget config Closed

Seems unreliable on radio button selection. This is a stripes level issue. 1927 to return to QA. 

TODO: Owen to raise a stripes issue. 


ERM-1926 - Error in entitlementLog on deleting agreement line Closed



ERM-1931 - Sort agreement lines by name then reference then UUID in the UI Closed



ERM-1932 - Remove coverage statement errors from KB Sync Error logs Closed



ERM-1900 - Change to suppressFromDiscovery should lead to updated entry in EntitlementLog Closed



ERM-1882 - Use Custom Coverage (if exists) in EntitlementLog Closed



ERM-1883 - Change to coverage should lead to updated entry in EntitlementLog Closed



ERM-1884 - Populate "suppress" field in EntitlementLog Closed



ERM-1912 - In the case of a package harvested from GOKb/external source lacking key information about the package, log the issue and fail gracefully Closed


For Release Prep

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions






Bugfix Cycle

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions





Brought In

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions


ERM-1953 - Re-implement display of acquistionsMethods following order-lines 3.0 interface Closed

Remedial work for ERM-1937 - Support order-lines 3.0 interface Closed

  • Approach
    • add new fetch 
    • filter new fetch based on id
    • provision fallback (show UUID) in case of fetch fail
  • Components and Changes
    • Frontend: ui-agreements
    • Backend
  • Tests / Data
    • tweak test for filters
    • test for fallback
  • Dependencies / Known Unknowns: none
  • QA: snapshot 
  • Development Estimate: code review by Friday

UXPROD-3140 - Dashboard: Enhance simple search widgets with Organisation filters Closed

ERM-1744 - Add Organisations to Agreements simple search widget definition Closed

ERM-1745 - Add Organisations to Licenses simple search widget definition Closed

  • Approach
    • Add json files
    • Trigger type ingest via endpoint / postman
    • Update definition version to 1.1.0
    • Not a breaking change, should just appear in widget config
  • Components and Changes
    • Frontend: none
    • Backend: none
  • Tests / Data: none (would be on ingest process)
  • Dependencies
    • add registry
  • Known Unknowns
  • QA: local + snapshot
    • local: test upgrading
  • Development Estimate: 0.5d

UXPROD-3338 - UX improvements for Agreements R1 2022 Closed

ERM-1762 - Create/Edit Agreement: Add a setting that hides Usage data accordion Closed

  • Approach
    • Check if eUsage plugin is present
      • pluggable component returns a data key, rather than module-name
      • so, if pluggable render returns null ... 
    • If not, do not show Usage data accordian
    • Add new Agreement Display setting using mod-config
    • Set default as false (no change to existing behaviour)
    • Applies to Edit screen only
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: none
  • Tests / Data
    • extend settings page tests
    • extend agreement edit page tests
  • Dependencies: none
  • Known Unknowns
    • eusage not working for dev 
  • QA: snapshot 
  • Development Estimate: Wed for code review

Removed

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3339 - Experiment with different title match process for Agreements KB Closed

ERM-1799 - Store "match key" information on PTI and PCI Closed



UXPROD-3172 - Migrate file storage for Agreements and Licenses from database to file store Closed

ERM-1929 - Support configuration of document storage in agreement settings Closed


Pending UX input




Sprint Summary

ERM


Key Summary T Assignee Status Components


Dashboard

Key Summary T Assignee Status Components

Other

Key Summary T Assignee Status Components
UIIN-2478 Inventory. Error in Cornell's environment (might be a follow-up on MODINV-829) Bug Michal Kuklis Closed
UIHAADM-75 Add guards to hide parts of the UI that the user lacks permission for Story Mike Taylor Closed
UIHAADM-73 Permissions - UI Harvester Admin Story Mike Taylor Closed
UIHAADM-9 Support management of transformation steps Story Mike Taylor Closed
UIHAADM-8 Support management of transformation pipelines Story Mike Taylor Closed
UIHAADM-7 Support management of storage engines Story Mike Taylor Closed
STSMACOM-762 Rendering loop when using <EntryManager> Bug Mike Taylor Closed
MODINVUP-69 CBS to FOLIO work flow. Unicode conversion Story Charles Ledvina Closed
MODINVUP-67 CBS to FOLIO work flow. Add version number to OUF console UI Story Charles Ledvina Closed
MODINVUP-61 CBS2FOLIO: Prevent upserts from deleting items created outside of cbs2folio Story Niels Erik Nielsen Closed
MODINV-829 /items-by-holdings-id fails when there is a large number of items (Orchid R1 2023 Service Patch) Bug Niels Erik Nielsen Closed
MODHAADM-65 Logs are not written to mod-harvester-admin after job completion Bug Niels Erik Nielsen Closed
MODHAADM-64 Display descriptive HTTP statuscode when PUTing to /harvester-admin/steps with invalid stepId Bug Niels Erik Nielsen Closed
MODHAADM-63 Enable storageBatchLimit in PUT/POST harvestable Bug Niels Erik Nielsen Closed
MODHAADM-38 OS license for com.indexdata:masterkey-common Task Niels Erik Nielsen Closed
MODHAADM-37 Legacy harvester: commons-beanutils Mad Gadget Arbitrary Code Execution Bug Niels Erik Nielsen Closed

Related content