https://folio-org.atlassian.net/browse/ERM-1923 / 

https://folio-org.atlassian.net/browse/ERM-1920

• Ethan to refer to Steve

https://folio-org.atlassian.net/browse/ERM-1973

@Claudia Malzer 

Save and retrieve does not display record

See related discussion in #erm-testing.

Appears to not retrieve

• Approach

  • may be as simple as adding a `shouldRefresh : true` to interfaces manifest on AgreementViewRoute (line 173)

  • otherwise may need a specific kind of refresh 

  • Or there may be an undocumented prop

• Components and Changes

  • Frontend

    • AgreementViewRoute

  • Backend: none

• Tests / Data: none

• Dependencies: none

• Known Unknowns

• QA: snapshot 

• Development Estimate: needs investigation

https://folio-org.atlassian.net/browse/ERM-1974

@Claudia Malzer 

Credentials button not uniquely identified when multiple interfaces

See related discussion in #erm-testing.

• Approach

  • not clear of credentials are hidden (uses - rather than *(

  • different interfaces should be acting independently, as per issue report

  • needs some straightforward refactoring to make the code clearer, add comments, remove redundant functionality etc

• Components and Changes

  • Frontend: viewOrganisationsCard on stripes-erm-components

  • Backend: none

• Tests / Data: 

  • need to add interface with multiple credentials via Organizations

• Dependencies: none

• Known Unknowns

• QA: snapshot 

• Development Estimate: needs investigation

https://folio-org.atlassian.net/browse/ERM-1943

Subject to feedback on how Agreements works with AWS, which is currently blocked. 

Moved for holding to Sprint 132. 

https://folio-org.atlassian.net/browse/UXPROD-3337

https://folio-org.atlassian.net/browse/UXPROD-3338

https://folio-org.atlassian.net/browse/ERM-1906

https://folio-org.atlassian.net/browse/ERM-1907

https://folio-org.atlassian.net/browse/ERM-1908

ERM-1909: On Local KB Admin External Data sources settings screen ensure "New" button is always visible to userClosedPreview

ERM-1910: Swap Licenses Pick lists settings screen to single 4 pane based layoutClosedPreview

ERM-1911: On Local KB Admin Proxy server settings screen ensure "New" button is always visible to userClosedPreview

Needs conversation between Owen and Gill. 

Will push back to new year, which may force a quick fix. 

FAT-82: ui-licenses: UI tests replacement with RTL/JestClosedPreview

ERM-1300: Add test coverage for ui-licenses <LicenseForm>ClosedPreview

ERM-1293: Add test coverage for ui-licenses <Amendment>ClosedPreviewERM-1301: Add test coverage for ui-licenses <NoPermissions>ClosedPreview

ERM-1301: Add test coverage for ui-licenses <NoPermissions>ClosedPreview

@Monireh Rasouli 

Done, but not able to pull request.

Continuing to have Jenkins issues. 

May need to expedite move to GitHub Actions 

• Ethan to follow up what is needed for frontend repositories

ERM-1904: Resource appears twice in "Dropped" list for agreementClosedPreview

Are the conditions to restart this right? Not really.

No real analysis of alternative index opportunities has been done. Needs a review of where the queries are (see ERM-1952). 

TODO:

• Close as Won't Do (in favour of ERM-1952)

• Tidy up ERM-1904 branch and PR

UXPROD-3339: Experiment with different title match process for Agreements KBClosedPreview

https://folio-org.atlassian.net/browse/ERM-1799

@Peter Böhm 

/ @Ethan Freestone 

• Approach

  • most identifiers are stored on TI, not PCI or PTI

    • this change duplicates it in multiple places

  • add new class (collection of matchkey information) to ermResource abstract class

  • tweak ingest to assign class to PCI and PTI

  • enact this where the entry points converge

    • creation of TIs happens in TitleInstanceResolver -

    • PCI and PTIs are created in a shared process during the ingest

  • store as domain class (matchkey/value string pair) rather than json

• Components and Changes

  • Frontend: none

  • Backend: mod-agreements

• Tests / Data

  • won't need to expose through api

  • locally verify with SQL queries to ensure appear in 

• Dependencies: none

• Known Unknowns: not yet

• QA: local vagrant

• Development Estimate: 

https://folio-org.atlassian.net/browse/ERM-1931

@Ethan Freestone 

Returned to Dev. Sort by reference not doing anything. 

This is not to do with null sorting, but comparing two non-null references.

Could be attempting to sort on grails transient getters(?). 

https://folio-org.atlassian.net/browse/UXPROD-3335

https://folio-org.atlassian.net/browse/ERM-1850

@Peter Böhm 

• PB to investigate issues with the query not filtering correctly

• Owen to test GOKb XML

https://folio-org.atlassian.net/browse/UXPROD-3140

https://folio-org.atlassian.net/browse/ERM-1744 / https://folio-org.atlassian.net/browse/ERM-1745

@Ethan Freestone

(@Monireh Rasouli )

In Code Review.

Work is done, but not locally tested against backend (couldn't get mod-service-interaction running). Will test as part of backend.

https://folio-org.atlassian.net/browse/ERM-1938

S3 File Migration blocked pending https://folio-org.atlassian.net/browse/FOLIO-3362

https://folio-org.atlassian.net/browse/ERM-1953

@Monireh Rasouli 

Jenkins errors on PR. Looks like okapi needs to be defined. a missing dependency on ui-licenses, so that needs adding. Suggests there's a duplicate in stripes core, caused by a dependency on a different version. 

DONE: 

• Changes work fine locally

• Test are added and running

TODO:

• Check useAcq methods

• mock useOkapiKY as  a call from stripes-core