ERM Sprint 128

Owned by Jag Goraya
Last updated: Dec 02, 2021

Sprint Goal / Focus

  • Bugs
  • Document storage to support S3 interfaces (ERM-1929)

Sprint Schedule

  • Sprint: 128
    • Start Fri 19 Nov
    • Finish Fri 3 Dec
    • Sprint Board
    • Jira Sprint: 1091
  • Release: 2022.1 Lotus  
    • Sprint 133: Module Release Deadline
      • Backend 16 Feb 2022
      • Frontend 18 Feb 2022
    • Sprint 136: Bugfix Deadline (25 March 2022)

Sprint Capacity

Team Availability: Schedule | Calendar

Notes / Exceptions:

  • 22-23 Nov: Adi 0.5d
  • From Wed 24 Nov:  No Adi

Lead Roles:

QA Environment: folio-snapshot

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?
  • What front and back end components are affected?
  • What changes need to be made? (additions, removals or modifications)
  • What development tests need to be written?  
  • What data does the developer need to verify their work?
  • What are the known unknowns? 
  • What is needed to QA? (environment, data, scripts)

Navigation

 Sprint Planning Agenda
  1. Sprint Goal / Focus
  2. Sprint Capacity
  3. Review sprint candidates 
  4. Agree technical approach / define key implementation tasks
  5. Finalise estimates / costings
  6. Confirm sprint scope
  7. Confirm first actions




Sprint Planning  

(error) - not in sprint

(tick) or @ - in sprint 


Planning Notes Template

  • Approach
  • Components and Changes
    • Frontend
    • Backend
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA: local | testing | snapshot | other
  • Development Estimate

Sprint Focus

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

UXPROD-3339 - Getting issue details... STATUS

ERM-1799 - Getting issue details... STATUS

(error)


ERM-1852 - Getting issue details... STATUS

ERM-1927 - Getting issue details... STATUS

Ethan Freestone 

  • Approach
    • happens on switcher rather than just date, such as internal contacts
    • using radio fields rather than FOLIO options (as we need to render a different one than a label)
    • is it time to make this a proper component?
    • refactor needed to 
      • remove relative-or-absolute component, including
      • replace with tokenised UUID picker and tokenised date picker
      • cleanup existing usages
  • Components and Changes
    • Frontend: ui-dashboard relative-or-absolute component
    • Backend: none
  • Tests / Data: new required
  • Dependencies: none
  • Known Unknowns: none
  • QA: snapshot
  • Development Estimate: 4d refactor + 2d tests


ERM-1928 - Getting issue details... STATUS

Aditya matukumalli 

  • Approach
    • simple frontend validation
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: none
  • Tests / Data /  Dependencies / Known Unknown
  • QA: snapshot 
  • Development Estimate: deliver along with RTL Baskets

ERM-1926 - Getting issue details... STATUS

Ethan Freestone 

  • Approach
    • looks like using an existing pattern for deletion: entitlement should be set to null
    • the lingering thing needs to be removed from entitlement line before rendering
  • Components and Changes
    • Frontend: none
    • Backend: mod-agreements  
  • Tests / Data: no change to entitlement log tests
  • Dependencies: 
  • Known Unknowns:
    • does this need to be reflected in the similar original code within the export service?
  • QA: snapshot 
  • Development Estimate: 0.5d

ERM-1886 - Getting issue details... STATUS

Owen Stephens 

  • same error as ERM-1892 - Getting issue details... STATUS
  • Owen to re-verify

ERM-1931 - Getting issue details... STATUS

(tick)

Owen Stephens to test api initially


  • Approach
    • test whether api supports tertiary sort (on snapshot via postman)
    • if supported, change request in ui to add sort parameters
    • no requirement for adding UI to change sort options. No change to pagination.
  • Components and Changes
    • Frontend: ui-agreements: AgreementViewRoute for agreement lines
    • Backend: web-toolkit-ce
  • Tests / Data: na
  • Dependencies
  • Known Unknowns
    • is tertiary sort supported already in api?
    • does stripes-erm-components support more than two sort parameter values? (using generateQuery not getSas) ... not applicable
  • QA: snapshot 
  • Development Estimate

ERM-1932 - Getting issue details... STATUS

Claudia Malzer 
  • Approach
    • ingest happens when mod-agreements launches and errors  are reported inside a job, appearing automatically when gokb harvest starts
    • remove the offending line
  • Components and Changes
    • Frontend: none
    • Backend: mod-agreements
  • Tests / Data / Dependencies
    • requires sample data and gokb synb
  • Known Unknowns: none
  • QA: snapshot 
  • Development Estimate: <0.5d
UXPROD-3338 - Getting issue details... STATUS ERM-1921 - Getting issue details... STATUS Claudia Malzer 
  • Approach
    • only applies to external resources
    • logic exists to work out whether an external resource
    • object should return whether it is selected
    • then extend label to show count
  • Components and Changes
    • Frontend: ui-agreements, eresourceCount
    • Backend: none
  • Tests / Data:
    • update RTL tests in eresourceCount
    • can delete the BigTests
  • Dependencies / Known Unknowns
  • QA: snapshot 
  • Development Estimate: 0.5d

UXPROD-3338 - Getting issue details... STATUS

ERM-1922 - Getting issue details... STATUS

Claudia Malzer 

  • Approach
    • use novalue component to handle aria labelling
    • if blank (null) then MCL and screenreaders should handle this
  • Components and Changes
    • Frontend: ui-agreements, eresourceCount
    • Backend: none
  • Tests / Data:
    • update RTL tests in eresourceCount
    • can delete the BigTests
  • Dependencies / Known Unknowns
    • Gill to confirm UX consistency approach (- or null)
  • QA: snapshot 
  • Development Estimate: 0.5d

UXPROD-3172 - Getting issue details... STATUS

ERM-1929 - Getting issue details... STATUS

(error)

TODO

  1. Ethan to comment with technical review / considerations
  2. Gill to Review Reshare UI
  • Approach
    • ReShare app settings already support configurations
    • Can display all settings dynamically or selectively build a  semi-dynamic or conditional settings page
    • Reshare UI is accepted to PO
    • Potentially add domain class to dynamically handle other app settings

ERM-1923 - Getting issue details... STATUS

(error)

Issue: 

  • duplicate owner is added wrongly
  • comma inserted in wrong place

Needs more triage - referring to Steve.


ERM-1920 - Getting issue details... STATUS

(error)

Use of owner with UUID is causing error 500, so should use owner.id.

Potentially a change to web-toolkit. 

FAT-81 - Getting issue details... STATUS

ERM-1469 - Getting issue details... STATUS

ERM-1470 - Getting issue details... STATUS

ERM-1471 - Getting issue details... STATUS

(tick)

FAT-81 - Getting issue details... STATUS

ERM-1475 - Getting issue details... STATUS

ERM-1476 - Getting issue details... STATUS

ERM-1477 - Getting issue details... STATUS

(tick)








Rolled Over From Previous Sprint

For Development

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

FAT-81 - Getting issue details... STATUS

ERM-1661 - Getting issue details... STATUS  

Aditya matukumalli 


FAT-81 - Getting issue details... STATUS

ERM-1284 - Getting issue details... STATUS

Monireh Rasouli 


FAT-81 - Getting issue details... STATUS

ERM-1292 - Getting issue details... STATUS

Monireh Rasouli

Ready for Code Review

ERM-1850 - Getting issue details... STATUS

Peter Böhm 



ERM-1912 - Getting issue details... STATUS

Peter Böhm 

Test Approach: 

  • Source data has been fixed, so testing without faking the data is going to be problematic (faking or proxying)
  • Set internal value to empty
  • TODO: run integration tests
  • QA: regression test 

ERM-1904 - Getting issue details... STATUS

(error) 

Changes ready to go forward with existing indexes.

Delay is still around 7s.

PO concern: that a fix that would slow everything down might go in for an occasional or intermittent issue.

Affects any instance of repeated fields, where a package and resource are both attached to an agreement. 

TODO: 

  • Ethan to get branch in good parked state
  • Ethan to discuss with Ian about performance

For QA

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions





For Release Prep

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions


ERM-1900 - Getting issue details... STATUS

Owen Stephens 



ERM-1759 - Getting issue details... STATUS  

ERM-1760 - Getting issue details... STATUS

ERM-1761 - Getting issue details... STATUS

Owen Stephens 



ERM-1882 - Getting issue details... STATUS

Owen Stephens



ERM-1883 - Getting issue details... STATUS

Owen Stephens



ERM-1884 - Getting issue details... STATUS

Owen Stephens



Bugfix Cycle

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions





Brought In

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

FAT-81 - Getting issue details... STATUS

ERM-1493 - Getting issue details... STATUS

Monireh Rasouli 


FAT-81 - Getting issue details... STATUS

ERM-1478 - Getting issue details... STATUS

Monireh Rasouli


FAT-81 - Getting issue details... STATUS

ERM-1479 - Getting issue details... STATUS

Monireh Rasouli


FAT-81 - Getting issue details... STATUS

ERM-1480 - Getting issue details... STATUS

Monireh Rasouli



ERM-1937 - Getting issue details... STATUS

Peter Böhm 

Single line change (113) in ui-agreements.package.json

Verify with existing test suite, then raise 

UXPROD-3172 - Getting issue details... STATUS

ERM-1938 - Getting issue details... STATUS

Owen Stephens 

See approach outlined in subtasks.

  • Development work competed
  • Initial regression testing setup to be started this sprint ...
  • ... to enable frontend and regression testing in Sprint 129. 

FAT-81 - Getting issue details... STATUS

ERM-1481 - Getting issue details... STATUS

Monireh Rasouli


FAT-81 - Getting issue details... STATUS

ERM-1482 - Getting issue details... STATUS

Monireh Rasouli


FAT-81 - Getting issue details... STATUS

ERM-1483 - Getting issue details... STATUS

Monireh Rasouli


Removed

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3339 - Getting issue details... STATUS

ERM-1799 - Getting issue details... STATUS



UXPROD-3172 - Getting issue details... STATUS

ERM-1929 - Getting issue details... STATUS


Pending UX input

UXPROD-3338 - Getting issue details... STATUS


ERM-1922 - Getting issue details... STATUS


Pending UX input



Sprint Summary

ERM


key summary type assignee status components
Refresh


Dashboard

key summary type assignee status components
Refresh

Other

key summary type assignee status components
Refresh