ERM Sprint 128

ERM Sprint 128

Sprint Goal / Focus

  • Bugs

  • Document storage to support S3 interfaces (ERM-1929)

Sprint Schedule

  • Sprint: 128

    • Start Fri 19 Nov

    • Finish Fri 3 Dec

    • Sprint Board

    • Jira Sprint: 1091

  • Release: 2022.1 Lotus  

    • Sprint 133: Module Release Deadline

      • Backend 16 Feb 2022

      • Frontend 18 Feb 2022

    • Sprint 136: Bugfix Deadline (25 March 2022)

Sprint Capacity

Team AvailabilitySchedule | Calendar

Notes / Exceptions:

  • 22-23 Nov: Adi 0.5d

  • From Wed 24 Nov:  No Adi

Lead Roles:

  • Front End Code Review: @Ethan Freestone

  • Back End Code Review:  @Ethan Freestone

  • QA: @Owen Stephens 

QA Environment: folio-snapshot

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?

  • What front and back end components are affected?

  • What changes need to be made? (additions, removals or modifications)

  • What development tests need to be written?  

  • What data does the developer need to verify their work?

  • What are the known unknowns? 

  • What is needed to QA? (environment, data, scripts)

Navigation

  1. Sprint Goal / Focus

  2. Sprint Capacity

  3. Review sprint candidates 

  4. Agree technical approach / define key implementation tasks

  5. Finalise estimates / costings

  6. Confirm sprint scope

  7. Confirm first actions

 

 

 


Sprint Planning  

 - not in sprint

 or @ - in sprint 

 

Planning Notes Template

  • Approach

  • Components and Changes

    • Frontend

    • Backend

  • Tests / Data

  • Dependencies

  • Known Unknowns

  • QA: local | testing | snapshot | other

  • Development Estimate

Sprint Focus

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/UXPROD-3339

https://folio-org.atlassian.net/browse/ERM-1799

 

https://folio-org.atlassian.net/browse/ERM-1852

https://folio-org.atlassian.net/browse/ERM-1927

@Ethan Freestone 

  • Approach

    • happens on switcher rather than just date, such as internal contacts

    • using radio fields rather than FOLIO options (as we need to render a different one than a label)

    • is it time to make this a proper component?

    • refactor needed to 

      • remove relative-or-absolute component, including

      • replace with tokenised UUID picker and tokenised date picker

      • cleanup existing usages

  • Components and Changes

    • Frontend: ui-dashboard relative-or-absolute component

    • Backend: none

  • Tests / Data: new required

  • Dependencies: none

  • Known Unknowns: none

  • QA: snapshot

  • Development Estimate: 4d refactor + 2d tests

 

https://folio-org.atlassian.net/browse/ERM-1928

@Aditya matukumalli 

  • Approach

    • simple frontend validation

  • Components and Changes

    • Frontend: ui-agreements

    • Backend: none

  • Tests / Data /  Dependencies / Known Unknown

  • QA: snapshot 

  • Development Estimate: deliver along with RTL Baskets

 

https://folio-org.atlassian.net/browse/ERM-1926

@Ethan Freestone 

  • Approach

    • looks like using an existing pattern for deletion: entitlement should be set to null

    • the lingering thing needs to be removed from entitlement line before rendering

  • Components and Changes

    • Frontend: none

    • Backend: mod-agreements  

  • Tests / Data: no change to entitlement log tests

  • Dependencies: 

  • Known Unknowns:

    • does this need to be reflected in the similar original code within the export service?

  • QA: snapshot 

  • Development Estimate: 0.5d

 

https://folio-org.atlassian.net/browse/ERM-1886

@Owen Stephens 

 

https://folio-org.atlassian.net/browse/ERM-1931

@Owen Stephens to test api initially

 

  • Approach

    • test whether api supports tertiary sort (on snapshot via postman)

    • if supported, change request in ui to add sort parameters

    • no requirement for adding UI to change sort options. No change to pagination.

  • Components and Changes

    • Frontend: ui-agreements: AgreementViewRoute for agreement lines

    • Backend: web-toolkit-ce

  • Tests / Data: na

  • Dependencies

  • Known Unknowns

    • is tertiary sort supported already in api?

    • does stripes-erm-components support more than two sort parameter values? (using generateQuery not getSas) ... not applicable

  • QA: snapshot 

  • Development Estimate

 

https://folio-org.atlassian.net/browse/ERM-1932

@Claudia Malzer 

  • Approach

    • ingest happens when mod-agreements launches and errors  are reported inside a job, appearing automatically when gokb harvest starts

    • remove the offending line

  • Components and Changes

    • Frontend: none

    • Backend: mod-agreements

  • Tests / Data / Dependencies

    • requires sample data and gokb synb

  • Known Unknowns: none

  • QA: snapshot 

  • Development Estimate: <0.5d

https://folio-org.atlassian.net/browse/UXPROD-3338

https://folio-org.atlassian.net/browse/ERM-1921

@Claudia Malzer 

  • Approach

    • only applies to external resources

    • logic exists to work out whether an external resource

    • object should return whether it is selected

    • then extend label to show count

  • Components and Changes

    • Frontend: ui-agreements, eresourceCount

    • Backend: none

  • Tests / Data:

    • update RTL tests in eresourceCount

    • can delete the BigTests

  • Dependencies / Known Unknowns

  • QA: snapshot 

  • Development Estimate: 0.5d

https://folio-org.atlassian.net/browse/UXPROD-3338

https://folio-org.atlassian.net/browse/ERM-1922

@Claudia Malzer 

  • Approach

    • use novalue component to handle aria labelling

    • if blank (null) then MCL and screenreaders should handle this

  • Components and Changes

    • Frontend: ui-agreements, eresourceCount

    • Backend: none

  • Tests / Data:

    • update RTL tests in eresourceCount

    • can delete the BigTests

  • Dependencies / Known Unknowns

    • Gill to confirm UX consistency approach (- or null)

  • QA: snapshot 

  • Development Estimate: 0.5d

https://folio-org.atlassian.net/browse/UXPROD-3172

https://folio-org.atlassian.net/browse/ERM-1929

TODO

  1. Ethan to comment with technical review / considerations

  2. Gill to Review Reshare UI

  • Approach

    • ReShare app settings already support configurations

    • Can display all settings dynamically or selectively build a  semi-dynamic or conditional settings page

    • Reshare UI is accepted to PO

    • Potentially add domain class to dynamically handle other app settings

 

https://folio-org.atlassian.net/browse/ERM-1923

Issue: 

  • duplicate owner is added wrongly

  • comma inserted in wrong place

Needs more triage - referring to Steve.

 

https://folio-org.atlassian.net/browse/ERM-1920

Use of owner with UUID is causing error 500, so should use owner.id.

Potentially a change to web-toolkit. 

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1469

https://folio-org.atlassian.net/browse/ERM-1470

https://folio-org.atlassian.net/browse/ERM-1471

 

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1475

https://folio-org.atlassian.net/browse/ERM-1476

https://folio-org.atlassian.net/browse/ERM-1477

 




 

 

 

 

 

Rolled Over From Previous Sprint

For Development

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1661 

@Aditya matukumalli 

 

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1284

@Monireh Rasouli 

 

https://folio-org.atlassian.net/browse/FAT-81

https://folio-org.atlassian.net/browse/ERM-1292

@Monireh Rasouli

Ready for Code Review

 

https://folio-org.atlassian.net/browse/ERM-1850

@Peter Böhm 

 

 

https://folio-org.atlassian.net/browse/ERM-1912

@Peter Böhm 

Test Approach: 

  • Source data has been fixed, so testing without faking the data is going to be problematic (faking or proxying)

  • Set internal value to empty

  • TODO: run integration tests

  • QA: regression test 

 

https://folio-org.atlassian.net/browse/ERM-1904

 

Changes ready to go forward with existing indexes.

Delay is still around 7s.

PO concern: that a fix that would slow everything down might go in for an occasional or intermittent issue.

Affects any instance of repeated fields, where a package and resource are both attached to an agreement. 

TODO: 

  • Ethan to get branch in good parked state

  • Ethan to discuss with Ian about performance

For QA

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

 

For Release Prep

 

Bugfix Cycle

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

 

 

 

 

Brought In

Feature ID

Feature ID