/
ERM Sprint 126

ERM Sprint 126

Owned by Jag Goraya
Last updated: Nov 03, 2021

Sprint Goal / Focus

  • Bugfest: some deployment issues
    • mod-agreements
    • ui-handler-stripes-registry 
  • Entitlement Log improvements
  • Agreements RTL Migration

Sprint Schedule

  • Sprint: 126
    • Start Mon 25 Oct
    • Finish Fri 5 Nov
    • Sprint Board
    • Jira Sprint: 1080
  • Release: 2022.1 Lotus  
    • Sprint 133: Module Release Deadline
      • Backend 16 Feb 2022
      • Frontend 18 Feb 2022
    • Sprint 136: Bugfix Deadline (25 March 2022)

Sprint Capacity

Team Availability: Schedule | Calendar

Notes / Exceptions:

Lead Roles:

QA Environment: folio-snapshot

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?
  • What front and back end components are affected?
  • What changes need to be made? (additions, removals or modifications)
  • What development tests need to be written?  
  • What data does the developer need to verify their work?
  • What are the known unknowns? 
  • What is needed to QA? (environment, data, scripts)

Navigation

 Sprint Planning Agenda
  1. Sprint Goal / Focus
  2. Sprint Capacity
  3. Review sprint candidates 
  4. Agree technical approach / define key implementation tasks
  5. Finalise estimates / costings
  6. Confirm sprint scope
  7. Confirm first actions




Sprint Planning  

(error) - not in sprint

(tick) or @ - in sprint 


Planning Notes Template

  • Approach
  • Components and Changes
    • Frontend
    • Backend
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA
    • environment: local | testing | snapshot | other
    • data / scripts
  • Development Estimate

Sprint Focus

Feature ID

Issue ID

Sprint Backlog?

Notes / Estimates / Actions


ERM-1901 - Use formattedNumber for custom properties with Integer type Closed

Claudia Malzer
  • Approach
    • no apparent difference between decimal and integer types
    • when changing locale and number setting to arabic
    • needs to be configured on user locale
    • needs to be pointed to snapshot for development testing
  • Components and Changes
    • Frontend: stripes-erm-components
    • Backend: none
  • Tests / Data: none
  • Dependencies: none
  • Known Unknowns: none
  • QA
    • environment: snapshot 
    • data / scripts: none
  • Development Estimate: <1h
FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1289 - Add test coverage for ui-agreements <RelatedTitleInfo> Closed

Claudia Malzer

  • Approach: RTL Migration
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: none
  • Dependencies: None
  • Known Unknowns: coverage gaps
  • QA: NA
  • Development Estimate: in code review

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1282 - Add test coverage for ui-agreements <OpenBasketButton> Closed

Claudia Malzer

  • Approach: RTL Migration
    • to test ifPermission wrap around button
      • mocked, see stripes-erm-components
      • no testing of permission directly
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: none
  • Dependencies: None
  • Known Unknowns: coverage gaps
  • QA: NA
  • Development Estimate: <2h

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1257 - Add test coverage for ui-agreements <AgreementFilters> Closed

Monireh Rasouli

  • Approach: RTL Migration
    • 80% coverage
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: none
  • Dependencies: None
  • Known Unknowns: coverage gaps
  • QA: NA
  • Development Estimate: expected for code review EOD
FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1269 - Add test coverage for ui-agreements <EResourceFilters> Closed

Monireh Rasouli

  • Approach: RTL Migration
  • Components and Changes
    • Frontend: ui-agreements
    • Backend: none
  • Dependencies: None
  • Known Unknowns: coverage gaps
  • QA: NA
  • Development Estimate: expected for code review Tuesday

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1488 - Add test coverage for ui-agreements <GeneralSettings> Closed

Monireh Rasouli


FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1490 - Remove unused files for ui-agreements <OrgRoleSettings> Closed

Claudia Malzer


FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1491 - Add test coverage for ui-agreements <PickListSettings> Closed

Claudia Malzer

Approach: test labels and values that are presented in DOM by vocab list

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1492 - Add test coverage for ui-agreements <PickListValueSettings> Closed

Claudia Malzer

Approach: test labels and values that are presented in DOM by vocab list

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1474 - Add test coverage for ui-agreements <BasketRoute> Closed

Claudia Malzer









Rolled Over From Previous Sprint

For Development

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions


ERM-1852 - Dashboard: End date filter: make the Date form control inactive when the Comparator = "Is set" or "Is not set" Closed

Aditya matukumalli

PR #1623 in stripes-component has been approved by John Coburn. This issue should now be clear for completion.

  • Ready to merge
  • Zak and John to confirm minor or other release version

Estimate: <1h

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1661 - Add test coverage for ui-agreements <components / views> Closed

Aditya matukumalli

These subtasks are more complex, and are to be picked up after simpler tests and feature work: 

  • ERM-1666 - Add test coverage for <Agreements.js> Closed
  • ERM-1676 - Add test coverage for <Platforms.js> Closed
  • ERM-1669 - Add test coverage for <EResources.js> Closed

This sprint:

  • All other sub-issues

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1467 - Add test coverage for ui-agreements <AgreementCreateRoute> Closed

ERM-1468 - Add test coverage for ui-agreements <AgreementEditRoute> Closed

ERM-1472 - Add test coverage for ui-agreements <AgreementViewRoute> Closed

Aditya matukumalli

For code review.

UXPROD-3338 - UX improvements for Agreements R1 2022 Closed

ERM-1813 - Include sibling title instance details in agreement and agreement line export Closed

ERM-1879 - Introduce Grails integration test for Export Closed

Peter Böhm

  • TODO: 
    • unexpected outcome when attempting evaluation via resources/export/current
      • r/e/current is list rather than a map
    • code cleanup
  • Components and Changes
    • Backend: mod-agreements
  • Tests / Data / Dependencies: none
  • Known Unknowns: none
  • QA
    • environment: snapshot 
    • data / scripts: NA
  • Development Estimate: aim to code review EOD

UXPROD-3335 - Support ZDB as a source of title data for the Agreements local KB Closed

ERM-1850 - In e-resources search and sort results only include results that have entitlementOptions Closed

Peter Böhm

  • Approach
    • Improve usability of kb
  • Components and Changes
    • Frontend: none
    • Backend: mod-agreements ResourceController
  • Tests / Data: none
  • Dependencies: none
  • Known Unknowns: none
  • QA
    • environment: locally - because of daily title-harvest
    • data: set up a harvest for title-only data
  • Development Estimate: 2d

UXPROD-2817 - ERM Agreements Title addition and removal feed Closed

ERM-1902 - Framework for UPDATE entitlement log entry events Closed / ERM-1900 - Change to suppressFromDiscovery should lead to updated entry in EntitlementLog Closed


Ethan Freestone
  • Approach
    • suppress entry needs to be persisted on entitlement log
    • update between timed runs would not be caught
    • Revise HQL queries
    • Rework existing code issues
  • Components and Changes
    • Frontend: none
    • Backend: Update logic to handle suppressed fields in mod-agreements
  • Tests / Data: none
  • Dependencies: 
    • need some kind of infrastructure to support recording when a field on a resource is changed as per 
  • Known Unknowns: no
  • QA
    • environment: local | testing | snapshot | other
    • data
    • scripts
  • Development Estimate:  
    • framework: 3d 
    • config: 2d

UXPROD-2817 - ERM Agreements Title addition and removal feed Closed

ERM-1883 - Change to coverage should lead to updated entry in EntitlementLog Closed

Ethan Freestone
  • Approach: 
  • Components and Changes
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA
    • environment: local | testing | snapshot | other
    • data / scripts
  • Development Estimate: 2d

ERM-1888 - Display syncStatus, cursor and lastChecked for local KB admin External data sources Closed

Aditya matukumalli

Returned from QA

  • TODO: display lastChecked timestamp in UTC
  • Development Estimate: <1h

For QA

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-2817 - ERM Agreements Title addition and removal feed Closed

ERM-1882 - Use Custom Coverage (if exists) in EntitlementLog Closed

Owen Stephens


UXPROD-2817 - ERM Agreements Title addition and removal feed Closed

ERM-1884 - Populate "suppress" field in EntitlementLog Closed

Owen Stephens

UXPROD-3372 - Improved user facing logs for Agreements local KB harvest/ingest Closed

ERM-1890 - On ingesting TIPPs from GOKb only attempt to create a coverage statement in Local KB if there is a coverage statement in GOKb Closed

Owen Stephens


ERM-1687 - Dashboard: Prevent columns being added more than once in a simple search widget Closed

ERM-1899 - Add Save and Close validation Closed

Owen Stephens

Previously: not appearing on snapshot

For Release Prep

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3336 - UX improvements for Dashboard R1 2022 Closed

ERM-1791 - Dashboard: Make the "Edit widget display order" menu option inactive when less then 2 widgets exist Closed

Owen Stephens


UXPROD-3336 - UX improvements for Dashboard R1 2022 Closed

ERM-1688 - Dashboard: On "New" simple search widget, populate one column by default Closed

Owen Stephens



Bugfix Cycle

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions


ERM-1891 - Agreement Lines do not display in Agreement edit screen Closed

Owen Stephens

Released for R3 2020 Bug Fix, as part of ERM-1905 - mod-agreements release. Fix version: 5.0.1 Closed


ERM-1892 - Error on attempting to view comparison job report Closed

Owen Stephens

Released for R3 2020 Bug Fix, as part of ERM-1905 - mod-agreements release. Fix version: 5.0.1 Closed


ERM-1903 - On editing an agreement with an agreement line for a PCI, "custom coverage" incorrectly populated Closed

Owen Stephens

Released for R3 2020 Bug Fix, as part of ERM-1905 - mod-agreements release. Fix version: 5.0.1 Closed

Brought In

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1489 - Add test coverage for ui-agreements <GeneralSettingsForm> Closed




FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1487 - Add test coverage for ui-agreements <withFileHandlers> Closed



FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1495 - Add test coverage for ui-agreements <SupplementaryPropertiesConfigForm> Closed



FAT-81 - ui-agreements: UI tests replacement with RTL/Jest Closed

ERM-1494 - Add test coverage for ui-agreements <SuppressFromDiscoveryFields> Closed




ERM-1914 - Exception thrown on rendering the agreement / entitlement gson templates Closed

Ethan Freestone

See Slack thread: https://folio-project.slack.com/archives/CAYCU07SN/p1635337379004900

 ERM-1915 - Exception editing an Agreement having Agreement line with large number of poLines Closed

Aditya matukumalli

See Slack thread: https://folio-project.slack.com/archives/CAYCU07SN/p1635845764021600

ERM-1916 - mod-agreements release. Fix version: 5.0.4 Closed

Ethan Freestone

Removed

Feature IDIssue IDSprint Backlog?

Notes / Estimates / Actions

UXPROD-3156 - Apply guidelines for the display of shortcut key combinations in an app's "Keyboard shortcuts" modal Closed

ERM-1757 - Agreements: Apply keyboard shortcuts modal guidelines Closed

ERM-1758 - Licenses: Apply keyboard shortcuts modal guidelines Closed

ERM-1759 - ERM Comparisons: Apply keyboard shortcuts modal guidelines Closed

ERM-1760 - Local KB admin: Apply keyboard shortcuts modal guidelines Closed

ERM-1761 - Dashboard: Apply keyboard shortcuts modal guidelines Closed

(question)

Aditya matukumalli

  • Approach
    • use API provided through STCOM-865 PR#1617
    • PR is
      • waiting for John Coburn to review
      • out of date with base branch
  • Components and Changes
    • Frontend:
      • ui-agreements
      • ui-licenses
      • ui-erm-comparisons
      • ui-local-kb-admin
      • ui-dashboard
    • Backend: none
  • Tests / Data: none
  • Dependencies
    • PR #1565  for STCOM-865 is closed without merging, and no longer is required for or blocks these issues
    • PR #1617 for STCOM raised and pending review
      • merge block for Kiwi release removed 
  • Known Unknowns
  • QA
    • environment: local | testing | snapshot | other
    • data
    • scripts
  • Development Estimate

UXPROD-3336 - UX improvements for Dashboard R1 2022 Closed

ERM-1687 - Dashboard: Prevent columns being added more than once in a simple search widget Closed

(error)

  • Approach
    • Save and Close validates but does not present an error message in given circumstances
    • Should work if set as touched, eg, via a mutator
    • no existing pattern in codebase
      • as form content is unknown exist at runtime
    • Aim to instantiate object with a meta.touched = true property when 
      • a default option is selected
      • autofocus is not used
    • Alternatively: set focus on a newly added item
      • getLast has been exposed by stripes, so that could be used on this 
      • decision: not to go down this way
    • Alternatively: 
      • make focus behave with expected validation
      • expected behaviour is that a user will want to edit the item added (rather than add lots of things then edit them)
      • autofocus only if dirty, then go to last field
    • TODO: 
  • Components and Changes
    • Frontend: ui-dashboard
    • Backend: none
  • Tests / Data / Dependencies: blocked on tradeoff decision
  • Known Unknowns: NA
  • QA
    • environment: snapshot 
    • data / scripts: no
  • Development Estimate: unknown

ERM-1904 - Resource appears twice in "Dropped" list for agreement Closed

(error)

Ethan Freestone

  • Approach
  • Components and Changes
    • Frontend
    • Backend
  • Tests / Data
  • Dependencies
  • Known Unknowns
  • QA
    • environment: local | testing | snapshot | other
    • data / scripts
  • Development Estimate






Sprint Summary

ERM


Key Summary T Assignee Status Components
No issues found Refresh


Dashboard

Key Summary T Assignee Status Components
No issues found Refresh

Other

Key Summary T Assignee Status Components
STCOM-885 Document axe testing advice Task John Coburn Closed
FOLIO-3253 SPIKE - Investigate minimal FOLIO platform Task Zak Burke Closed
2 issues Refresh

Related content