ERM Sprint 183

ERM Sprint 183

Sprint Goal / Focus 

  •  

Sprint Schedule

  • Sprint: 183

  • Release: 2024.1 Quesnalia 

    • Sprint 8 of 11 since Release Development Cycle Starts (Sprint 176) to Feature Freeze (Sprint 186: 15 Mar 2024)

    • Sprint 187: Module Release Deadline (22 Mar 2024) [FOLREL-565]

    • Sprint 189: Bugfix Release Deadline (19 Apr 2024) [FOLREL-581]

Development Meetings

  • Wed 24 Jan - retro

  • Mon 29 Jan - mid-sprint review

  • Wed 31 Jan - dev update

Sprint Capacity

Team AvailabilitySchedule | Calendar

Notes / Exceptions:

Lead Roles:

  • Code Review: @Ethan Freestone 

  • QA:  @Owen Stephens 

QA Environment: 

  • folio-snapshot, folio-snapshot-2

Present

  • @Jag Goraya 

  • @Owen Stephens 

  • @Claudia Malzer 

  • @Jack Golding 

  • @Ethan Freestone 

Planning Questions

  • Does the issue meet the criteria for Definition of Ready?

  • What front and back end components are affected?

  • What changes need to be made? (additions, removals or modifications)

  • What development tests need to be written?  

  • What data does the developer need to verify their work?

  • What are the known unknowns? 

  • What is needed to QA? (environment, data, scripts)

Navigation

  1. Sprint Goal / Focus

  2. Sprint Capacity

  3. Review sprint candidates 

  4. Agree technical approach / define key implementation tasks

  5. Finalise estimates / costings

  6. Confirm sprint scope

  7. Confirm first actions

 

 

 


Sprint Planning  

 - not in sprint

 or @ - in sprint 

- not ready

- pending triage / planning

Sprint Focus

Planning Notes Template

  • Triage

  • Approach

  • Components and Changes

    • Frontend

    • Backend

  • Tests / Data / Dependencies

  • Known Unknowns

  • QA: snapshot | local | testing | other

  • Release Target: 

  • Development Estimate

 

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Carried Over

Issue ID

Sprint Backlog?

Notes / Estimates / Actions

Carried Over

https://folio-org.atlassian.net/browse/ERM-1910

https://folio-org.atlassian.net/browse/ERM-3119

https://folio-org.atlassian.net/browse/ERM-3120

@Owen Stephens 

Testrails

Sprint 180

https://folio-org.atlassian.net/browse/ERM-3063

@Owen Stephens 

QA

Sprint 176

https://folio-org.atlassian.net/browse/ERM-3121

@Owen Stephens 

QA

Sprint 180

https://folio-org.atlassian.net/browse/ERM-3128

@Owen Stephens 

QA

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3127

@Ethan Freestone 

Code Review

Sprint 182

https://folio-org.atlassian.net/browse/ERM-2792

@Ethan Freestone 

 

Code Review

Sprint 178

https://folio-org.atlassian.net/browse/ERM-3126

@Ethan Freestone 

 

 

 

Code Review

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3090

Steve Osguthorpe

Code Review

Sprint 180

https://folio-org.atlassian.net/browse/ERM-3111

@Ethan Freestone 

STUCK 

  • Triage

    • previously created new Grails 6 project and incrementally added components

    • once pitfalls identified, each module took very little time

  • Approach

    • will starting up a new grails project with the CLI even work?

  • Components and Changes

    • Frontend

    • Backend

  • Tests / Data / Dependencies

    • gradle upgrade is necessary

  • Known Unknowns

    • will starting up a new grails project with the CLI even work?

  • QA: snapshot | local | testing | other

  • Release Target: 

  • Development Estimate

  • Current:

    • grails and gradle versions determined

    • web-toolkit passing tests

    • smoother process than 4 to 5, but integration is inevitably 

  • TODO

    • service-interaction failing

    • need to build into okapi environment

      • may need to rebuild rancher, which could be risky at the moment

    • review migrations, but difficult to triage atm

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3078

@Jack Golding 

In Progress

  • enforceVersionCheck is taken from grails default rest controller - not sure of impact to changing from false to true

  • can add to to yaml without changing default to false

  • would need to make changes to KIWT restful controller

  • need to push version numbers

  • likely not to be rolled in until Grails 6

  • TODO: 

    • Jack to write up findings 

    • Owen to review with users

Sprint 178

https://folio-org.atlassian.net/browse/ERM-2793

@Monireh Rasouli 

In Progress

 

https://folio-org.atlassian.net/browse/ERM-3089

@Ethan Freestone 

 

Sprint 178

https://folio-org.atlassian.net/browse/SI-34

@Ethan Freestone 

 

Sprint 173

https://folio-org.atlassian.net/browse/SI-38

@Ethan Freestone 

 

Sprint 179

https://folio-org.atlassian.net/browse/ERM-3133

@Claudia Malzer 

  • Triage

    • FOLIO session-level

  • Approach

    • review implementation across other apps

      • eg, Orders, 

      • eg, stripes-smart-components useColumnManager 

    • can this be used as-is within ERM or does it need streamlining?

  • Components and Changes

    • Frontend: TBC

    • Backend: none

  • Tests / Data / Dependencies: ??

  • Known Unknowns: ??

  • QA: snapshot | local | testing | other

  • Release Target: Quesnelia

  • Development Estimate: ??

 

https://folio-org.atlassian.net/browse/ERM-3118

@Jack Golding  

Triage

Current: 

  • upgrade path documentation doesn't help

  • looks like (via grep) this is the only use of ehcache

Sprint 182

  • need to decide whether to bail ehcache to use another NamedFactory provider

  • potentially could do this internally, without another dependency

  • run gradle clean  and check dependencies to see if ehcache/jetty-io are brought in transitively - CONFIRMED on v2

Sprint 183

  • Current

    • NamedThreadFactory doesn't seem critical or fancy

    • and it looks like it's only in mod-agreements

    • inclination is to create own version

  • TODO: 

    • check with Steve

      • is ehcache being used elsewhere?

      • can we sue our own thread factory

    • try ehcache 3

  • Decision on way forward by Wed 24 Jan

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3125

Not vulnerable

  • Triage

    • need to revisit what choice we made for Poppy

    • need to check whether Orchid/Poppy have the same vulnerability to determine backport requirement

    • otherwise to be dealt with (for Quesnalia) by Grails 6 upgrade

  • Approach

    • Prefer not to patch grails, but should be able to bump data-binding 

    • Try 4.1.3, then 4.1.2, then 4.1.1

    • Otherwise will need to change databindings specifically - which will be messy

    • Owen: release plan

  • Components and Changes

    • Frontend: NA

    • Backend: mod-agreements, mod-licenses, mod-service-interaction

      • shouldn't need grails-okapi or KIWT

  • Tests / Data / Dependencies

  • Known Unknowns

    • what's the minimum version that has the fix?

    • confirm that  grails-okapi and KIWT do not need bumping

  • QA: snapshot | local | testing | other

    • dev: does it compile and run as expected?

    • regression testing

  • Release Target: NA

  • Development Estimate: NA

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3130

 

  • Triage

    • fetch of loadMore is causing cache of what's opened to refresh

      • fetch is at rootLevel, so redraw pushes a different set of lines

    • which may be because of batch fetching PO lines 

    • redraw closes and remounts 

  • Approach

    • needs investigation to understand chain of events leading to invalidation or refresh

      • what's the trigger?

      • is there a quick fix? 

      • if not will need a refactor of PO line fetch handling

    • Owen to revisit whether this is an issue in current versions

  • Components and Changes

    • Frontend: ui-agreements

    • Backend: NA

  • Tests / Data / Dependencies: 

    • none for now, potentially add to testrails catalog

  • Known Unknowns

    • then need to decide what's desirable behaviour - do we need to retain the user's view or reset it post-redraw?

      • if we don't then any data changes won't be reflected

      • if we do, we need to develop a reusable component for consistency across apps

  • QA: snapshot 

  • Release Target: Quesnelia (no backport)

  • Development Estimate

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3131

@Owen Stephens 

Not clear how to verify

  • Triage

  • Approach

  • Components and Changes

    • Frontend

    • Backend

  • Tests / Data / Dependencies

  • Known Unknowns

  • QA: snapshot | local | testing | other

  • Release Target: 

  • Development Estimate

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3118

@Ethan Freestone 

 

 

https://folio-org.atlassian.net/browse/ERM-2631

 @Ethan Freestone 

  • Approach

    • set up new open source project in K-Int gitlab

    • new micronaut service required (not using okapi or grails)

    • set up a test instance