https://folio-org.atlassian.net/browse/ERM-1910

Testrails

Sprint 180

https://folio-org.atlassian.net/browse/ERM-3063

QA

Sprint 176

https://folio-org.atlassian.net/browse/ERM-2792

@Monireh Rasouli

OPEN

Sprint 178

https://folio-org.atlassian.net/browse/ERM-2793

@Monireh Rasouli

In Progress

Sprint 178

https://folio-org.atlassian.net/browse/ERM-3090

Steve Osguthorpe

Code Review

Sprint 180

https://folio-org.atlassian.net/browse/ERM-3111

Ready TO PROGESS 

• Triage

  • previously created new Grails 6 project and incrementally added components

  • once pitfalls identified, each module took very little time

• Approach

  • will starting up a new grails project with the CLI even work?

• Components and Changes

  • Frontend

  • Backend

• Tests / Data / Dependencies

  • gradle upgrade is necessary

• Known Unknowns

  • will starting up a new grails project with the CLI even work?

• QA: snapshot | local | testing | other

• Release Target: 

• Development Estimate

• Current:

  • grails and gradle versions determined

  • web-toolkit passing tests

  • smoother process than 4 to 5, but integration is inevitably 

• TODO

  • service-interaction failing

  • need to build into okapi environment

    • may need to rebuild rancher, which could be risky at the moment

  • review migrations, but difficult to triage atm

Feb 19, 2024 

• Release candidate for Grails 6 and okapi ready

• Should be ready to move forward

• Once merged, cannot backport to Poppy

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3078

In Progress

• enforceVersionCheck is taken from grails default rest controller - not sure of impact to changing from false to true

• can add to to yaml without changing default to false

• would need to make changes to KIWT restful controller

• need to push version numbers

• likely not to be rolled in until Grails 6

• TODO: 

  • Jack to write up findings 

  • Owen to review with users

Sprint 178

https://folio-org.atlassian.net/browse/ERM-3089

Sprint 178

https://folio-org.atlassian.net/browse/SI-34

@Ethan Freestone 

Sprint 173

https://folio-org.atlassian.net/browse/SI-38

@Ethan Freestone 

Sprint 179

https://folio-org.atlassian.net/browse/ERM-3133

@Claudia Malzer 

• Triage

  • FOLIO session-level

• Approach

  • review implementation across other apps

    • eg, Orders, 

    • eg, stripes-smart-components useColumnManager 

  • can this be used as-is within ERM or does it need streamlining?

• Components and Changes

  • Frontend: TBC

  • Backend: none

• Tests / Data / Dependencies: ??

• Known Unknowns: ??

• QA: snapshot | local | testing | other

• Release Target: Quesnelia

• Development Estimate: ??

https://folio-org.atlassian.net/browse/ERM-3118

@Jack Golding  

Triage

Current: 

• upgrade path documentation doesn't help

• looks like (via grep) this is the only use of ehcache

Sprint 182

• need to decide whether to bail ehcache to use another NamedFactory provider

• potentially could do this internally, without another dependency

• run gradle clean  and check dependencies to see if ehcache/jetty-io are brought in transitively - CONFIRMED on v2

Sprint 183

• Current

  • NamedThreadFactory doesn't seem critical or fancy

  • and it looks like it's only in mod-agreements

  • inclination is to create own version

• TODO: 

  • check with Steve

    • is ehcache being used elsewhere?

    • can we sue our own thread factory

  • try ehcache 3

• Decision on way forward by Wed 24 Jan

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3125

Not vulnerable

• Triage

  • need to revisit what choice we made for Poppy

  • need to check whether Orchid/Poppy have the same vulnerability to determine backport requirement

  • otherwise to be dealt with (for Quesnalia) by Grails 6 upgrade

• Approach

  • Prefer not to patch grails, but should be able to bump data-binding 

  • Try 4.1.3, then 4.1.2, then 4.1.1

  • Otherwise will need to change databindings specifically - which will be messy

  • Owen: release plan

• Components and Changes

  • Frontend: NA

  • Backend: mod-agreements, mod-licenses, mod-service-interaction

    • shouldn't need grails-okapi or KIWT

• Tests / Data / Dependencies

• Known Unknowns

  • what's the minimum version that has the fix?

  • confirm that  grails-okapi and KIWT do not need bumping

• QA: snapshot | local | testing | other

  • dev: does it compile and run as expected?

  • regression testing

• Release Target: NA

• Development Estimate: NA

Sprint 182

ERM-3130: Agreement line linked to PO line causes redraw of agreement pane when a page of lines loadedClosedPreview

• Triage

  • fetch of loadMore is causing cache of what's opened to refresh

    • fetch is at rootLevel, so redraw pushes a different set of lines

  • which may be because of batch fetching PO lines 

  • redraw closes and remounts 

• Approach

  • needs investigation to understand chain of events leading to invalidation or refresh

    • what's the trigger?

    • is there a quick fix? 

    • if not will need a refactor of PO line fetch handling

  • Owen to revisit whether this is an issue in current versions

• Components and Changes

  • Frontend: ui-agreements

  • Backend: NA

• Tests / Data / Dependencies: 

  • none for now, potentially add to testrails catalog

• Known Unknowns

  • then need to decide what's desirable behaviour - do we need to retain the user's view or reset it post-redraw?

    • if we don't then any data changes won't be reflected

    • if we do, we need to develop a reusable component for consistency across apps

• QA: snapshot 

• Release Target: Quesnelia (no backport)

• Development Estimate

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3131

@Owen Stephens 

Feb 21, 2024  

• Not clear how to verify

• Need to follow up with Molly

Sprint 182

https://folio-org.atlassian.net/browse/ERM-3118

@Ethan Freestone 

https://folio-org.atlassian.net/browse/ERM-2631

 @Ethan Freestone 

• Approach

  • set up new open source project in K-Int gitlab

  • new micronaut service required (not using okapi or grails)

  • set up a test instance

  • will need a different dev workflow (probably using local copy of service)

  • working title: pushkb

  • avoid storing caches of transient data

• Components and Changes

  • Frontend: na

  • Backend: new

• Tests / Data / Dependencies

  • Align to when GBV start testing and using pushkb endpoint

  • ERM-3048 Possible package schema changes  with endpoint changes

• Known Unknowns

  • should be (but not clear yet) about TitleInstance Resolver

  • packageSchemaUpdater: potential conflicts when there are multiple copies of schemas in play where backwards compatibility is broken

• QA: snapshot | local | testing | other

• Release Target:  Quesnalia

• Development Estimate

• Current State

  • pushKb can make a scheduled call (1s, 1h) to Gokb

  • will fetch roughly ~700k TIPPS 

  • Stores these in a local postgres db

  • proteus json transform implemented with proof of concept schema

• TODO

  • scaling

  • extensive transformation testing

  • write fetch chunks and push to FOLIO,

    • implementing algorithm to ensure no data gaps 

    • deciding what to do with the data volume (700k feels beyond FOLIO's performance capability)

    • at a minimum: need to move the FOLIO side to being not an open http request per chunk (would be killed by  okapi), by, eg, 

      • small batch sizes? would take full day for initial ingest

      • speeding up FOLIO? (not clear how this could be done)

      • move pushKb to background thread (like jobs, but on a much smaller scale)? 

• Constraints

  • want to avoid jobs being badly interrupted by a docker container being restarted

  • tradeoff is that we have a slower but more stable process 

• Development Estimate