Apr 27, 2022 

9:05am ET, 2:05pm UK, 3:05pm Germany

Video Call in

• FOLIO Slack: #erm-developers

• Backup (Meet): https://meet.google.com/oei-okoc-eys

2022-04-13 ERM Weekly Delivery Update

JIRA Issue Board

<5 mins

Introductions

• Attendees / Apologies

• Upcoming Availability - to end of Sprint 141

Call Priorities

• https://folio-org.atlassian.net/browse/ERM-1986 / https://folio-org.atlassian.net/browse/ERM-1989

WIP 

• What progress or impediment on previously stated actions?

• What's left to do?

• Any new unknowns?

• What help or input is needed?

• When expected to be ready for review?

• https://folio-org.atlassian.net/browse/ERM-2045

  • Progress / Impediments: 

    • none

  • TODO: 

    • update contentType to refdata

      • Add object with link to parent and hang refdata off that

      • Needs separate class with hasMany

    • from PR feedback - exclude owner on ermResource 

    • update migrations for contentType

      • avoid adding and removing in the same commit

  • New unknowns: NA

  • Help or input needed: NA

  • ETA for review: Mon

• https://folio-org.atlassian.net/browse/ERM-2059

  • Progress / Impediments: 

  • TODO: 

    • Changes to package schema, to make it acceptable from any source (not just Gokb)

    • Changes to ingest

  • New unknowns: NA

    • contentType query on ERM-2045

  • Help or input needed: 

    • Recent example of schema update: https://github.com/folio-org/mod-agreements/pull/547

  • ETA for review: Wed

• https://folio-org.atlassian.net/browse/ERM-1986 / https://folio-org.atlassian.net/browse/ERM-1989

  • Progress / Impediments: 

    • Reviewed progress with Gill

    • Some changes requested around modal functionality and styling, requiring refactor

    • Peer reviewed with Ethan

  • TODO: 

    • implement form submit handler

    • remove duplication of 'journal' (pub type) in source

    • add pending notice to Move identifiers screen if user wants to move more identifiers

    • tests and linting

  • New unknowns: 

    • How to handle going back to move more identifiers (as update is asynchronous) and removing pending identifiers

      • potentially check the jobs, though that would involving parsing json files

  • Help or input needed: 

  • ETA for review: Fri

•  https://folio-org.atlassian.net/browse/ERM-2060

  • Progress / Impediments: 

  • TODO: 

    • tests

  • New unknowns: NA

  • Help or input needed: 

    • Testing lists of key-value pairs

      • just test for presence of the strings in the DOM

    • Testing Dates

      • Behaviour of line break seems to be inserted when using FormattedDateTime

      • Tried: insert &nbsp; instead of " "

      • Try separately processing FormattedDate and FormattedTime, manually inserting space

      • Check on #stripes-testing

  • ETA for review: 

•   https://folio-org.atlassian.net/browse/ERM-2066

  • Context

    • tiny stripes-connect symptom

    • want to migrate tags to react query to resolve this

    • end up with cascading effect ... need to change viewRoute as well

  • Progress:

    • agreements and platform routes use react query now as functional components: tags working well with some marginal performance gains

    • pattern exists to reuse in other components

    • not done some as they are very convoluted logic (eg, orderlines chunking) or don't use tags (eg, ui-local-kb-admin)

    • create and edit routes are not using tags, so are not touched yet

    • current state is a hybrid of stripes-connect and react

  • TODO:

    • licenses 2-3 days + comprehensive QA (esp cross-route interactions)

    • add stub Jira issue for other components/routes that need to be refactored / migrated

    • TO PARK: refactor fully away from stripes-connect is much bigger

Pending

• Are the blocking conditions still relevant? 

• What action is needed to unblock, and by whom?

• Who needs to be involved in the elaboration process? 

• What is the timeframe for getting input?

• When is the issue expected to be ready for development?

• Who is picking up what next?

• When is next issue expected to start / complete?

• Anything needed to start next issue (dependencies or clarifications)?

NA

• ISSUE

  • Blocking conditions

  • Action needed

NA

• https://folio-org.atlassian.net/browse/ERM-2046 

  • Who / When: Owen

    • Move ERM-286 to task defining UXPROD-3591

    • Preserve ERM-2046 for ERM-287, ERM-288 and ERM-289

    • Split other subtasks into separate stories for different related subtasks

  • ETA Ready for Dev: 

• Claudia:  babel-eslint dependency change and regression testing

• Ethan: ERM-2085

• Monireh: https://folio-org.atlassian.net/browse/ERM-2081

• Peter:  NA

At Risk

• What is now at risk of not being started this sprint?

• Do any of these take priority over other sprint backlog items?

• RTL

Sprint Backlog -  At Risk

• https://folio-org.atlassian.net/browse/ERM-2081

In Review

• Any impediments to review or QA?

• Any useful context, implementation choices or limitations for the reviewer/tester to know ?

• https://folio-org.atlassian.net/browse/ERM-2060

• https://folio-org.atlassian.net/browse/ERM-2076

• https://folio-org.atlassian.net/browse/ERM-1313

• https://folio-org.atlassian.net/browse/ERM-1322

• https://folio-org.atlassian.net/browse/ERM-778

• https://folio-org.atlassian.net/browse/ERM-2044

• https://folio-org.atlassian.net/browse/ERM-2048

• https://folio-org.atlassian.net/browse/ERM-1850

• https://folio-org.atlassian.net/browse/ERM-2073

• https://folio-org.atlassian.net/browse/ERM-2079

• https://folio-org.atlassian.net/browse/ERM-2078

• https://folio-org.atlassian.net/browse/ERM-2068

• https://folio-org.atlassian.net/browse/ERM-2086

• NA

Release Candidates

• What has passed QA since last dev call?

• What has been closed since last dev call?

For Lotus Bugfix: release complete but held For Release for testrails. 

• https://folio-org.atlassian.net/browse/ERM-1979

• https://folio-org.atlassian.net/browse/ERM-2043

• https://folio-org.atlassian.net/browse/ERM-2069

• https://folio-org.atlassian.net/browse/ERM-2070

• https://folio-org.atlassian.net/browse/ERM-2071

<10 mins

AOB

• @Claudia Malzer  topick up babel-eslint issues (based on STRIPES-742):

  type	key	summary	assignee	reporter	priority	status	resolution	created	updated	due

  Loading...

  Refresh

• ERM-2085 to be added to next sprint, and partialluy dealt with as part of ERM-2066

• Reschedule: Sprint Planning (sprint 139) is Tue 3 not Mon 2 May (UK public holiday)  

• To watch: eresources search and filter load time (review any feedback in Morning Glory bug fest)