2021-09-29 ERM Weekly Delivery Update

Owned by Jag Goraya
Last updated: Sep 29, 2021
2 min read

Meeting Details

Date

 

Time

9:15am ET, 2:15pm UK, 3:15pm Germany

Location

Video Call in

Previously2021-09-22 ERM Weekly Delivery Update
ReferencesJIRA Issue Board

Goals

Participants

Apologies

Discussion items

Time

Item

Notes

<5 minsIntroductions

Previous Actions

NA


In Review

  • Any impediments to review or QA?
  • Any useful context, implementation choices or limitations for the reviewer/tester to know ?


Code Review: 

  • ERM-1798 - Getting issue details... STATUS
    • integration tests reviewed:
      • does not gel with existing tests
      • will need new values and possible tests
    • refactor on tests should not block QA 
    • some testing has been done to check against the ingest process
    • transferred to Owen for QA
    • new subtask raised to track integration test tweaks: ERM-1880 - Getting issue details... STATUS
  • ERM-1259 - Getting issue details... STATUS
    • some scenarios missing and not identified
    • to follow up with Adi post-call
  • ERM-1853 - Getting issue details... STATUS / ERM-1854 - Getting issue details... STATUS

QA / UAT 

  • No issues expected
  • ERM-1628 - Getting issue details... STATUS
    • need to review for potential testing issues
    • empty accordians aren't shown anymore so circumstances for issue arising are rarely triggered

Bugfix Cycle 

  • NA



WIP 

  • What progress or impediment on previously stated actions?
  • What's left to do?
  • What help or input is needed?
  • When expected to be ready for review?

In Progress

  • ERM-1700 - Getting issue details... STATUS
    • locally,
      • internal contacts are not linked
      • need to select agreement twice to enable linkable admin contact
      • users are not added in local build of platform-erm
    • not the same on snapshot -
      • shouldn't need to worry about it
      • may be separate bug: 
        • Owen to review 
        • would be a good place to use react query
        • if so, then should come up with a pattern first
  • ERM-1661 - Getting issue details... STATUS
    • just started
    • agreements.js, eresources and platforms will take a significant time - completely
      • use sas from smart-components
      • potentially 4 days
    • other tests should be 4-5 days
  • ERM-1258 - Getting issue details... STATUS
    • not seeing the reason tests are 
  • ERM-1813 - Getting issue details... STATUS
    • Adding 'relatedTitles' to the expansion list doesn't make any difference.
    • Some formatting to the issue description to highlight the differences between the scenarios.
    • To try alternative approach: 
      • ti not pti
      • ti.work.titles that aren't current
      • titles shouldn't be fully rendered
  • ERM-1771 - Getting issue details... STATUS / ERM-1770 - Getting issue details... STATUS
    • front-end issue (stripes-erm-components)
    • two approaches considered
    • choice is when custom properties are created, ignore everything unless value is entered
      • rather than validate dirty fields
    • will add a delete prop as default for primary properties

Pending

Sprint Backlog

  • Who is picking up what next?
  • When is next issue expected to start / complete?
  • Anything needed to start next issue (dependencies or clarifications)?

Needs Elaboration

  • Who needs to be involved in the elaboration process? 
  • What is the timeframe for getting input?
  • When is the issue expected to be ready for development?

Blocked

  • Are the blocking conditions still relevant? 
  • What action is needed to unblock, and by whom?

Sprint Backlog - Next Up

  • Claudia:
    • potentially ERM-1566 - Getting issue details... STATUS
    • recent example in ERM-1859
    • may need to add similar more in other issues
      • Gill to review and liaise with Owen to raise relevant issues
  • Peter:  ERM-1850 - Getting issue details... STATUS
  • Ethan: 
    • Release Tasks
    • ERM-1880 - Getting issue details... STATUS Integration tests for ERM-1798
    • ERM-1799
  • Adi: 
    • RTL tasks not requiring SaS/smart-components
    • Frontend Release Tasks
    • RTL tasks using SaS/smart-components
  • Monireh: RTL tests

Sprint Backlog - to follow

  • NA

Needs Elaboration

Blocked

  • NA

At Risk

  • What is now at risk of not being started this sprint?
  • Do any of these take priority over other sprint backlog items?

Sprint Backlog 

  • ERM-1287 - Getting issue details... STATUS
    • at risk this sprint because of extra time needed for new sas related RTL tests for ERM-1661 
  • ERM-1733 - Getting issue details... STATUS

Release Candidates

  • What has passed QA since last dev call?
  • What has been closed since last dev call?

Accepted 

  • ERM-1844 - Getting issue details... STATUS
    • should be good to close 
    • no testrail cases to be raised

Closed

<10 mins

AOB


New Issues

Added to sprint

Not added to sprint

  • NA

Other

  • FinalForm CI errors were causing some issues for PRs
  • These should be fixed now - any failed PRs can be re-triggered