Nov 18, 2020    

10:30am ET, 3:30pm UK, 4:30pm Germany

Video Call in FOLIO Slack: #erm-developers

2020-11-11 ERM Weekly Delivery Update

JIRA Issue Board

<5 mins

Introductions

• Attendees / Apologies

• Upcoming Availability

WIP Update 

Release Candidates

Code Review: 

• ERM-1048: Implement "template" mechanism to create URLs for resources based on existing dataClosedPreview

  • awaiting bulk test development

  • example packages are being used, but taking a long time (30min) to load in environment

    • may be because of an upgraded PostGRES in test environment

  • code so far has been reviewed 

    • approach and performance has passed

  • returned to Ethan for test development

QA / UAT 

No impediments

• ERM-1184: Add "Edit" screen for title instance resourcesClosedPreview

• ERM-1223: Agreement lines from previous agreement show when switching to view another agreementClosedPreview

• ERM-1224: Removing content of "Local platform code" and saving should result in empty platform codeClosedPreview

• ERM-1238: /erm/entitlements endpoint doesn't expand owner when entitlement is externalClosedPreview

  • does this need to be hotfixed for Honeysuckle, which affects eHoldings users 

  • Thunderjet also making some changes in mod-orders  that may affect it

    • looking to fetch the full agreement, which increases performance load

  • Soliciting eHoldings PO input to determine whether to patch

Items at Risk / Spillover

In Progress

• ERM-1190: Add UI settings to control the number of items displayed in Agreements MCLsClosedPreview

  • Tricky - stuck at Postman 

  • Not sure how to handle this

  • Current approach puts all settings into a JSON blob, but not clear how to change a particular value

  • Cannot change individual values, so line by line approach is problematic

    • Going to try with a different config name (to result in a different id), though potentially then need another control manager

    • pagination should be preserved though

  • Still need to address the edit multiple values

    • controlled vocab is probably needed

  • Potentially change a cached version of the controlled vocab and then push an update on whole form save

  • Can be separated into separate tables for load and pagination

    • However, the issue is per-line editing

  • DECISION:

    • drop the per-line editing,

    • use a single form with the multiple values

    • use the existing settings save button

    • add Display setting unless there's a second save button needed

      • In which case, add a MCL Pagination settings page

    • Gill to add revised mockup with updated wording

• ERM-1204: It should not be possible to delete Licenses with attached AgreementsClosedPreview

  • cannot successfully add subpermission  license.agreements.item.get 

    • will need vagrant image to be restarted to effect permission changes

  • any side effects or consequences of adding this as a sub to licenses view?

    • definitely want to keep agreements.item.get separate

    • backend should either

      • EITHER grant itself permission to check (similar to users)

      • OR flag that there are or are not linked agreements

  • PB to check with SO whether a Grails change may be affecting this

• ERM-1109: UI for managing proxy server configurationsClosedPreview

  • no blockers at this point

  • need content for info popovers / context sensitive help

    • Owen to review and advise tomorrow

  • no backend validation provided for customised url

    • so only validation is the required fields validation

    • REQ: blank customised url is not permitted

  • no means currently of preventing an invalid URL syntax

  • Some possibility of silent failures ... need to revisit this

  • potentially could wire something into SaS validation (erm/validate)

  • validate on save may be more performant

• ERM-1108: Add proxied URLs to exportsClosedPreview

  • Done

Sprint Backlog

• ERM-1102: Support for e-resource proxies and url customisersClosedPreview

• ERM-1229: Duplicate AmendmentClosedPreview

• ERM-1137: Agreements: Apply a four column layout to the Agreement preview paneClosedPreview

• ERM-1148: Agreements: Preview: E-resources covered by this agreement: Link to PCI instead of TIClosedPreview

• ERM-1176: Licenses: Amendments: improvement the Amendment preview pane presentationClosedPreview

• ERM-1227: Search and sort pane in agreements does not display at correct widthClosedPreview

• ERM-1228: Add POL/Inventory Instance details to Agreement Line displayClosedPreview

• ERM-1143: Improve display of Coverage in MCLsClosedPreview

• ERM-1237: Incorrect date in ui-plugin-find-licenseClosedPreview

Needs Elaboration

• ERM-1225: On Platform view Action button should not show if user would see no options in Action dropdownClosedPreview

• ERM-1233: Provide user preview for templated URLs outcomesDraftPreview

Closed

• ERM-1219: Agreements > Platforms: "search" keyboard shortcut does not workClosedPreview

• ERM-1221: Agreements: Supplementary documents: Do not hide the Note field when emptyClosedPreview

• ERM-1222: Licenses: Supplementary documents: Do not hide the Note field when emptyClosedPreview

<10 mins

AOB

New Issues

Added to sprint

• ERM-1238: /erm/entitlements endpoint doesn't expand owner when entitlement is externalClosedPreview

• ERM-1237: Incorrect date in ui-plugin-find-licenseClosedPreview

Not added to sprint

• ERM-1236: Incorrect message on PCI screenClosedPreview

Vagrant

Suppress from discovery

• @Owen Stephens to add new story for suppress from discovery on edit screen

  • following from input for Felix

  • may entail changes to how originally implemented