2020-11-18 ERM Weekly Delivery Update

Meeting Details




10:30am ET, 3:30pm UK, 4:30pm Germany

LocationVideo Call in FOLIO Slack: #erm-developers
Previously2020-11-11 ERM Weekly Delivery Update
ReferencesJIRA Issue Board




Discussion items




Action Items

<5 minsIntroductions

WIP Update 

Release Candidates

Code Review: 

  • ERM-1048 - Getting issue details... STATUS
    • awaiting bulk test development
    • example packages are being used, but taking a long time (30min) to load in environment
      • may be because of an upgraded PostGRES in test environment
    • code so far has been reviewed 
      • approach and performance has passed
    • returned to Ethan for test development


No impediments

  • ERM-1184 - Getting issue details... STATUS
  • ERM-1223 - Getting issue details... STATUS
  • ERM-1224 - Getting issue details... STATUS
  • ERM-1238 - Getting issue details... STATUS
    • does this need to be hotfixed for Honeysuckle, which affects eHoldings users 
    • Thunderjet also making some changes in mod-orders  that may affect it
      • looking to fetch the full agreement, which increases performance load
    • Soliciting eHoldings PO input to determine whether to patch

Items at Risk / Spillover

In Progress

  • ERM-1190 - Getting issue details... STATUS
    • Tricky - stuck at Postman 
    • Not sure how to handle this
    • Current approach puts all settings into a JSON blob, but not clear how to change a particular value
    • Cannot change individual values, so line by line approach is problematic
      • Going to try with a different config name (to result in a different id), though potentially then need another control manager
      • pagination should be preserved though
    • Still need to address the edit multiple values
      • controlled vocab is probably needed
    • Potentially change a cached version of the controlled vocab and then push an update on whole form save
    • Can be separated into separate tables for load and pagination
      • However, the issue is per-line editing
      • drop the per-line editing,
      • use a single form with the multiple values
      • use the existing settings save button
      • add Display setting unless there's a second save button needed
        • In which case, add a MCL Pagination settings page
      • Gill to add revised mockup with updated wording
  • ERM-1204 - Getting issue details... STATUS
    • cannot successfully add subpermission  license.agreements.item.get 
      • will need vagrant image to be restarted to effect permission changes
    • any side effects or consequences of adding this as a sub to licenses view?
      • definitely want to keep agreements.item.get separate
      • backend should either
        • EITHER grant itself permission to check (similar to users)
        • OR flag that there are or are not linked agreements
    • PB to check with SO whether a Grails change may be affecting this
  • ERM-1109 - Getting issue details... STATUS
    • no blockers at this point
    • need content for info popovers / context sensitive help
      • Owen to review and advise tomorrow
    • no backend validation provided for customised url
      • so only validation is the required fields validation
      • REQ: blank customised url is not permitted
    • no means currently of preventing an invalid URL syntax
    • Some possibility of silent failures ... need to revisit this
    • potentially could wire something into SaS validation (erm/validate)
    • validate on save may be more performant
  • ERM-1108 - Getting issue details... STATUS
    • Done

Sprint Backlog

Needs Elaboration


<10 minsAOB

New Issues

Added to sprint

Not added to sprint


Suppress from discovery

  • Owen Stephens to add new story for suppress from discovery on edit screen
    • following from input for Felix
    • may entail changes to how originally implemented