Jun 9, 2021    

9:15am ET, 2:15pm UK, 3:15pm Germany

Video Call in

• FOLIO Slack: #erm-developers

• Backup (Meet): https://meet.google.com/oei-okoc-eys

2021-06-02 ERM Weekly Delivery Update

JIRA Issue Board

<5 mins

Introductions

• Attendees / Apologies

• Upcoming Availability

Previous Actions

NA

WIP Update 

Release Candidates

Code Review: 

• https://folio-org.atlassian.net/browse/ERM-1607 / https://folio-org.atlassian.net/browse/ERM-1608 / https://folio-org.atlassian.net/browse/ERM-1609

  • 1608: test procedure works locally, previous change request not replicated

QA / UAT 

• https://folio-org.atlassian.net/browse/ERM-1653

  • Can't be tested because licenses not working on folio-snapshot

  • grails upgrade reverted from 4.0.10 back to 4.0.4 which should resolve

  • Owen to ask for rebuild

Accepted

More testrail cases to come for

• https://folio-org.atlassian.net/browse/ERM-1651 / https://folio-org.atlassian.net/browse/ERM-1652

• https://folio-org.atlassian.net/browse/ERM-1617

• https://folio-org.atlassian.net/browse/ERM-1655

Items at Risk / Spillover

In Progress

• https://folio-org.atlassian.net/browse/ERM-1696

• https://folio-org.atlassian.net/browse/ERM-1540 / https://folio-org.atlassian.net/browse/ERM-1542

  • setPrimaryOrg on change not worked

    • workaround with separate component does work

    • draft PR to be raised for Ethan to review

  • default role value addressed by checking / treating first render row differently

    • renderRoles function in renderRoles array

    • critical for validation

  • validation checks

    • role 

      • stated preferred approach would be significantly more costly (development time and code performance)

      • expedient: validator that uses all values, checking role array, non-destructively

    • organisation:

      • need to 'validate' through the field that identifies the card for organization, something like orgs.UUID 

      • though technically not a form validation. should handle as per self-linking agreements (useEffect)

      • not sure how to refer to values to compare: can be had from useFormState. 

• https://folio-org.atlassian.net/browse/ERM-1541 / https://folio-org.atlassian.net/browse/ERM-1543

  • done, pending related issues

• https://folio-org.atlassian.net/browse/ERM-1600

  • couldn't progress because of licenses issues on snapshot

  • can call ui-plugin-find-agreement from either

    • erm-comparisons search and sort

    • dashboard: simple search widget filter

    • agreements: related agreements 

• https://folio-org.atlassian.net/browse/ERM-1603

  • can swap parameter this.actionName as null

  • and ifPermission with hasPerm

  • rather: take extensible pattern from viewAgreement.js

Sprint Backlog

• https://folio-org.atlassian.net/browse/ERM-1724

• https://folio-org.atlassian.net/browse/ERM-1725

• https://folio-org.atlassian.net/browse/ERM-1601

Needs Elaboration

• https://folio-org.atlassian.net/browse/ERM-1656

• https://folio-org.atlassian.net/browse/ERM-1728

Bugfix Cycle

• NA

Closed

• https://folio-org.atlassian.net/browse/ERM-1682 / https://folio-org.atlassian.net/browse/ERM-1683 / https://folio-org.atlassian.net/browse/ERM-1684 / https://folio-org.atlassian.net/browse/ERM-1685

• https://folio-org.atlassian.net/browse/ERM-1657

• https://folio-org.atlassian.net/browse/ERM-1658

<10 mins

AOB

mod-serv-int has been added to folio-testing vagrant image

• this needs to be removed

• Ethan and Ian investigating

New Issues

Added to sprint

• NA

Not added to sprint

• NA