PCI accessStart and accessEnd dates should be ignored when PCI added as individual resource to agreement

Description

Overview:
Steps to Reproduce:

  1. Load package in attached JSON file

  1. Find the journal "Afghanistan" and add the PCI to an agreement. Note that this has an accessEnd date of 2021-06-30

  2. View E-resources covered by this agreement and note that Afghanistan is in the "Dropped" list not the "Current" list

Expected Results:

  • Title should appear in the Current list as it has been added to the agreement as an individual PCI, not just via the package

Additional Information:

If you export the resources in the agreement (using the "Export as..." button next to the "E-resources covered by this agreement") then Afghanistan is correctly included in the export

If you were to add the package ("access_start_access_end_tests Package") to an agreement by itself, then Afghanistan should show only in the "Dropped" list and should not be included in the export

If you were to add both package and the individual PCI to an agreement, then Afghanistan should show as a current title because the presence of the PCI, even though it has been dropped from the package

Agreement line Active from/Active to dates should be observed in all cases

Interested parties:

 ,

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

4

Checklist

hide

TestRail: Results

Activity

Show:

Owen Stephens October 4, 2021 at 3:07 PM
Edited

Issue picked up in QA is not caused by this - separate bug to be filed.
Filed as https://folio-org.atlassian.net/browse/ERM-1904

Owen Stephens October 4, 2021 at 11:03 AM

QA 2021-10-04:

On adding package to agreement I'm seeing the title Afghanisan appear in the "Dropped" list multiple times - it seems to increase each time I add the package to an agreement

Peter Böhm September 17, 2021 at 2:20 PM

Update before vacation: Integration test is not ready yet; primary code change for bugfix itself is available in Branch (cc )

Jag Goraya September 15, 2021 at 8:47 PM

Note discussion of breaking change implication: https://folio-project.slack.com/archives/CAYCU07SN/p1631714576054500

Owen Stephens September 15, 2021 at 1:13 PM

 essentially the Access Start/Access End dates should be ignored for things added as individual PCIs - these are the dates that they were added to/removed from a Package, and as the user has directly added the title, not the package, to the agreement, we assume that these dates are not relevant in this case.

They COULD still be in the Future/Dropped lists based on the Agreement Line Active From/Active To dates.

Done

Details

Assignee

Reporter

Components

Labels

Priority

Sprint

Development Team

Bienenvolk

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created June 28, 2021 at 11:17 AM
Updated November 2, 2021 at 8:42 AM
Resolved October 4, 2021 at 3:07 PM
TestRail: Cases
TestRail: Runs