/
2021-06-30 ERM Weekly Delivery Update

2021-06-30 ERM Weekly Delivery Update

Meeting Details

Date

    

Time

9:15am ET, 2:15pm UK, 3:15pm Germany

Location

Video Call in

Previously2021-06-23 ERM Weekly Delivery Update
ReferencesJIRA Issue Board

Goals

Participants

Apologies

  • Ethan Freestone

Discussion items

Time

Item

Notes

Action Items

<5 minsIntroductions



Previous Actions

NA



WIP Update 

Release Candidates

Code Review: 

  • ERM-1686 - Dashboard: Widget edit: Long widget name does not save or show validation message Closed

QA / UAT 

NA


Accepted

Passed QA on call, awaiting testrails

  • ERM-1542 - Make organization roles for agreements editable in tenant settings Closed / ERM-1543 - Make organization roles for licenses editable in tenant settings Closed
  • ERM-1737 - ERM comparisons: display the keyboard shortcuts modal Closed ERM-1734 - Local KB admin: display the keyboard shortcuts modal Closed ERM-1732 - Licenses: display the keyboard shortcuts modal Closed ERM-1642 - Agreements: display the keyboard shortcuts modal Closed
  • ERM-1750 - General License note not displayed in Agreements view Closed  

Items at Risk / Spillover

In Progress

  • ERM-1600 - Bring search options in ui-plugin-find-agreement in line with ui-agreements search and filter Closed / ERM-1601 - Bring search options in ui-plugin-find-license in line with ui-licenses search and filter Closed
    • Both PRs failing CI checks
    • More failures previously, now reducing by interrogating network response in console, so getting there 
    • Expected to code review this week
  • ERM-1731 - New licenses should have a default value for end date semantics Closed
    • Previously
      • started writing the cleanup function
      • check license core to see whether beforeValidate or another hook is used
      • expected to complete for code review on Friday
    • delayed by local environment issues
    • need to test cleanup with new vagrant issue
  • ERM-1656 - Implement widget error message banner Closed
    • TODO
      • error banding to pull from stripes-components
      • try/catch sequence
    • expected for code review Thu pm
  • ERM-1753 - Migration to new Org / Org role structure leads to duplicate notes Closed
    • fixed the migration file
    • think it should be in same change part as an existing migration
    • question about whether adding something to an existing migration, will it work if the migration is run again
    • expecting to go to code review close of Wed
  • ERM-1735 - Dashboard: add FOLIO keyboard shortcuts Closed ERM-1736 - Dashboard: display the keyboard shortcuts modal Closed
    • Edit shortcut widget
      • some ambiguities around widget context when edit widget  shortcut is used.
      • where in the code should the shortcuts go? different structure to licenses and agreements
    • other shortcuts are working
      • separate these out and push for review
    • TODO
      • make changes in index file
      • experiment with edit

Sprint Backlog

  • ERM-1743 - Add Dashboard to ERM Platform Closed

Needs Elaboration

  • NA

Bugfix Cycle

  • NA

Blocked

  • ERM-1704 - Dashboard: columns are being reset to default when repositioned using drag and drop Closed ERM-1748 - Investigate anomalous DragAndDropFIeldArray and react-beautiful-dnd behaviour Closed
  • ERM-1540 - Support for multiple roles per organisation in Agreements Closed / ERM-1541 - Support for multiple roles per organisation in Licenses Closed
    • Blocked by ERM-1753 - Migration to new Org / Org role structure leads to duplicate notes Closed

Closed

  • ERM-1693 - Sort on License Type should sort by label Closed
  • ERM-1739 - Remove duplicate stanzas from application.yml Closed
  • ERM-1741 - Licenses: Error when trying to save a license without a value Closed
  • ERM-1706 - Attempt to GET "undefined" on creating a widget Closed
  • ERM-1749 - On updating an existing organisation role the role value is updated but not the role label Closed


<10 minsAOB

New Issues

Added to sprint

  • ERM-1750 - General License note not displayed in Agreements view Closed
  • ERM-1755 - If a KBART file fails to load, the job outcome should be "failure" Closed  
    • for Peter to pick up next
  • ERM-1756 - Dashboard: add edit widget FOLIO keyboard shortcut Closed
    • separated from ERM-1735

Not added to sprint

  • NA