Nov 3, 2021 

9:15am ET, 2:15pm UK, 3:15pm Germany

Video Call in

• FOLIO Slack: #erm-developers

• Backup (Meet): https://meet.google.com/oei-okoc-eys

2021-10-27 ERM Weekly Delivery Update

JIRA Issue Board

<5 mins

Introductions

• Attendees / Apologies

• Upcoming Availability

Call Priorities

• https://folio-org.atlassian.net/browse/ERM-1899

• https://folio-org.atlassian.net/browse/ERM-1687

• https://folio-org.atlassian.net/browse/ERM-1915

• https://folio-org.atlassian.net/browse/ERM-1850

• https://folio-org.atlassian.net/browse/ERM-1902

• RTL / https://folio-org.atlassian.net/browse/ERM-1661

  • 1664 AgreementLine

  • 1681 URLCustomizer

WIP 

• What progress or impediment on previously stated actions?

• What's left to do?

• Any new unknowns?

• What help or input is needed?

• When expected to be ready for review?

In Progress

• https://folio-org.atlassian.net/browse/ERM-1850

  • TODO:

    • needs to be a criteria check

    • check hibernate docs for subquery or subcriteria implementation details

    • to test

      • manually test: find a title through clean ingest without options and search for that (before and after new code)

      • integration test: out of scope because of reliance on ingest 

    • expect for code review Thursday

• https://folio-org.atlassian.net/browse/ERM-1902

  • Unknown: how to test in a multi-tenancy environment

  • Best approach will be monitor for breaks

  • Issue is basically done, including applying to 1883/1900

  • TODO:

    • review against current integration tests 

    • no event-related integration tests to be done (will take an additional day

• https://folio-org.atlassian.net/browse/ERM-1488

• https://folio-org.atlassian.net/browse/ERM-1492

  • PR depends on changes made yesterday to stripes-erm-components

  • will wait for those to avoid jenkins fail

• https://folio-org.atlassian.net/browse/ERM-1662 / https://folio-org.atlassian.net/browse/ERM-1664

Pending

Blocked

• Are the blocking conditions still relevant? 

• What action is needed to unblock, and by whom?

Needs Elaboration

• Who needs to be involved in the elaboration process? 

• What is the timeframe for getting input?

• When is the issue expected to be ready for development?

Sprint Backlog

• Who is picking up what next?

• When is next issue expected to start / complete?

• Anything needed to start next issue (dependencies or clarifications)?

Blocked

• https://folio-org.atlassian.net/browse/ERM-1687

  • Updated following UX/Dev discussion

  • Current work done by Claudia is necessary but not sufficient

  • TODO: 

    • QA on ERM-1899 (PO)

    • Gill and Ethan to confer on which option to progress, as defined in comments (2021-10-25)

Needs Elaboration

• NA

Sprint Backlog - Next Up

• Claudia: 

  • RTL

• Peter:  

  • https://folio-org.atlassian.net/browse/ERM-1906

  • https://folio-org.atlassian.net/browse/ERM-1907

• Ethan:

  • https://folio-org.atlassian.net/browse/ERM-1900

  • https://folio-org.atlassian.net/browse/ERM-1883

• Adi:

  • https://folio-org.atlassian.net/browse/ERM-1915

    • to prioritise ahead of current RTL issues

    • is this possible to do at the backend?

      • doesn't look like it should be handled in the front-end

      • polling between backend modules (with a single fetch via okapi) is slow and increases fetch times rather than multiple frontend fetches (which is current expectation)

      • switching between front and back end logic is not good for a hotfix

    • best way may be to make a copy, but we're not there yet with backend storage and sync

    • strategy:

      • fix in frontend for now (live sites affected)

      • address backend storage and sync

      • apply to this and contacts

    • Frontend unknowns

      • frontend character limit is 4096, but large number of POlines would be more than this character count: therefore need multiple requests chunked across order lines :: what is the chunk break? Break at 80

      • Sending requests in series would work, but a small number (eg, 5) in parallel could work.  

      • Owen to add sample set to bugfest environment once 5.0.4 change is built

    • Components: 

      • multiple routes

    • Estimate: longer to verify ... 2d max

  • https://folio-org.atlassian.net/browse/ERM-1913

• Monireh: 

  • RTL

At Risk

• What is now at risk of not being started this sprint?

• Do any of these take priority over other sprint backlog items?

Sprint Backlog - to follow

• NA

Sprint Backlog -  At Risk

• https://folio-org.atlassian.net/browse/ERM-1904

• https://folio-org.atlassian.net/browse/ERM-1661

In Review

• Any impediments to review or QA?

• Any useful context, implementation choices or limitations for the reviewer/tester to know ?

Code Review: 

• https://folio-org.atlassian.net/browse/ERM-1467 / https://folio-org.atlassian.net/browse/ERM-1468 / https://folio-org.atlassian.net/browse/ERM-1472

• https://folio-org.atlassian.net/browse/ERM-1257 / https://folio-org.atlassian.net/browse/ERM-1269

• https://folio-org.atlassian.net/browse/ERM-1490

• https://folio-org.atlassian.net/browse/ERM-1491

QA / UAT 

• https://folio-org.atlassian.net/browse/ERM-1899

  • Tested behaviour:

    • save should be stopped, but this doesn't seem to happen

    • validation error is shown, but save is not prevented

    • if name is empty, validation prevents save

  • Correct behaviour is working locally, but not on snapshot

    • validate should be on field not form

  • Returned to Adi to raise PR with correct changes

• https://folio-org.atlassian.net/browse/ERM-1882

• https://folio-org.atlassian.net/browse/ERM-1884

Bugfix Cycle 

• https://folio-org.atlassian.net/browse/ERM-1914

Release Candidates

• What has passed QA since last dev call?

• What has been closed since last dev call?

Accepted

Need testrails cases

• https://folio-org.atlassian.net/browse/ERM-1688

• https://folio-org.atlassian.net/browse/ERM-1791

• https://folio-org.atlassian.net/browse/ERM-1888

• https://folio-org.atlassian.net/browse/ERM-1813

Closed: Lotus R1 2022

Features

• NA

RTL / Other Tests

• https://folio-org.atlassian.net/browse/ERM-1474

• https://folio-org.atlassian.net/browse/ERM-1289

• https://folio-org.atlassian.net/browse/ERM-1282

• https://folio-org.atlassian.net/browse/ERM-1852

• https://folio-org.atlassian.net/browse/ERM-1901

Closed: Kiwi R3 2021 Bug Fix

• https://folio-org.atlassian.net/browse/ERM-1892

• https://folio-org.atlassian.net/browse/ERM-1903

• https://folio-org.atlassian.net/browse/ERM-1916

<10 mins

AOB

New Issues

Added to sprint

• https://folio-org.atlassian.net/browse/ERM-1914

• https://folio-org.atlassian.net/browse/ERM-1915

• https://folio-org.atlassian.net/browse/ERM-1906 / https://folio-org.atlassian.net/browse/ERM-1907

Not added to sprint

• NA

Other

• https://folio-org.atlassian.net/browse/ERM-1913

• https://folio-org.atlassian.net/browse/ERM-1916