2020-09-16 ERM Delivery Weekly Update

Meeting Details


10:30am ET, 3:30pm UK, 4:30pm Germany

LocationVideo Call in FOLIO Slack: #erm-developers



Discussion items




Action Items

<5 minsIntroductions

20Sprint Cutoff

Release Candidates

Code Review: NA

QA / UAT: 

  • ERM-740 - Getting issue details... STATUS  /  ERM-742 - Getting issue details... STATUS
    • Workjing out testing strategy
    • Related to Grails update, so want to double-check
    • Gotcha is float/double to integer truncation, which is expected behaviour - dev comment added to issue

Items at Risk / Spillover

Blocked: NA

In Progress

  • ERM-1118 - Getting issue details... STATUS
    • branch is up with fix, that is tested locally
    • GORM blackbox / hibernate session flush is at root of issue
    • hotfix release patch request raised in #release_bug_triage
      • approved by Mike Gorrell 
      • waiting on Mark / Jakub to second approve
    • wondering whether it needs to go into master and/or goldenrod
    • will be added to ui-agreements master so it can be regression tested
    • relationship handling needs a review - frontend is doing something that should probably be done in the backend
  • ERM-780 - Getting issue details... STATUS
    • returned to dev from code review
    • Adi adding eholdings to default config so that Claudia can get it on local dev environment
    • Will then need master pulling down and testing on snapshot
    • expecting to slip
  • ERM-999 - Getting issue details... STATUS
    • code example expected later today
  • ERM-1114 - Getting issue details... STATUS
    • not going to put this into migrations, but separating out as a service that can be triggered
      • manually (by re-registering tenant) or
      • automatically on upgrade
    • cannot currently run as an async job - attempting to do that to complete cleanup
    • then the issue fix will follow, which expects to be straightforward (precedent exists with licenses)
    • testing is going to require an upgradeable environment
      • not previously done a migration locally
    • expecting to slip because of testing overhead

Sprint Backlog

  • ERM-943 - Getting issue details... STATUS  /  ERM-986 - Getting issue details... STATUS
  • ERM-883 - Getting issue details... STATUS
  • ERM-904 - Getting issue details... STATUS
    • expect to retire at end of sprint if no further issues
  • ERM-1055 - Getting issue details... STATUS
    • roll over to next sprint
  • ERM-1106 - Getting issue details... STATUS
    • Adi to pick up 

Needs Elaboration: 

  • ERM-1102 - Getting issue details... STATUS
    • use cases reviewed by dev
    • way forward is expected to allow users to write their own closures using the same methods that the code will, rather than a rule-based implementation
    • proof of concept / spike repo on gitlab set up by Ian
    • New tasks:
      • spike required to determine
        • whether groovy based closure is feasible
        • shape of user inputs for UI
      • UI needs to be simplified for initial implementation, based on technical investigation
    • Martina expecting to review use cases today. 
  • Owen Stephens to create new feature and spike task to review relationships between agreements (as a result of ERM-1118)
<10 minsAOB


  • stripes / locale issue referred to John Coburn
  • not for ERM developmentm, but for ERM testing once Stripes fix has changed 

Another issue related to datepicker needs Stripes attention

  • potentially related issue previously raised by Claudia on Jira
  • depends on non-US timezone change

Wonky coverage

  • coverage date wrapping is reduced 
  • happened before - usually occurs when MCL is updated
  • could be related to recent MCL column width changes
  • should be able to rollback the ERM bespoke code to leverage updated MCL column changes
  • Gill to add an issue for Adi to look at.