2020-09-16 ERM Delivery Weekly Update

2020-09-16 ERM Delivery Weekly Update

Meeting Details

Date

Sep 16, 2020 

Time

10:30am ET, 3:30pm UK, 4:30pm Germany

Location

Video Call in FOLIO Slack: #erm-developers

Goals

Participants

  • @Jag Goraya

  • @Ethan Freestone

  • @Peter Böhm

  • @Aditya matukumalli

  • @Gill Osguthorpe

  • @Owen Stephens

Apologies

Discussion items

 

Time

Item

Notes

Action Items

Time

Item

Notes

Action Items

<5 mins

Introductions

 

20

Sprint Cutoff

Release Candidates

Code Review: NA

QA / UAT: 

Items at Risk / Spillover

Blocked: NA

In Progress

  • https://folio-org.atlassian.net/browse/ERM-1118

    • branch is up with fix, that is tested locally

    • GORM blackbox / hibernate session flush is at root of issue

    • hotfix release patch request raised in #release_bug_triage

      • approved by Mike Gorrell 

      • waiting on Mark / Jakub to second approve

    • wondering whether it needs to go into master and/or goldenrod

    • will be added to ui-agreements master so it can be regression tested

    • relationship handling needs a review - frontend is doing something that should probably be done in the backend

  • https://folio-org.atlassian.net/browse/ERM-780

    • returned to dev from code review

    • Adi adding eholdings to default config so that Claudia can get it on local dev environment

    • Will then need master pulling down and testing on snapshot

    • expecting to slip

  • https://folio-org.atlassian.net/browse/ERM-999

    • code example expected later today

  • https://folio-org.atlassian.net/browse/ERM-1114

    • not going to put this into migrations, but separating out as a service that can be triggered

      • manually (by re-registering tenant) or

      • automatically on upgrade

    • cannot currently run as an async job - attempting to do that to complete cleanup

    • then the issue fix will follow, which expects to be straightforward (precedent exists with licenses)

    • testing is going to require an upgradeable environment

      • not previously done a migration locally

    • expecting to slip because of testing overhead

Sprint Backlog

Needs Elaboration: 

  • https://folio-org.atlassian.net/browse/ERM-1102

    • use cases reviewed by dev

    • way forward is expected to allow users to write their own closures using the same methods that the code will, rather than a rule-based implementation

    • proof of concept / spike repo on gitlab set up by Ian

    • New tasks:

      • spike required to determine

        • whether groovy based closure is feasible

        • shape of user inputs for UI

      • UI needs to be simplified for initial implementation, based on technical investigation

    • Martina expecting to review use cases today. 

@Owen Stephens to create new feature and spike task to review relationships between agreements (as a result of ERM-1118)

<10 mins

AOB

ERM-1088

  • stripes / locale issue referred to John Coburn

  • not for ERM developmentm, but for ERM testing once Stripes fix has changed 

Another issue related to datepicker needs Stripes attention

Wonky coverage

  • coverage date wrapping is reduced 

  • happened before - usually occurs when MCL is updated

  • could be related to recent MCL column width changes

  • should be able to rollback the ERM bespoke code to leverage updated MCL column changes

  • Gill to add an issue for Adi to look at.