May 6, 2020 

09:30am ET, 2:30pm UK, 3:30pm Germany

Video Call in FOLIO Slack: #erm-developers

<5 mins

Introductions

• Attendees / Apologies

• Upcoming Availability

  • Steve off Mon

  • Mark off Mon/Tue

  • Mark no longer allocated to ERM from 1 July

30 mins

WIP Updates

Code Review

• https://folio-org.atlassian.net/browse/ERM-880

• https://folio-org.atlassian.net/browse/ERM-828

• https://folio-org.atlassian.net/browse/ERM-847 / https://folio-org.atlassian.net/browse/ERM-848 / https://folio-org.atlassian.net/browse/ERM-849

  • first pass code review 

  • should be fine

In Progress 

• https://folio-org.atlassian.net/browse/ERM-878

  • Stripes 4.0 being released to master tonight

  • work done, just needs to coordinate

  • recommend to

    • not update any libraries today (staggered release)

    • update / re-fetch after release

  • updating to platform in a couple of weeks

    • should not affect QA

• https://folio-org.atlassian.net/browse/ERM-857

  • 500 error makes sense, so no change needed

  • filtering on `owner exists` rather than `owner id`

  • UI won't call endpoint

  • closing as `won't do`

Sprint Backlog

• https://folio-org.atlassian.net/browse/ERM-843

• https://folio-org.atlassian.net/browse/ERM-510

  • Ready to progress now

• https://folio-org.atlassian.net/browse/ERM-788 / https://folio-org.atlassian.net/browse/ERM-791

  • API definition / structure to be defined by dev

Needs Elaboration

• https://folio-org.atlassian.net/browse/ERM-844 

  • https://folio-org.atlassian.net/browse/ERM-871

    • see Slack conversation re endpoint

    • endpoint will need

      • ... to go on agreement controller (not entitlement)

      • ... with sanity check

  • https://folio-org.atlassian.net/browse/ERM-872

  • https://folio-org.atlassian.net/browse/ERM-873

  • https://folio-org.atlassian.net/browse/ERM-874

• https://folio-org.atlassian.net/browse/ERM-869

• https://folio-org.atlassian.net/browse/ERM-877

  • pushback from subgroup - unexpectedly controversial

  • returned to Draft for user review

  • will be backend validation that returns

    • a separate endpoint {agreements/validate/property}

    • with key value pairs

    • including internationalised message

  • Steve to do a quick sanity check with notes

  • scope to extend as needed

  • potentially employ finalform async validation

QA / UAT: 

• https://folio-org.atlassian.net/browse/ERM-864

• https://folio-org.atlassian.net/browse/ERM-866

10 mins

New Issues

Raised / to bring into sprint: 

• https://folio-org.atlassian.net/browse/ERM-878  @md331 (Deactivated)

• https://folio-org.atlassian.net/browse/ERM-880  @Claudia Malzer

• https://folio-org.atlassian.net/browse/ERM-875  @Claudia Malzer

• https://folio-org.atlassian.net/browse/ERM-852 / https://folio-org.atlassian.net/browse/ERM-853 @Aditya matukumalli

Raised

• https://folio-org.atlassian.net/browse/ERM-879

• https://folio-org.atlassian.net/browse/ERM-875

<15 mins

AOB

Sprint 4.0

• Being released to master tonight, and updating to platform in a couple of weeks

• Single version of moment per platform

• React change -

  • no direct impact

  • would need to change propTypes if injecting functions into components

• does give hooks for, eg formatMessage, into functional components

• Hooks reference: https://reactjs.org/docs/hooks-intro.html

• More details on #stripes-updates channel in Slack