Populate extended Package metadata from GOKb data

Description

How to populate the fields added in ERM-2045 from the GOKb OAI-PMH data

 

Package property

How to populate from GOKb OAI-PMH XM

Lifecycle status

record.metadata.gokb.package.status

Package availability scope

record.metadata.gokb.package.global

Source data created

record.metadata.gokb.package.dateCreated

Source data updated

record.metadata.gokb.package.lastUpdated

Description

tba

 Package description URLs

tba

 

Not in Scope: see ERM-2172

Package property

How to populate from GOKb OAI-PMH XM

contentType

record.metadata.gokb.package.contentType

Alternative names

record.metadata.gokb.package.variantNames.variantName (note variantNames can contain multiple variantName tags)

Checklist

hide

TestRail: Results

Activity

Show:

Owen Stephens May 23, 2022 at 2:13 PM

QA 2022-05-23:

Are both in the OAI-PMH XML as date times in the format YYYY-MM-DDThh:mm:ssZ

However they end up being stored as just YYYY-MM-DD, and then displayed as date time - this results in both incomplete (missing time) and incorrect (date has offset applied for tenant time zone) information being displayed in the UI

Peter Böhm May 19, 2022 at 2:22 PM
Edited

JSON example from GOKb ingest:

Jag Goraya May 18, 2022 at 3:30 PM

Issue descoped.  Properties with multiple values moved to to resolve hasMany implementation. 

Peter Böhm May 18, 2022 at 12:53 PM
Edited

Problem 1: Saving the alternate names in PackageIngest yields a typeMismatch:

 relevant code: https://github.com/folio-org/mod-agreements/compare/ERM-2059#diff-8f90bc042b7d65dfbedefaed2af641c261c5f07e246edd63d57914509c5c1e60R133-R142  -  alternatively there might be an error in the schema

 

Problem 2: If more than one Alternate Name is supplied from GOKb, they are always joined into one array entry:

original data:

relevant line on GOKb Adapter: https://github.com/folio-org/mod-agreements/compare/ERM-2059#diff-006982d299e392922eede4e7fa7a53ba600ae017e283c48ce189986f1b27f8deR325 

Peter Böhm May 12, 2022 at 3:50 PM

record.metadata.gokb.package.status seems already to be used for package_status?
https://github.com/folio-org/mod-agreements/blob/master/service/src/main/groovy/org/olf/kb/adapters/GOKbOAIAdapter.groovy#L321

basically working:

  • Package availability scope

  • Lifecycle status (see note above)

  • Source data created

  • Source data updated

to be done:

  • the two has many fields (contentType, Alternative names)

  • more extensive testing (more packages)

Done

Details

Components

Assignee

Reporter

Priority

Sprint

Development Team

Bienenvolk

Release

Morning Glory (R2 2022)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created March 21, 2022 at 11:13 AM
Updated October 19, 2022 at 9:30 AM
Resolved August 4, 2022 at 10:49 AM
TestRail: Cases
TestRail: Runs