2024-12-02 Meeting notes

Date

Attendees 

Discussion items

TimeItemWhoNotes
1 minScribeAll

Jenn Colt

Reminder:  Please copy/paste the Zoom chat into the notes.  If you miss it, this is saved along with the meeting recording, but having it here has benefits.

5-10 minLiaison Updates
1 minUpcoming MeetingsAll
  •   - Regular TC Meeting
  •   - Dedicated discussion: Eureka timeline continued
  • -  Regular TC Meeting
  •   -  Dedicated discussion: New language adoption policy
  • - Regular TC Meeting
  • - Developer advocate retro
  • - Regular TC meeting vs Cancel?
  • -  Cancel
  • - Regular TC meeting  vs Cancel?
  • - Cancel
5-10 minTCR Board ReviewAll
  • TCR-46 Mostly done. Dev teams working on some things from the review. PC reviewing mid-month
  • TCR-47 Will start, many criteria won't apply
  • TCR-48 will start this week
  • TCR-49 in progress
5 min

Technical Council Sub-Groups Updates


Static code analysis

  • No progress
  • Is the group still needed? Document current status and defer topic until a Wednesday or TCR improvement subgroup
1 min

GitHub RFCs

Wiki RFCs

All

Go still needs work


1 minDecision LogAll

Go still needs work

5 min

Officially Supported Technologies (OST)

All

Check Recurring Calendar...

Craig McNally Jenn Colt clean up OST and calendar


 5-10 minTC member changesAll
  • Need to announce results
  • Reach out and onboard them - channels, github team, group in Confluence, meeting invites Craig McNally Jenn Colt


The voting period has ended.  We only got votes from 6 members (sad)

*Voting RulesAll
  • Comments on voting options
    • Being able to pass more things and move forward
    • Being able to identify what 'quorum' means when the options are chosen/documented is important
    • If there are so many abstentions we can't have a quorum something is probably wrong
    • Expedience by lowering threshold of votes needed vs having large numbers voting in favor
    • No decision vs fail - no decision you could bring it back up, and might get caught in a loop
    • Chairs could keep it from coming up over and over but then someone might never get a decision on their item
    • If too many abstain it just never gets solved?
    • Should no decision equal a fail?
    • Original rules are more like 'not yes' vs active decision to say no
    • Will update the pass/fail language to be consistent with what the proposal uses (what is in the proposal for an option should be the same as what is in the table for that option)
    • Will make a new table with the specific decision points (slack/no slack, min num of yes votes, etc)
NAZoom Chat


00:12:46	Ingolf Kuss:	https://folio-org.atlassian.net/wiki/spaces/TC/pages/602013698/2024-11-12+Static+Code+Analysis+Meeting+notes
00:15:05	Tod Olson:	And I'm afraid much of this came up while I was on vacation.
00:18:29	Ingolf Kuss:	added to https://folio-org.atlassian.net/wiki/spaces/TC/pages/5052868/Technical+Council+Sub+Groups
00:21:16	Craig McNally:	Reacted to "added to https://fol..." with 👍
00:51:00	Ingolf Kuss:	in Option#2, the last 2 examples would be "no decision - might go to Slack Voting"
00:51:11	Craig McNally:	Reacted to "in Option#2, the las..." with 👍
00:54:03	Tod Olson:	@Jenn Colt , let me know if you'd like some help working on this.

Topic Backlog

Decision Log ReviewAll

Review decisions that are in progress.  Can any of them be accepted?  rejected?

Translation SubgroupAllSince we're having trouble finding volunteers for a subgroup, maybe we can make progress during a dedicated discussion session?
Communicating Breaking ChangesAll

Currently there is a PoC, developed by Maccabee Levine, of a utility to catalog Github PRs that have been labeled with the "breaking change" label. We would like to get developer feedback on the feasibility of this label being used more often, and the usefulness of this utility. 

Officially Supported Technologies - UpkeepAll

Previous Notes:

  • A workflow for these pages. When do they transition from one state to another. Do we even need statuses at all ?

Stripes architecture group has some questions about the Poppy release.

Zak: A handshake between developers, dev ops and the TC. Who makes that decision and how do we pass along that knowledge ? E.g. changes in Nodes and in the UI boxes. How to communicate this ? We have a large number of teams, all have to be aware of it.  TC should be alerted that changes are happening. We have a couple of dedicated channels for that. Most dev ops have subscribed to these channels. How can dev ops folk raise issues to the next level of community awareness ? There hasn't been a specific piece of TC to move that along.

Craig: There is a fourth group, "Capacity Planning" or "Release Planning". Slack is the de facto communication channel.  There are no objections to using Slack. An example is the Java 17 RFC. 

Craig: The TC gets it on the agenda and we will discuss it. The TC gets the final say.

Marc Johnson: We shouldn’t use the DevOps Channel. The dev ops folks have made it clear that it should only be used for support requests made to them.

Jakub: Our responsibility is to avoid piling up technical debt.

Marc: Some set of people have to actually make the call. Who lowers the chequered flag ?

Craig: It needs to ultimately come to the TC at least for awareness. There is a missing piece. Capacity Planning needs to provide input here. 

Marc: Stakeholders / Capacity Planning could make that decision. Who makes the decision ? Is it the government or is it some parts of the body ?

Marc: the developers community, the dev ops community and sys ops are involved. For example the Spring Framework discussion or the Java 17 discussion. But it was completely separate to the TC decision. It is a coordination and communication effort.

Marc: Maybe the TC needs to let go that they are the decision makers so that they be a moderating group.

Jakub: I agree with Marc. But we are not a system operating group. Dependency management should be in the responsibility of Release management. There are structures in the project for that.

Jason Root: I agree with Jakub and with Marc also. Policies should drive operational/release/support aspects of Folio.

Jason Root: If the idea of “support” is that frameworks are supported, then of course the project should meet that.

Marc Johnson
Some group needs to inform OleksAii when a relevant policy event occurs.
These documents effectively ARE the manifestation of the policy.

Craig: This is a topic for the next Monday session.

Craig to see if Oleksii Petrenko could join us to discuss the process for updating the officially supported technologies lists.


Dev Documentation VisibilityAll

Possible topic/activity for a Wednesday session:

Discuss/brainstorm:

  • Ideas for the type of developer-facing documentation we think would be most helpful for new developers
  • How we might bring existing documentation up to date and ensure it's consistent 
  • etc.
API linting within our backend modulesAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1713343461518409


Hello team, I would like to discuss API linting within our backend modules. Some time ago, we transitioned our linting process from Jenkins to GitHub Actions as outlined in https://folio-org.atlassian.net/browse/FOLIO-3678. I am assuming that this move was done via some technical council decision. Please correct me if I'm wrong.
In my observations, I've found two problems:
  1. Schema linting does not occur if the schemas are in YAML format.
  2. There are issues with resolving some deeper references during API linting.
Although I'm unsure about how to improve the existing linting implementations within Folio, I propose to consider an open-source solution that handles OpenAPI linting effectively and allows us to define custom rules. For your reference: https://stoplight.io/open-source/spectral A test of this solution can be found in this PR: https://github.com/folio-org/mod-search/pull/567. The same PR also provides an example of custom rule definition: https://github.com/folio-org/mod-search/pull/567/files#diff-d5da7cb43c444434994b76f3b04aa6e702c09e938de09dbc09d72569d611d9ab.Also, by employing 'Spectral', I discovered AsyncAPI (https://www.asyncapi.com/en), an API design tool similar to OpenAPI but for asynchronous interactions. I suggest that we consider using AsyncAPI in FOLIO to generate documentation for Kafka interactions.


PR TemplatesAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1713445649504769

Hello team, Small request to consider.
Regarding pr templates.
  1. From my perspective, pr template is not good idea. Even the biggest open source projects that are contributed by many people don't have any pr template. Currently what we have for acq modules https://github.com/folio-org/mod-orders-storage/blob/master/PULL_REQUEST_TEMPLATE.md
  2. These pr template is inconsistent in different teams.
What I suggest is that, pr template shouldn't be any instructions, because most developer who are creating pr have already understand the rules. If we put just two section into template, it will encourage developers to write more about their work and that lead to knowledge  sharing among developers.
Proposed Mod KafkaAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1714471592534689

Mike Taylor

Proposal. If and only if a FOLIO instance is running Kafka, it should insert and enable a module called mod-kafka, which consists entirely of a module descriptor that says it provides the interface kafka. The purpose is so that other modules can use the standard <IfInterface> and similar tools to determine whether they should attempt Kafka operations. Rationale: the FOLIO ILS depends absolutely on Kafka, but other uses of the platform will not. One such example: a dev platform that includes only mod-users, used as a source of change events for Metadb.