2024-05-29 Meeting notes

Date

Attendees 


Discussion items

TimeItemWhoNotes
1 minScribeAll
Taras Spashchenko is next, followed by Jakub Skoczen

Reminder:  Please copy/paste the Zoom chat into the notes.  If you miss it, this is saved along with the meeting recording, but having it here has benefits.

5-10 minLiaison Updates
  • CC: Maccabee Levine 
    • No CC meeting this week.
  • PC: Tod Olson
  • RMS Group: Jakub Skoczen
    • in a previous meeting, their request was approved but no action had been taken yet. Jakub Skoczen will follow up with Oleksii Petrenko and update the meeting notes accordingly
  • Security Team: Craig McNally
    • No updates
  • Tri-council Application Formalization: Jenn Colt
    • Jenn Colt mentioned the group feels at a crossroads, being at the turn of the quarter and approaching a Tri Council meeting. The group has been meeting for six months and is deciding on next steps, particularly regarding the movement towards Eureka.
    • Ingolf Kuss clarified that there are no current license questions, referencing a previous statement from EBSCO that if there were license issues, they wouldn’t have used the con. 
    • Discussion points:
      • Whether to endorse movement towards Eureka at the next Tri Council meeting.
      • The readiness of hosting providers to cope with and enact Eureka.
      • The potential transition period between classic folio and Eureka and how to manage it without leaving anyone behind.
      • The need to balance different tracks: governance impacts and readiness of hosting providers.
    • Action Items:

      • Ingolf Kuss has been asked to bring the topic of Eureka's introduction to the Sysops for their opinion on concerns, overlap periods, licenses, and complexity. He will ensure the overview document from EBSCO is copied into the Sysops channel for reference.
      • A Sysops meeting will be convened on Friday to gather opinions, which will be brought to the formalization subgroup.
5 minUpcoming MeetingsAll
  • - Use as regular meeting for this week, due to Monday holiday
  •   - Regular TC Meeting
  •  - Alternate time meeting for China and Australia topics?
  •   - Regular TC Meeting
  •   - Dedicated Discussion - ???
  •   - Regular TC Meeting
4 minTCR Board ReviewAllA request for technical evaluation of a reading room management module was discussed. It was clarified that the module is needed by the Library of Congress to manage access and item requests. Confirmation from the Product Council on the review status is pending, and further actions will be taken once approval is verified.
10-15 min

Technical Council Sub-Groups Updates

All

The Technical Council discussed updates on the TCR process improvements. Maccabee Levine mentioned that the recent TCR updates formalized their application to both front-end and back-end libraries, but a communication piece was missing. There was a debate on whether to use videos or documentation for better communication. The need for consistent outreach to developers was emphasized, with suggestions for maintaining awareness through wiki pages and regular updates. The subgroup aimed to conclude its current iteration without restarting but recognized the necessity of bridging process changes with effective communication. Additionally, updates on static code analysis and developer documentation meetings were provided, with schedules set for the following week.
5 minRFCs

All

  • Go Language:
    • Ready for FINAL review by TC: https://github.com/folio-org/rfcs/pull/33
      The team discussed the review process for the Go language. There was a clarification about the readiness for the final review, with confirmation that the Go language had been in public review for months and all feedback had been addressed. The final review and vote were scheduled for next Monday 06/03/2024 The timeline was confirmed, and everyone agreed to proceed with the plan.
  • Application Formalization: When will we do the final review?
    • The following Monday 
5 minAction Items
  • Jeremy Huff:
    • Reach out to Australia and China for topics
      • This is done, and we are waiting for feedback
  • Maccabee Levine 
    • Create a calendar page for TC recurring events
      • Created
  • Craig McNally
    • Investigate which version modules are actually using.
      • in progress
10 - 15 Breaking Changes ReviewAll

Review the summary of ideas discussed during the dedicated discussion on breaking changes

Google doc created with all the ideas discussed during last weeks dedicated discussion meeting : 

The discussion focused on improving the process for communicating breaking changes in the codebase based on a proof of concept (POC) utility designed by Maccabee Levine, aiming to facilitate the notification of breaking changes. Despite the progress, further improvements were suggested.
Key points:

  1. Current POC and Feedback:

    • The POC utility's primary function is to communicate breaking changes as they occur.
    • Ankita Sen consolidated feedback and suggestions from previous meetings into a document for review.
    • There was a consensus that early notification of breaking changes is crucial, and current methods may be inadequate.
  2. Challenges and Solutions:

    • One major challenge identified was the timing of notifications. Developers need to know about breaking changes as soon as possible.
    • There was discussion about whether JIRA could be used to flag potential breaking changes early in the development process.
    • It was suggested that developers might not always realize a change is breaking until later stages, making early notification difficult.
  3. Role of Developers and Product Owners:

    • The responsibility of communicating breaking changes often falls on developers. However, there's a recognition that this might not always be effectively managed.
    • There was a suggestion to involve product owners and Scrum Masters more actively in this process, potentially during the planning stages of development.
    • This could include prompting developers to identify potential breaking changes early and ensuring these are flagged in JIRA or other tracking tools.
  4. Communication Strategies:

    • The effectiveness of using videos for communication was discussed, with a preference for having clear, written documentation as a primary source of information.
    • A hybrid approach using videos to highlight key points in documentation was considered beneficial but not a replacement for written records.
  5. Practical Examples and Best Practices:

    • Examples were shared where communication about breaking changes was handled well, such as posting notifications in Slack and creating JIRA tickets for all affected modules before merging changes.
    • The need for a culture of proactive communication and responsibility among developers was emphasized. Encouraging developers to subscribe to channels where breaking changes are discussed was seen as vital.
  6. Future Steps:

    • The discussion concluded with an acknowledgment that more work is needed to define actionable steps for improving the communication process.
    • Suggestions included potentially automating some aspects of identifying and notifying about breaking changes, though manual effort and responsibility would still be crucial.

Overall, while the discussion advanced understanding and clarified the issues, the need for continued dialogue and development of concrete solutions was recognized.

10 - 15Developer Advocate Service Board PreviewPatrick PacePatrick will demonstrate the new Jira Service board for interfacing with the Developer Advocate, to solicit feedback from the TC. https://folio-org.atlassian.net/jira/servicedesk/projects/DA
1 minDecision LogAll


Time Permitting

Officially Supported Technologies (OST)

All

Standing agenda item to review/discuss any requested or required changes to officially supported technology lists

NAZoom Chat
00:02:48	Maccabee Levine:	Beep boop humans are slow
00:13:50	Craig McNally:	Sorry I'm late guys.
00:18:07	Jenn Colt:	That’s about when the PC one was
00:20:41	Owen Stephens:	I don’t think this has come to PC yet
00:35:48	Maccabee Levine:	https://folio-org.atlassian.net/wiki/spaces/TC/pages/227082271/Recurring+Calendar
00:42:38	Craig McNally:	The context for my action item is:
Question about AWS SDK version, v.1 going out of support end of 2025. FOLIO using for S3, need to check which version specific modules use. Craig McNally to investigate which version modules are actually using.

I did look into this and posted to #tc-internal:

WRT AWS SDK version1 vs version2...
Repositories which directly pull in this dependency (all on 2.x already):  https://github.com/search?q=org%3Afolio-org+aws-sdk+language%3A%22Maven+POM%22&type=code
Repositories which use the folio-s3-client, which hash been on aws sdk version 2 for a long time:  https://github.com/search?q=org%3Afolio-org+folio-s3-client+language%3A%22Maven+POM%22&type=code
11:56
So I think everyone is already on aws sdk v2
00:44:04	Craig McNally:	BTW Zak is back
01:01:26	Tod Olson:	Thanks for the conversation, I really like where this is going. Encouraging more communication and ownership is great.
01:01:41	Ingolf Kuss:	Reacted to "Thanks for the conve..." with 👍

Topic Backlog

Decision Log ReviewAll

Review decisions that are in progress.  Can any of them be accepted?  rejected?

Translation SubgroupAllSince we're having trouble finding volunteers for a subgroup, maybe we can make progress during a dedicated discussion session?
Communicating Breaking ChangesAllCurrently there is a PoC, developed by Maccabee Levine, of a utility to catalog Github PRs that have been labeled with the "breaking change" label. We would like to get developer feedback on the feasibility of this label being used more often, and the usefulness of this utility. 
Officially Supported Technologies - UpkeepAll

Previous Notes:

  • A workflow for these pages. When do they transition from one state to another. Do we even need statuses at all ?

Stripes architecture group has some questions about the Poppy release.

Zak: A handshake between developers, dev ops and the TC. Who makes that decision and how do we pass along that knowledge ? E.g. changes in Nodes and in the UI boxes. How to communicate this ? We have a large number of teams, all have to be aware of it.  TC should be alerted that changes are happening. We have a couple of dedicated channels for that. Most dev ops have subscribed to these channels. How can dev ops folk raise issues to the next level of community awareness ? There hasn't been a specific piece of TC to move that along.

Craig: There is a fourth group, "Capacity Planning" or "Release Planning". Slack is the de facto communication channel.  There are no objections to using Slack. An example is the Java 17 RFC. 

Craig: The TC gets it on the agenda and we will discuss it. The TC gets the final say.

Marc Johnson: We shouldn’t use the DevOps Channel. The dev ops folks have made it clear that it should only be used for support requests made to them.

Jakub: Our responsibility is to avoid piling up technical debt.

Marc: Some set of people have to actually make the call. Who lowers the chequered flag ?

Craig: It needs to ultimately come to the TC at least for awareness. There is a missing piece. Capacity Planning needs to provide input here. 

Marc: Stakeholders / Capacity Planning could make that decision. Who makes the decision ? Is it the government or is it some parts of the body ?

Marc: the developers community, the dev ops community and sys ops are involved. For example the Spring Framework discussion or the Java 17 discussion. But it was completely separate to the TC decision. It is a coordination and communication effort.

Marc: Maybe the TC needs to let go that they are the decision makers so that they be a moderating group.

Jakub: I agree with Marc. But we are not a system operating group. Dependency management should be in the responsibility of Release management. There are structures in the project for that.

Jason Root: I agree with Jakub and with Marc also. Policies should drive operational/release/support aspects of Folio.

Jason Root: If the idea of “support” is that frameworks are supported, then of course the project should meet that.

Marc Johnson
Some group needs to inform OleksAii when a relevant policy event occurs.
These documents effectively ARE the manifestation of the policy.

Craig: This is a topic for the next Monday session.

Craig to see if Oleksii Petrenko could join us to discuss the process for updating the officially supported technologies lists.


Dev Documentation VisibilityAll

Possible topic/activity for a Wednesday session:

Discuss/brainstorm:

  • Ideas for the type of developer-facing documentation we think would be most helpful for new developers
  • How we might bring existing documentation up to date and ensure it's consistent 
  • etc.
API linting within our backend modulesAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1713343461518409


Hello team, I would like to discuss API linting within our backend modules. Some time ago, we transitioned our linting process from Jenkins to GitHub Actions as outlined in https://folio-org.atlassian.net/browse/FOLIO-3678. I am assuming that this move was done via some technical council decision. Please correct me if I'm wrong.
In my observations, I've found two problems:
  1. Schema linting does not occur if the schemas are in YAML format.
  2. There are issues with resolving some deeper references during API linting.
Although I'm unsure about how to improve the existing linting implementations within Folio, I propose to consider an open-source solution that handles OpenAPI linting effectively and allows us to define custom rules. For your reference: https://stoplight.io/open-source/spectral A test of this solution can be found in this PR: https://github.com/folio-org/mod-search/pull/567. The same PR also provides an example of custom rule definition: https://github.com/folio-org/mod-search/pull/567/files#diff-d5da7cb43c444434994b76f3b04aa6e702c09e938de09dbc09d72569d611d9ab.Also, by employing 'Spectral', I discovered AsyncAPI (https://www.asyncapi.com/en), an API design tool similar to OpenAPI but for asynchronous interactions. I suggest that we consider using AsyncAPI in FOLIO to generate documentation for Kafka interactions.


PR TemplatesAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1713445649504769

Hello team, Small request to consider.
Regarding pr templates.
  1. From my perspective, pr template is not good idea. Even the biggest open source projects that are contributed by many people don't have any pr template. Currently what we have for acq modules https://github.com/folio-org/mod-orders-storage/blob/master/PULL_REQUEST_TEMPLATE.md
  2. These pr template is inconsistent in different teams.
What I suggest is that, pr template shouldn't be any instructions, because most developer who are creating pr have already understand the rules. If we put just two section into template, it will encourage developers to write more about their work and that lead to knowledge  sharing among developers.
Java 21All

https://folio-project.slack.com/archives/CAQ7L02PP/p1713445764285349


Is Tech Council considering to update to java 21, I head good things from Netflix engineering teams about Garbage collector
https://www.infoq.com/presentations/netflix-java/ (edited)

Proposed Mod KafkaAll

https://folio-project.slack.com/archives/CAQ7L02PP/p1714471592534689

Mike Taylor

Proposal. If and only if a FOLIO instance is running Kafka, it should insert and enable a module called mod-kafka, which consists entirely of a module descriptor that says it provides the interface kafka. The purpose is so that other modules can use the standard <IfInterface> and similar tools to determine whether they should attempt Kafka operations. Rationale: the FOLIO ILS depends absolutely on Kafka, but other uses of the platform will not. One such example: a dev platform that includes only mod-users, used as a source of change events for Metadb.

Action Items