/
2022-12-13 Spitfire Retrospective (+ Nolana release retro)

2022-12-13 Spitfire Retrospective (+ Nolana release retro)

Dec 15, 2022

 

Date

Dec 13, 2022

Participants

@Shans Kaluhin @Pavlo Smahin @Viacheslav Kolesnyk@Sherzod Nurjonov @Dmytro Melnyshyn  @Valery_Pilko @Oll Isanbaev 

 

Retrospective

 

What did we do well?

  • Even though we had a lot of bugs related to Nolana and Morning  Glory, and worked under the pressure, the team managed to fix them all during Sprint 154. Congrats!!!

  • Sherzod mentioned that during prev sprint he had a good chance to deep dive into modules, especially modules involved into data-import process

  • UI team has fixed issues related to Nolana and Morning Glory very quickly

  • Team hopes that mod-data-export worker as well as other modules will not need an extra release for Nolana or Morning Glory

 

What should we have done better?

  • mod-search issues:

    • It would be profitable for the team to have single point for mod-search requirements + test cases that should always work.  As a possible option - sync up between Prokopovich PO and Spitfire (possibly Valery + Pavlo+ Vijay) to summarise/clarify 

    • Spitfire team should be notified about reindex results, here are possible actions:

      • prepare checklist for Kitfox team on how to check if reindex run successful (holdings + authorities)

      • or put errors to database table(cons - there is no info whether it was reindex issue or update of the entity). This issue may be used for this activity https://folio-org.atlassian.net/browse/MODINVSTOR-990

  • initial cause of many issues in mod-data-export-worker is the lack of unit tests. 

  • discuss the option with substitution of integration tests with unit tests  →  @Natalia Zaitseva to add it into Oleksii's Petrenko retro board

  • Natalia to create board with logged issues for Nolana and Morning Glory.

  • Natalia to create Complaints and Suggestions board to make it easy to write notes for the retros.

  • follow the checklist @Khalilah Gambrell  created Release Readiness Checklist - Orchid

Actions

December 2022

@Natalia Zaitseva to create Complaints and Suggestions board/page → created page for R1 2023
@Natalia Zaitseva to move action points from previous Retros → copied items for 2022 year
@Natalia Zaitseva to create a board with visualised info related to issues found for Nolana Bug Fix and Morning Glory HF#1 
Morning Glory HF #1 board - here
Nolana Bug Fix board - here 
@Natalia Zaitseva to discuss the option with substitution of integration tests with unit tests (add it to Oleksii's Petrenko retro board + add Pavlo to discussion) → added point to Folio Release Board
@Vijay Gopalakrishnan to work on point related to mod search 
it would be profitable for the team to have single point for mod-search requirements + test cases that should always work.  As a possible option - sync up between Prokopovich PO and Spitfire (possibly Valery + Pavlo+ Vijay) to summarise/clarify 

Spitfire team should be notified about reindex results, here are possible actions:

November 2022

Make sure release notes are up-to-date two weeks before the start of bugfest 
Test MARC authority mapping rules prior to bugfest 
If the team has to investigate an issue that is more than an hour and is not a part of any other ticket, then create a ticket and include in current sprint OR backlog. 
When requesting PTF testing - Change the status to Blocked when first version is buggy and requires additional development effort 

 

October 2022

@Natalia Zaitseva to track Java 17 update for Orchid

February 2022

review current DoR and DoD and our related processes
too long preparation of Vagrant box for schema upgrade testing. We should think about other approach for this testing (local Docker, Rancher)
Vagrant boxes are using for local testing now, but there is so much problems and restrictions with Vagrant (using a lot of resources: at least 15gb of RAM, impossibility of using new versions of Docker, new versions of VirtualBox could cause crashes of box, impossibility of using some useful for development features on Windows like WSL, a lot of time for up and run box, complicated procedure of module deployment). We should think about other approach for local testing (docker compose that will up infrastructure, auth-modules and only needed business modules)
mod-quick-marc logging should be improved
each feature should include Karate tests
self-evaluation document misleading (based on Module acceptance criteria template I tried to create a PR in that repo, but self-evaluation results should instead be saved in an online Word document and the link added to technical evaluation Jira ticket)

January 2022

some failing tests related to Karate tests still appear