Spitfire - Definition of Done v1.0

Checklist

Feature/User Story

Sprint Demo/Review

Release

Unit tests are written and are passing. At least 80% code coverage is expected and 100% is preferred for critical code.

Y

Pull request is created following existing templates for mod-kb-ebsco and ui-eholdings in folio.org and contain a .gif of feature implemented where its appropriate

Y

Peer code review is performed and at least one developer from Ebsco and one developer from Spitfire team are requested for code review; code can be merged to master only when build passes and after peer approval

Y

Fix reported code smells, security vulnerabilities, lint errors that are reported by Sonarqube and other tools in CI pipeline before merging code to master

Y

Existing API tests (backend modules) and Integration tests (UI modules) are maintained/implemented/improved and pass

Y

Microservice contract tests(pact) are created and integrated into CI pipeline – future requirement

Y

Any configuration and/or build scripts are updated and tested

Y

Build deployed successfully to snaptshot-stable environment(test, integration etc.) - future requirement

Y

QA is performed and issues resolved

- Test-cases are created in "Testrail" against acceptance criteria.
- Feature is tested by QA against acceptance criteria on supported browsers/devices/platforms pass"

Y

Feature implemented meets acceptance criteria defined by PO/TL

Y

Regression tests pass – future requirement

Y

Verify that PII stored is encrypted

Y

Verify compliance with GDPR – future requirement

Y

Feature OK’ed by UX and complies with:

- https://ux.folio.org/docs/guidelines/

- WCAG 2.0 Level AA accessibility compliance
- Validate with Jeffrey Cherewaty, Filip Jackobsen and/or John Coburn before coming with new design patterns in UX that’s not consistent with Stripes

Y

Feature is accepted by PO
- Move the story to “in Review” and assign it to PO who will review and move it to Done if acceptable

Y

Localization is taken care of in application code

Y

No open critical bugs on any user stories

Y

DoD of each user story, included in demo are met

Y

All demoable features are demoed from the same shared environment – For most demos, this will be FOLIO integration environment

Y

Releases are created following: https://dev.folio.org/guidelines/release-procedures/

Y

Installation and deployment scripts are updated

Y

Performance tests are created and pass – Example: All end user interactions < 2 seconds for 95 percentile or no degradation in response time for existing functionality

Y

All bugs reported by QA, manual testing, UAT, PO etc. are fixed

Y

Release notes are created

Y

User documentation updated (deployment documentation, scripts/packaging etc.)

Y

User documentation is localized

Y