Copy of Definition of Done

Implementation of the requirements is completed AND acceptance criteria of the issue have been met

Any bug created, should have an "RCA group" value

Any PII data stored is encrypted (if applicable)

Data migration scripts are implemented for schema changes (if applicable).

Sample and reference data is updated to match the feature or schema change (where applicable)

Unit tests are written and passing (at least of 80% code coverage is expected for new code and 100% is preferred for critical code)

API Karate tests are written/updated and executed (passing if applicable)

Translation keys are included in application code (code doesn’t rely on hardcoded values)

Functionality is checked with non-admin user (appropriate permissions are set for regular user to make sure that verified functionality is accessible)

Dev verification is performed by a developer on Vagrant Box/Rancher/Snapshot/Bugfest environment and issues resolved if found

Backend functionality is checked on multi-tenant environment (Performance, Sprint testing, Bugfest) with the help of Karate tests where possible

Reasonable code smells, security vulnerabilities, lint errors that are reported by Sonarqube and other tools in CI pipeline are fixed before merging code to master (comment is left in PR in case issues are not fixed))

Pull request is approved by at least one other developer. In case repository belongs to another team, at least one approval from the owning team is required.

Code is available on folio-snapshot.dev.folio.org or folio-snapshot-2.dev.folio.org for current release or specific environment in case of hotfixes/bugfixes

Accessibility check list is considered, and new functionality covered with accessibility tests

Interface version (for backend modules) and module implementation version (for backend (pom.xml) and UI (package.json)) is updated according to the versioning procedure: https://dev.folio.org/guidelines/contributing/#version-numbers. The fixVersion field in JIRA (user story) is updated to match the version that ships the feature/bugfix

A note in dev channel on API major version changes is posted (if applicable)

Module descriptor includes actual information regarding required resources for particular module and readme file and deployment information is updated

QA verification is performed by a QA/developer on multi-tenant environment and issues are resolved if found

The work delivered is tested and accepted by PO (or another stakeholder if applicable)