2024-12-19 Meeting notes

Craig McNally 

Axel Dörrer 

Chris Rutledge 

Jakub Skoczen 

Skott Klebe 

From Craig in slack:

I've been in communication with David Crossley, Wayne Schneider, John Malconian and Peter Murray about the issue above.  They apparently didn't have access to these embargoed issues (SysOps and Core Team).  Peter shared this screenshot with me, which doesn't look right.  I'd like to review this at one of our meetings and come up with a list of changes/improvements for Peter to make.  A few ideas off the top of my head:

1. Add descriptions to each of the security groups, like we have for "FOLIO Security Group"
2. Maybe add a new security group and level for FOLIO devops
3. Review membership of each of these groups and remove users no longer on the project
4. Review the Security Level -> Group mappings.  Some of these don't look quite right to me.

https://files.slack.com/files-pri/T1EPYQDAQ-F075P5YMBJQ/image.png

• If it makes this easier, we could invite Peter to a meeting so we can see the groups/levels interactively and makes adjustments as we go
• Not exactly this, but related... 
  • Issues submitted to the SECURITY JIRA project should automatically be embargoed (Security Level = Folio Security Group)
  • The submitter of issues to the SECURITY JIRA project should be able to view issues they submit, regardless of their Security Level
  • Email notification sent to the Folio Security Group when an issue is created in the SECURITY Jira project.
• Action:  Craig McNally to setup a meeting with Peter and representatives from the Security Team to work through these things after WOLFcon?  
  • We need to look into how security level configuration works to gain a better understanding of why it behaves the way it does.  
    • Why do we have All Folio Developers in the "Sys Ops and Core Team" security level?

Today:

• (Craig) no progress due to lack of time to spend on this.  Does someone else have time to work through this with Peter?

The idea is to draft a proposal policy for this and run it by the TC for approval...

"mod-foo has known security vulnerabilities which are high/critical and have not been addressed in N months.  If these aren't addressed within N months the repository will be archived"  Something like that...

• Communication will be key here... Need to sort out the details.

Today:

Jens Heinrich created a draft and Julian Ladisch gave inputs on better handling of edge cases

Proposal for a Deprecation Policy for FOLIO Modules outside of the official supported set with a Severe Security Vulnerability

Introduction

This proposal outlines a policy for the deprecation of FOLIO modules outside of the official supported set (i.e. flower releases) that are identified to have severe security vulnerabilities and have not been updated in the last three months despite being informed by the Security Team. The purpose of this policy is to maintain the overall security and integrity of the FOLIO ecosystem by deprecating and archiving unmaintained/abandoned software.

1. Objectives

Enhance Security: To mitigate risks associated with unaddressed vulnerabilities, ensuring the safety of the FOLIO project.
Encourage Maintenance: To promote regular updates and maintenance of existing modules.
Inform Stakeholders: To provide clear communication regarding the status of FOLIO modules and associated risks.

2. Pre-deprecation steps

To ensure developers have a reasonable amount of time to fix the vulnerability a three month period is started after the developers have been privately notified by the Security Team. If the notification is not acknowledged within one month, the deprecation process starts immediately.

3. Deprecation Steps after the grace time has expired

Notification:
Inform relevant stakeholders (developers, users, libraries, etc.) about the identified vulnerability and the impending deprecation of the affected module.
Provide guidance on the risks and advise on possible alternatives.

Deprecation Announcement:
Officially announce the deprecation of the module on the FOLIO community platforms (e.g., comments in README in GitHub).
Set a clear timeline for the deprecation phase, providing stakeholders with a timeline for migration. This timeline should usually be one month for modules outside of the official supported set which are not planned for the next release.

Module Removal:
Archive the GitHub repositories and update documentation to reflect the changes and indicate alternative solutions.

4. Exceptions

Modules that are part of a larger, ongoing development project with a clear and communicated timeline for resolution may be exempt from immediate deprecation.
Modules that have an active and engaged community working toward updates or patches may be considered for extended timelines.

5. Conclusion

The proposed deprecation policy aims to create a safer ecosystem for all FOLIO users by addressing severe security vulnerabilities in a timely and organized manner. By implementing this policy, we can ensure that the FOLIO platform remains robust, secure, and adaptable to the evolving security landscape.

A dedicated page has been created at  https://folio-org.atlassian.net/wiki/x/KAAHJw

• Awareness has been raised with the TC.  Some comments have been left.
• Let's discuss in the new year when Jens is around.

Anything Urgent?
Review Mike's Kanban board?
Review Security board?
Review labels=security?

Under Review Filter:  Getting issues...

• Snyk review - the go modules (mod-reporting, eureka-setup) have 5 criticals, but they are false positives, Snyk is wrong. Other vulnerability tools for go don't report them.
  • These have been "ignored" in snyk.  We may want to report these false positives to Snyk.
• SECURITY-218 - Getting issue details... STATUS was discussed.  Eureka team should provide details.  Craig McNally will coordinate.
• Spring based modules (e.g. mod-data-export-worker, mod-workflow, etc.) have a new critical (https://www.cve.org/CVERecord?id=CVE-2024-50379).  Jira: SECURITY-248 - Getting issue details... STATUS
• 66 high severity issues for perf-testing... Probably don't have JIRAs for these, but if we can get them created, it's possible that PTF can make some progress on resolving some of these.
• Discussed vulnerabilities raised against ui-users where the yarn.lock file specifies a vulnerable version of jspdf → dompurify.  Ryan Berger will look into how this yarn.lock file is maintained.

From slack conversation, I think I've gathered the following:

• In this case (bank account and transit numbers), the information is highly sensitive.  
  • Highly sensitive information should:
    • Be stored in it's own table
    • Accessed via a dedicated API
    • Protected by a dedicated permission
    • Encrypted in the database, not only on disk.  
      • This could mean either:
        • Explicitly encrypting/decrypting in the application layer and storing the encrypted data in postgres
        • Utilizing postgres extensions/modules to encypt certain columns, e.g. via pgcrypto (see https://www.postgresql.org/docs/current/encryption-options.html)

Let's review and discuss before providing this feedback to Raman.

Axel Dörrer also suggested that defining classes of sensitivity could help teams determine which techniques are applicable in various situations.  I agree having some general guidelines on this would be helpful.

• regular data
  • low sensitive - permission based on same API
  • high sensitive - permission based on dedicated API

It would probably help to provide concrete examples of data in each class.  This can be a longer term effort, we don't need to sort out all the details today.

Axel Dörrer 

Due to some absences on different reasons the group stalled. Axel will try to reactivate the group.