2024-05-02 Meeting notes

@Craig McNally 

@Julian Ladisch 

@Axel Dörrer 

@Ryan Berger 

@Chris Rutledge 

@Jakub Skoczen 

@John Coburn 

@Skott Klebe 

25-30 min

Anything Urgent? Review the Kanban board?

Team

• We need to determine if DevOps can work on https://folio-org.atlassian.net/browse/FOLIO-3896 or if they don't have bandwidth, and the debian packages aren't used anymore, archive them.  It sounds like some SysOps do use this, but we know that DevOps has very little bandwidth these days.

  • Action:  Craig to ask in #devops if they can and are willing to work on this, then we can decide next steps.

  • Update:  Craig Posted, in #devops, but not a single reply

  • This is referenced in the single-server deployment documentation, and not part of the official flower releases

  • Maybe the core platform team can take on this work since there hasn't been any replies from the devops community.

  • Action:  Reach out to @Jakub Skoczen to see if we can get some movement on this from either devops or core-platform teams (Craig)

  • Action:  Ask #sys-ops if this is still needed, or can they switch to the docker containers. (Craig)

• Another prisma scan was done against the Q release candidate versions of modules.  Several issues were found and logged.

  • Some of these are related to the Architectural changes being proposed by the Eureka team.  @Craig McNally will triage these with the team.

• Discussed potential improvements to Jira workflows (SECURITY project)

  • Automatically embargo (set the security level to Folio Security Team)

  • Allow the creator to see issues after being embargoed

• Fixes to the XSS issues have made it into Poppy CSP #3,4, but there's still some work which is targeting CSP#5

  • Changes deployed to Poppy Bugfest for STSMACOM-816

Cookie SameSite topic raised in Slack

Team 

• Production systems should be setup with SameSite = Strict or Lax

  • Bugfest should be setup in this way, but it's currently set to none.

  • Julian will continue to try to get Kitfox to move this back to Strict/Lax

• Hosted reference envs, and other envs (e.g. rancher envs, etc.) which UI devs might develop against (point a local UI build at) should either:

  • Use SameSite = none OR

  • UI devs should use a proxy like NGINX (running locally)

    • Action: @Julian Ladisch to work on a PoC of this.

• Generally speaking it's better to user SameSite=Strict/Lax when possible to help identify issues earlier

• Action: Craig to invite Zak to next week's Security Team meeting to discuss further.

Time permitting

Advice for handling of sensitive banking information

Team

From slack conversation, I think I've gathered the following:

• In this case (bank account and transit numbers), the information is highly sensitive.  

• Highly sensitive information should:

  • Be stored in it's own table

  • Accessed via a dedicated API

  • Protected by a dedicated permission

  • Encrypted in the database, not only on disk.  

    • This could mean either:

      • Explicitly encrypting/decrypting in the application layer and storing the encrypted data in postgres

      • Utilizing postgres extensions/modules to encypt certain columns, e.g. via pgcrypto (see https://www.postgresql.org/docs/current/encryption-options.html)

Let's review and discuss before providing this feedback to Raman.

@Axel Dörrer also suggested that defining classes of sensitivity could help teams determine which techniques are applicable in various situations.  I agree having some general guidelines on this would be helpful.

• regular data

• low sensitive - permission based on same API

• high sensitive - permission based on dedicated API

It would probably help to provide concrete examples of data in each class.  This can be a longer term effort, we don't need to sort out all the details today.

• Next Steps:

  • Clearly define/formalize the various classes

    • Come up with concrete examples of each class

  • Build out guidance

    • Come up with concrete examples of how to protect each class of data.

  • Consider storing some classes of data outside of postgres altogether - e.g. in secret storage.

    • What would be the guidance we provide to teams for this so we don't end up with each team doing things differently?

    • SecretStore interface and existing implementations are currently only read-only.  They would need to be extended to allow for creation/mgmt of this information.

  • Craig to start a conversation in slack about this.

    • Seeking a volunteer to generate a draft document for us to review at a later meeting.

Today:

@Axel Dörrer to do a first draft as a base for further discussions

Status on pentesting works within Network traffic control group

@Axel Dörrer 

Due to some absences on different reasons the group stalled. Axel will try to reactivate the group.