2024-02-15 Meeting notes

@Craig McNally 

@Julian Ladisch 

@Axel Dörrer 

@Ryan Berger 

@Chris Rutledge 

@Jakub Skoczen 

@John Coburn 

@Skott Klebe 

5-10 min

CSP processes

Team

• From Last week:

  • We set the target release, even w/o approval.

  • There are dedicated fields in Jira for tracking CSP approval, details, rejection comments, etc.  We will fill these in as approval is requested and approved/rejected

  • There's a bunch of administrative overhead (test plans, rollback, etc.) required prior to requesting approval for CSP inclusion...  in some cases this paperwork is not yet ready, which is why we haven't requested CSP approval yet.

  • If a Jira is specific to a single module, the responsible team's PO will request CSP approval

  • If the Jira is cross-cutting/affects multiple modules, the Security Team will make the request (assuming it's security related!)

  @Denis Kovtun pulled together a document to help clarify this process and ensure everyone involved is aligned:

  Notes:

  • Overall the team agrees to this process.  

  • @Craig McNally to clarify with Denis whether or not it's acceptable to use existing JIRAs, or if we need to create dedicated ones per:

  • @Craig McNally clarified this point with Denis and it's acceptable to repurpose the Jira, or create additional jiras as needed, keeping the oringal one as an umbrella.  This is essentially what we're already doing, so no changes are required on our side.

25-30 min

Anything Urgent? Review the Kanban board?

Team

• MODGQL-175: 

  • Update from @John Coburn

    • Moving babel to a dev-dep did not work

    • Mike T. has suggested other approaches to address this.  The ball is in his hands.

      • Maybe just removing babel altogether...

    • It doesn't appear that there's been any progress on this recently.

• Need to follow up with @Peter Murray wrt security levels... it seems we're unable to change this, which is a problem

  • https://folio-org.atlassian.net/browse/SECURITY-49

  • https://folio-org.atlassian.net/browse/SECURITY-67

  • https://folio-org.atlassian.net/browse/SECURITY-86

  • https://folio-org.atlassian.net/browse/SECURITY-14

• @Craig McNally followed up with Peter and this is now sorted out.  We should be able to adjust security levels just like were could prior to the move to Atlassian cloud.  The issues above have been adjusted.

• Our kanban board has a swimlane for "no team assigned".  There's only one Jira there which is essentially a test issue.  I don't see an option for setting the development team on that particular issue.  We need someone to investigate.

Time permitting

Advice for handling of sensitive banking information

Team

From slack conversation, I think I've gathered the following:

• In this case (bank account and transit numbers), the information is highly sensitive.  

• Highly sensitive information should:

  • Be stored in it's own table

  • Accessed via a dedicated API

  • Protected by a dedicated permission

  • Encrypted in the database, not only on disk.  

    • This could mean either:

      • Explicitly encrypting/decrypting in the application layer and storing the encrypted data in postgres

      • Utilizing postgres extensions/modules to encypt certain columns, e.g. via pgcrypto (see https://www.postgresql.org/docs/current/encryption-options.html)

Let's review and discuss before providing this feedback to Raman.

@Axel Dörrer also suggested that defining classes of sensitivity could help teams determine which techniques are applicable in various situations.  I agree having some general guidelines on this would be helpful.

• regular data

• low sensitive - permission based on same API

• high sensitive - permission based on dedicated API

It would probably help to provide concrete examples of data in each class.  This can be a longer term effort, we don't need to sort out all the details today.

• Next Steps:

  • Clearly define/formalize the various classes

    • Come up with concrete examples of each class

  • Build out guidance

    • Come up with concrete examples of how to protect each class of data.

  • Consider storing some classes of data outside of postgres altogether - e.g. in secret storage.

    • What would be the guidance we provide to teams for this so we don't end up with each team doing things differently?

    • SecretStore interface and existing implementations are currently only read-only.  They would need to be extended to allow for creation/mgmt of this information.

  • Craig to start a conversation in slack about this.

    • Seeking a volunteer to generate a draft document for us to review at a later meeting.

Today:

@Axel Dörrer to do a first draft as a base for further discussions

Status on pentesting works within Network traffic control group

@Axel Dörrer 

Due to some absences on different reasons the group stalled. Axel will try to reactivate the group.