2022-10-13 Meeting notes

Owned by Craig McNally
Last updated: Mar 23, 2023

Date

Attendees

NamePresent

Craig McNally 

Y
Julian Ladisch 
Y

Axel Dörrer 

N
Ryan Berger 
Y

Chris Rutledge 

Y

Jakub Skoczen 

Y
John Coburn 

Skott Klebe 




Discussion items

TimeItemWhoNotes
0 minmod-configuration - should it be deprecated or not?Julian Ladisch 

mod-configuration has been discussed on the development channel recently. Developers like it because they can simply drop variables to the /configurations/entries API. Simply use the "configuration.*" permission shared by all modules and you are done. No need to add schema validation, no need to add dedicated permissions, no need to add a dedicated API.
Drawbacks:

  • A big institution need config write permissions with module granularity. One member of staff may be allowed to edit circulation config but not acquisition config.
  • No validation. mod-configuration cannot validate a POST or PUT request because it doesn't know. Only the module it belong to knows this. Relevant use case: Using curl/wget/postman/...
  • No documentation. mod-configuration has no documentation, one needs to search, maybe the module's README has some? A dedicated module API always publishes the API documentation at https://dev.folio.org/reference/api/
  • Performance. Requests to mod-configuration result in latency. If the config API belongs to the module the module can cache it and can invalidate the cache if the config is changed. Caching requests to mod-configuration will always result in a time period with outdated values. In mod-inventory-storage we've combined fetching the HRID config and HRID generation into a single SQL query.
  • Coupling. Modules should be loosely coupled and therefore each module should store its own configs.


It was requested that a formal RFC/Architecture Decision Record been created if mod-configuration should no longer been used for module-specific configurations.

Team decided we want to have this as a RFC. Target should be to have this implemented within Nolana. Could discuss in your meetings while the RFC process moves on.

Today:

  • Deferred - no significant progress at this time.
0 minKafka security Team

The topic of Kafka security was raised as part of a conversation at the TC yesterday.  

The Security Team should be aware of this and probably should weigh in on the topic, or even generate proposals if we have ideas for how to solve the problem.

Today:

  • On hold until the RFC is available for review.
5-10 minOWASPTeam
  • Epic: FOLIO-3582 OWASP checks, reviews, and fitness functions 
  • Feature: FOLIO-3583 OWASP Zed Attack Proxy (ZAP)
  • User Story: FOLIO-3584 SPIKE - investigate OWASP Zed Attack Proxy (ZAP)

Today:

  • Progress on FOLIO-3584?
    • Skott ran a scan against MG Bugfest
    • Skott Klebe  and Craig McNally to review results... weed out false positives, then bring results to next week's meeting.
    • Scan stopped at 95% (OOM issue in Firefox)
  • Any other features/stories we want to create?
    • Not related to OWASP, but I think Skott Klebe suggested that our SNYK could be tuned/adjusted to better suit our needs.
    • Maybe make the Epic more generic – "Security Fitness Functions" or Create another epic to track the non-OWASP stuff?
  • SNYK
    • Should define JIRAs
      • Spike to investigate how we can tune snyk to better suit our needs – Craig McNally  to create this.
    • Provided some background/history about SNYK in the FOLIO community
    • Stripes architecture reviews dependencies every other flower release (1-2x/year)
    • Currently only looking at platform level (with package.json/lock files)
      • Avoids a lot of the dev/peer dependency false alarms
0 minCumulative upload problemTeam
  • Regarding file upload size issues (See FOLIO-3317 - Spike - investigate possible file upload vulnerability OPEN ), let's brainstorm ideas for mitigating the cumulative upload problem, not just the large file upload size problem.  
    • Some APIs are more vulnerable to this than others, such as those not protected by permissions - e.g. mod-login, edge APIs, etc.
  • Axel provided some background/context.  We still need to give this some thought and possibly suggest a solution
  • Use case 1: Some script unintentionally sends endless data to some API. This is caught by a maximum upload size.
  • Use case 2: Denial of service. Difficult to address in Okapi. Might be better handled in other tools like nginx or firewalls that can limit requests. Unlikely that a denial of service attack has a valid login / access token.
  • TODO: For use case 2: Only add documentation that implementers should use an external firewall (or external nginx) to limit requests.
  • Some investigation is required, let's capture this in a spike (JIRA).  
    • Axel Dörrer to help define this.  – Started, not finished yet.
    • We can review together and find someone to work on this... maybe have a champion on this team work with someone in the Sys-ops SIG/community.

Today:

5 minSTCOR-395 "refactor login form to avoid using any form framework whatsoever"

Julian Ladisch / Ryan Berger / John Coburn 

  • Create a spike to investigate what's involved in divorcing the login page from the NPM ecosystem.  Will reach out to John and Ryan as needed. 
  • Reopen STCOR-395 and block on the spike. – Done.

Today:

  • Where does this stand?  Get an update from Ryan Berger / John Coburn
  • Waiting for the spike ( STCOR-651 - Getting issue details... STATUS ) to be completed. – currently in the Open state.
  • John to reach out to Skott to discuss what the level of risk associated with this.  – Still needs to happen.
5 minSpring versions and the Official Supported Technologies pages

Julian Ladisch / Craig McNally 

Julian Ladisch  3:51 AM

I've added versions for the Spring components to the Officially Supported Technologies list.  For Orchid it's easy: https://folio-org.atlassian.net/wiki/display/TC/OrchidFor Nolana it's more complicated: https://folio-org.atlassian.net/wiki/display/TC/NolanaThe OSS support of several Spring components ends in May 2023. This is more than three months before the end of the Nolana support period that end in August or September 2023. The next minor version of those Spring components will be released in November 2022, this is during Nolana bug fest. We need to bump to this next minor version and release a bug fix for all affected FOLIO Spring libraries and FOLIO modules in November 2022.Running unsupported Spring components is a security risk.  If there is a security issue in a supported Spring component we simply can bump the patch version, no risk.  If there is a security issue in an unsupported Spring component we don't get notified because it's unsupported, and if we know of an issue we need to bump the minor version, this comes with some risk. Bumping the minor version as early as possible gives more testing time and is less risky.  We can discuss this today.

  • How do we want to approach this?

    • Consult the Spring Force team... Is this feasible?  Do you have better suggestions?

      • Craig McNally  to post in #folio-spring-base, at-mentioning Petrenko.

  • How do we communicate this out?  

    • Coordinate with the release manager (Oleksii Petrenko)

  • How much work is expected to be required?

  • Craig McNally  to follow up with Oleksii P. again to see if the team has discussed this yet.

  • Met with Oleksii P. and Spring-force.  They're onboard with this proposal and will take it from here.

  • There are complications with this... conversations in #folio-spring-base:

    • For details see Nolana#Frameworks.1

    • Spring Boot 2.7 has extended OSS support until 2023-11-18, this completely covers the Nolana support period (~ August 2023), no need to switch to Spring Boot 3, but see below

    • However, folio-spring-base also uses Spring Cloud, and other Spring way modules also use other Spring components without extended OSS support

    • Spring Cloud 3.1 support ends 2023-05-18, this is at least three months before the end of the Nolana support period around August 2023.

    • Spring Cloud 4.0 GA release will be in November 2022.

    • Spring Force team has agreed that Milestone versions can be used. These need to be replaced by the GA version. Nolana GA release will be in December 2022.

    • Only recently (2022-10-04) Spring Force noticed that Spring Cloud 4 requires Java 17 and only (officially) supports Spring Boot 3.

  • Also introduced the topic at the Technical Council meeting yesterday but ran out of time.  The TC will discuss more in slack and if necessary at next week's TC meeting.

Today:

  • Update from Julian Ladisch / Craig McNally...  Summary:

  • Last week it was decided that the Spring Upgrade (Spring Boot from 2.7 to 3, Spring Cloud from 3.1 to 4) and the Java Upgrade from 11 to 17 is postponed to Orchid; and:

Two options that need to be discussed in January 2023

  • Limit support of Nolana release up to May 2023

  • Backport of Orchid spring-based changes to Nolana HF
5 minCore-platform auth work

Jakub Skoczen / Skott Klebe 

  • Skott to needs to meet with Steve E. / Vince B. 
  • Also review the associated PRs (links to these are in the JIRAs)
  • Some potential concerns:
    • Having multiple authentication/login APIs... is this strategy how we want to roll this out?
    • Introduce the new API, deprecate the older one.
      • Have both co-exist for a single release cycle to allow for transition to the new API.
    • Does this increase our attack surface area?
    • Another option:  rip the band-aid off... break the existing API and force everyone to switch to the new API in a single release cycle
      • Con: Less time for transition
      • Pro: there's only a single login API in any given release
  • Skott would like an option to switch off the old API on a per tenant basis for institutions that have completed the migration to the new API. 

Today:

  • Update from Skott Klebe on the status of his findings/report

*

Review the Kanban board. Team

Last Week:

  • Ryan Berger to create tickets for modules that still use react-hot-loader 
  • According to the PO (Magda Z.), mod-data-export-spring-migration is temporary/a placholder.  We don't need a separate JIRA project for it.  My understanding is that the migration from RMB → Spring Way will eventually make its way into mod-data-export and mod-data-export-worker, which both already have their own JIRA projects.

Today:

  • TODO:  We need to define JIRAs for the modules that are still vulnerable to the Spring4Shell vulnerability.  See the umbrella here:   FOLIO-3466 - Getting issue details... STATUS .  A comment has been left indicating which modules are still vulnerable.
    • TODO:  Craig and Julian to split up this work (divide and conquer)

Action items

  • Craig McNally to create a spike in JIRA for investigating how to fine tune Snyk to better suit our needs
  • ________________ to create JIRAs for modules still vulnerable to Spring4Shell.  See   FOLIO-3466 - Getting issue details... STATUS .  A comment has been left indicating which modules are still vulnerable.