Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Issues

Select view

Select search mode

 
50 of 65

Entering or changing the search term clears filters

Done

Description

This is happened since the switch to react-router v4.0 (STRIPES-173: Compatibility with current react-router versionsClosed).

It happens in both ui-users and ui-items.

The filters still appear checked in the UI, but do not contribute to the CQL query that is generated.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created March 17, 2017 at 11:44 AM
Updated March 17, 2017 at 12:50 PM
Resolved March 17, 2017 at 12:50 PM

Activity

Show:

Mike TaylorMarch 17, 2017 at 12:50 PM

Updated ui-users and ui-items to require v0.3 of stripes-components.

Mike TaylorMarch 17, 2017 at 12:48 PM

Mike TaylorMarch 17, 2017 at 12:37 PM

Right. The problem is in line 3 of transitionToParams.js:

const allParams = Object.assign({}, location.query, params);

Under react-router 4.0, location.query is undefined; but Object.assign() doesn't complain about that, as one might expect, it simply ploughs on.

js> Object.assign({}, undefined, { foo:1 }) Object {foo: 1}

It should be easy enough to fix.

Mike TaylorMarch 17, 2017 at 12:26 PM
Edited

Those diffs look fine. I think the problem is, rather, that the transitionToParams utility function silently fails to recover the other parts of the query string, rather than either finding them or blowing up because they're not there.

Mike TaylorMarch 17, 2017 at 12:04 PM

The problem is presumably within this sequence of the three commits that Jason made last night:
https://github.com/folio-org/ui-users/compare/6f535f91530e4b2d8343d71a705824777a7e9480...88f8b9350a71e881197dd3b600122bb0811fc318

TestRail: Cases
TestRail: Runs

Flag notifications