Description
CSP Request Details
CSP Rejection Details
Potential Workaround
relates to
Checklist
hideTestRail: Results
Activity
Hongwei Ji October 19, 2020 at 12:51 PM
@Jag Goraya, looks good. Thanks.
Jag Goraya October 19, 2020 at 10:52 AM
@Hongwei Ji changes for this have been made ... can you confirm it does as expected now please? It can be tested on folio-snapshot. Thx
Owen Stephens October 7, 2020 at 4:14 PM
Thanks @Hongwei Ji
Hongwei Ji October 7, 2020 at 3:45 PM
We saw the permission errors in mod-authtoken logs. The reason it breaks is that when a perm set in module descriptor uses an "undefined" perm, for example https://github.com/folio-org/mod-agreements/blob/v2.3.0/service/src/main/okapi/ModuleDescriptor-template.json#L458-L461. Any API that is protected by that "undefined" perm, for example https://github.com/folio-org/mod-agreements/blob/v2.3.0/service/src/main/okapi/ModuleDescriptor-template.json#L167-L170 will not be accessible even if you give user the perm set. Why? mod-authtoken calls mod-permissions to expand perms for that perm set, and mod-permssions will not return that "undefined" perm because it is a dummy permission. Hope this helps.
Owen Stephens October 7, 2020 at 3:02 PM
@Hongwei Ji can you expand on why this is important to you? We only currently list the permissions which we need to for the module to work as intended. As far as we know (potentially with the exception of https://folio-org.atlassian.net/browse/ERM-1079#icft=ERM-1079 mentioned by @Ethan Freestone above) there is no problem with how permissions work for mod-agreements.
Can you expand on your use case and what problem you are trying to solve?
Something went wrong on our end
If this keeps happening, share this information with your admin, who should contact support.
Hash LVERXE
Trace 0ac8d3b900e44cb98d13ca8f5651eaff
Details
Details
Assignee
Reporter
Components
Priority
Overview:
Some permissions are not defined in module descriptor. For example erm.jobs.collection.get, and erm.refdata.collection.get. Those perms are used as part of subpermissions but not defined in module descriptor. Also searching those perms using permissions API won't return results.
Steps to Reproduce:
Try search /perms/permissions?query=(permissionName=="erm.jobs.collection.get")
See module descriptor https://github.com/folio-org/mod-agreements/blob/v2.3.0/service/src/main/okapi/ModuleDescriptor-template.json#L460
Expected Results:
Those perms should be defined in module descriptor
Actual Results:
They are not.