Rationalise distribution of View/Edit/New code
Description
Environment
Potential Workaround
blocks
Checklist
hideTestRail: Results
Activity
Mike Taylor November 22, 2017 at 2:38 PM
Finally fixed in https://github.com/folio-org/ui-users/pull/151
Mike Taylor November 22, 2017 at 11:26 AM
Having give quite some thought to the best way of decomposing the create function in Users.js into a generic portion and a users-specific portion, I've come to the conclusion that this won't even arise if the day ever arrives that we fix mod-users-bl to do user creation in a single shot (see ). So rather than pour yet more time into working around that same lack, I'm going to simply have <SearchAndSort> client components redundantly supply a trivial `create` function of their own; or perhaps supply a default one which can be overridden.
Mike Taylor November 10, 2017 at 12:09 PM
I think only two things remain to be done after this:
Have
<SearchAndSort>provide the close-full-record action for the view-component.Have
<SearchAndSort>provide the generic part of record-creation, calling back to the invoker only for the additional operations that ui-users needs;
Mike Taylor November 8, 2017 at 6:40 PM
Upper to P2, since this one is now at the top of a long dependency chain.
Mike Taylor November 8, 2017 at 6:35 PM
New order of issues: , and , . I will re-plumb the inter-issue dependency links accordingly.
As things stand, the responsibility for viewing full records, editing them and creating new ones is distributed rather haphazardly between
<SearchAndSort>and some other components that are specific to ui-users. We'd like to treat all three operations in as uniform a way as possible, and to draw as much non-user-specific code as we can from all three of those operations into<SearchAndSort>(or other components that are part of the same re-usable library).