Regression: newly created users can't be used
Description
CSP Request Details
CSP Rejection Details
Potential Workaround
blocks
relates to
Checklist
hideTestRail: Results
Activity
Mike Taylor November 21, 2017 at 2:34 PM
I now understand (I think) the distinction between this issue and . I thought what I was seeing was that when creating a new user, the credentials were not getting set correctly – which is why I filed this bug. But I now think that my reason for thinking that was that it wasn't possible to login as such newly created users.
When I traced through the code carefully, I found that in fact the correct username/password pair was indeed being posted – which is why I said "Well, except this now works for me". But that doesn't make the users login-as-able.
Conclusion: there is some other issue with login, which I will pursue separately in . This one, meanwhile, can be closed as INVALID.
Charles Ledvina November 17, 2017 at 10:20 PM
I'm guessing that your changes haven't made it to http://folio-testing.aws.indexdata.com/.
Mike Taylor November 17, 2017 at 10:10 PM
Well, except this now works for me.
If it's not working for you, it might be that the changed new-user form is not getting filled in right.
Charles Ledvina November 17, 2017 at 10:08 PM
I guess this explains why the new_user test has been failing today. I won't file a separate "Can't login with new user's credential" bug.
Mike Taylor November 17, 2017 at 1:52 PM
Well, I don't know how to progress this.
Problems in this area are greatly exacerbated by the way all exceptions in the form handlers are discarded – see STRIPES-483. Basically, whenever anything goes wrong, it's diagnosed by nothing at all happening. That may be somehow implicated here. I first ran into user-creation problems when creation silently failed, as though I'd never pressed the "Create User" button at all. That turned out to be because I had not filled in a password (an easy mistake to make now the form has been rearranged to separate username from password).
I wonder whether it's pointless trying to do anything much in the area of the edit-form until STRIPES-483 is fixed. The dark side clouds everything. http://cdn-webimages.wimages.net/051adce3cee4bf667583ac1830e3a7672fc18a-wm.jpg?v=3
When you create a new user, you are no longer able to login as that user. What happens is that the credentials record that's generated has the password hash and salt, but not the username – so the subsequent login operation can't find a match for the username/password.
I think this most likely arises from changes in the structure of the new/edit user form (UIU-282), causing the
userdataobject that gets passed to thecreatefunction in Users.js to have a slightly different structure.I'll look into this. (I can't really push on with the UIU-303 work until it's resolved.)