Done
Details
Assignee
John CoburnJohn CoburnReporter
Cate BoeremaCate Boerema(Deactivated)Labels
Priority
P2Sprint
NoneDevelopment Team
Stripes ForceTestRail: Cases
Open TestRail: CasesTestRail: Runs
Open TestRail: Runs
Details
Details
Assignee
John Coburn
John CoburnReporter
Cate Boerema
Cate Boerema(Deactivated)Labels
Priority
Sprint
None
Development Team
Stripes Force
TestRail: Cases
Open TestRail: Cases
TestRail: Runs
Open TestRail: Runs
Created September 23, 2019 at 11:36 AM
Updated December 16, 2019 at 2:22 AM
Resolved October 17, 2019 at 10:22 PM
Steps to repro:
Screencast: https://www.screencast.com/t/1y1Hd92TqJ
Log into folio-snapshot
Create a fixed due date schedule (Settings > Circulation > Fixed due date)
Create one row with from of Sept 1, 2019 to October, 31 19 and due date Nov 5, 2019
Create another row with from of November 1, 2019 to December 31, 2019 and due date January 5, 2020
This should be totally valid
Save the new fixed due date schedule
Expected:
Should save without validation error
Might as well also fix these while in here:
New row shouldn't be populated with "invalid date"
Save button should just say "Save" instead of "Create schedule" or "Save schedule", which is what is currently says on the create and edit pages respectively CB: I'm now confused about what this should actually say. Users says "Save and close".
Probably also should fix while in here CB: Not done but this is covered in separate issue
We should have some unit tests on this page, as these are all regressions CB: Did we get some unit tests on this ?
Clicking the calendar icon should open the calendar on first click (right now you need to click twice see: https://www.screencast.com/t/1knrNHky) CB: Not done but this is covered in separate issue STCOM-604
Actual: Throws validation error on first row saying the data is missing or invalid which it isn't. If you just re-select the same data and save again, it will save successfully. Note, this happens every time you want to save an edit to this save FDDS.
Now edit the FDDS again and add another valid row. Attempt save.
Again you will be told that row one isn't valid for the reasons stated above
Again, if you just re-pick the same values, it will stop telling you that
Now attempt save
Expected: Should save without error
Actual: Preventing save and saying "Date range 1 cannot overlap with date range 2" which is totally not happening See below screenshot. This is a completely valid FDDS. None of the date ranges (from - to dates) overlap at all.
Additional information: If you add all 3 rows during FDDS creation, you can manage to save them. But if you add just two and try to add another after the initial save, you won't be able to because of this "Date range 1 cannot overlap with date range 2" error.