Block Renewal With Pending Hold Request
Description
Environment
Potential Workaround
Attachments
defines
has to be done after
has to be finished together with
is blocked by
Checklist
hideTestRail: Results
Activity

Cate Boerema September 24, 2019 at 9:34 AM
This works as specified. Thanks !

Cate Boerema September 24, 2019 at 9:28 AM
Putting this back In review because and I decided it was best to add new stories for the work to calculate the renewal period when the "Alternate loan period at renewal for items with an active, pending hold request" - from Holds section is blank.

Bohdan Suprun September 23, 2019 at 12:51 PM
Hi ,
Yes, this is an issue. As far as I see, we use period from holds only for renewal with hold requests.
Am I correct understand that there is following priority of periods for renewal with holds:
"Alternate loan period at renewal for items with an active, pending hold request" - from Holds section;
"Alternate loan period for renewals" - from Renewals section;
"Loan period" - from Loans section.
So, we should chose the first which specified, right?
Thanks,
Bohdan

Cate Boerema September 23, 2019 at 11:51 AM
Blocked from testing the fixed due date scenario due to UICIRC-338

Cate Boerema September 23, 2019 at 11:20 AM
Hi Bohdan. This is looking good so far. I was able to verify that, for rolling loans, having the "Allow renewal of items with an active, pending hold request" checkbox unchecked did prevent renewals of items when there was an active, pending hold request. I still need to test the fixed loan profile scenario.
I did notice one thing, though.
I checked the "Allow renewal of items with an active, pending hold request" box and re-tested, just to make sure that was working. My expectation was that the renewal would be allowed and the renewal period would be 90 days because that is the default renewal period which should apply unless an alternate has been specified under Renewals (Alternate loan period for renewals) or under Holds (Alternate loan period at renewal for items with an active, pending hold request). Since both of those were blank in my loan policy, I was expecting to get a 90 day renewal period. Instead, I got this message:
Do you think this was a preexisting issue?
Details
Assignee
Bohdan SuprunBohdan Suprun(Deactivated)Reporter
sthomassthomas(Deactivated)Tester Assignee
Cate BoeremaCate Boerema(Deactivated)Priority
P2Story Points
8Sprint
NoneDevelopment Team
ProkopovychFix versions
TestRail: Cases
Open TestRail: CasesTestRail: Runs
Open TestRail: Runs
Details
Details
Assignee

Reporter

Tester Assignee

Purpose: The purpose of this story is to block renewal on loans that have an active, pending hold request on the loaned item (at the top of the request queue).
1. Scenario (Renewal not allowed)
When Renewing Loan L from the User Loans or User Loan Details pages
At renewal:
Given item barcode, which has:
Request queue = n (not 0)
Then if for request in position 1:
Type = Hold
Request Status = Open - not yet filled
AND Given loan Policy X, where:
Loanable = Y
Loan profile = Rolling OR Fixed
Allow renewal of items with an active, pending hold request = <null> (not selected) or false
Renewal is disallowed
A modal popup should display reading:
Header: Loan not renewed
Body: Items with this loan policy cannot be renewed when there is an active, pending hold request