Choose request level and request type when creating a request

Description

Overview:  Some changes need to be made in mod-circulation after the recently discovered requirement for mod-patron to create TLRs if the feature is enabled. mod-circulation needs to decide which request level and request type to create. 

Requirements:

Adapt POST /circulation/requests/instances endpoint to create TLR when requested from mod-patron if TLR feature is enabled.  

Approach:

If the TLR feature is enabled, we skip the old item ranking logic in the /circulation/requests/instances endpoint and create TLRs of different request types. Otherwise, we follow the old flow. 

Acceptance criteria: 

POST /circulation/requests/instances endpoint produces TLRs when the feature is enabled.

Interested parties:

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Brooks TravisApril 7, 2022 at 6:03 AM

Ok. I've tested this coming in via the edge API, and the level seems to be correct, but it doesn't seem to be respecting request policy at the item level, so the type is wrong (but in-line with https://folio-org.atlassian.net/browse/CIRC-1455#icft=CIRC-1455). One of my attempts should have place a title-level hold, even though there was an available item, because according to the applicable request policy for the item/patron combination, that item was "hold-only". The fix for that is, apparently, awaiting work for https://folio-org.atlassian.net/browse/CIRC-1479#icft=CIRC-1479, which is still in-progress. I just wanted to make sure that was noted. Going to mark as done.

Stephanie BuckApril 4, 2022 at 2:15 PM

Thanks, Oleksandr. I've moved https://folio-org.atlassian.net/browse/CIRC-1455#icft=CIRC-1455 to lotus bug fix release so we can test both request type and request level. 

 

Oleksandr VidinieievApril 4, 2022 at 9:30 AM

this ticket does not really fix anything, it's an implementation of a feature. And it does decide request of which type to create (although I did miss this validation which is fixed in https://folio-org.atlassian.net/browse/CIRC-1455#icft=CIRC-1455). So I think the description is still valid. I linked the two tickets together.

Stephanie BuckApril 2, 2022 at 2:23 PM

Thanks, . That's interesting. I'm not sure what to do with https://folio-org.atlassian.net/browse/CIRC-1455#icft=CIRC-1455 right now, but this ticket describes fixing both title level and request type. We should update this ticket and maybe link it to https://folio-org.atlassian.net/browse/CIRC-1455#icft=CIRC-1455 in the meantime. 

Oleksandr VidinieievApril 2, 2022 at 11:25 AM

this issue was fixed in https://folio-org.atlassian.net/browse/CIRC-1455#icft=CIRC-1455 which is R2. Should we release it as R1 Bugfix?

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

Release

Lotus (R1 2022) Bug Fix

RCA Group

Incomplete/missing requirements

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 14, 2022 at 12:09 PM
Updated June 28, 2022 at 11:59 AM
Resolved April 4, 2022 at 12:36 PM
TestRail: Cases
TestRail: Runs

Flag notifications