Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Do not allow Hold TLRs for instance with available items

Description

Currently it is possible to create a title-level hold request via API for an instance which has items in status "Available". We should only allow page requests in this case. UI picks the request type correctly, but backend has no such validation.

 

Hint for dev: see CreateRequestService#checkItem.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Stephanie Buck April 7, 2022 at 11:48 AM

 - thank you!

Brooks Travis April 7, 2022 at 6:05 AM

Ok. I've tested this coming in via the edge API, and it appears to be working as-described, but see my previous comment here, regarding respecting request policy. One of my attempts should have place a title-level hold, even though there was an available item, because according to the applicable request policy for the item/patron combination, that item was "hold-only". The fix for that is, apparently, awaiting work for , which is still in-progress. I just wanted to make sure that was noted. Going to mark as done.

Oleksandr Vidinieiev April 6, 2022 at 8:07 AM

Creation of TLRs disregards Request Policy at the moment. We plan to fix this in .

Brooks Travis April 5, 2022 at 5:14 PM
Edited

Just to clarify, a TLR hold should still occur on an instance with available items if none of the items are pageable (according to circulation rule/request policy) by the requesting patron.

Oleksii Petrenko April 5, 2022 at 8:55 AM

Deployed to Lotus BF. Please proceed with verification

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Vega

Parent

Fix versions

Release

Lotus (R1 2022) Bug Fix

RCA Group

Incomplete/missing requirements

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created March 4, 2022 at 1:58 PM
Updated July 13, 2022 at 9:38 AM
Resolved March 18, 2022 at 1:50 PM
TestRail: Cases
TestRail: Runs