Triage

• performance issues from inline edit, which can stop agreement loading

• Scenario 4:
  • same behind-the-scenes behaviour (with minimal details to create agreement), but without taking user out of context 
  • won't be using existing agreement form
• use query-parameter to not expand agreement lines in edit view (introduced in ERM-2888)
• remove call that renders cards
• implement basket changes
• leave in place the mechanism that allows us to add agreement lines
  • review for deprecation once replacement functionality is described

Components and Changes

• Frontend: ui-agreements

• Backend: none

Tests / Data / Dependencies

• related: ERM-2892
• update cypress test set up for ERM-2773

Known Unknowns: NA

QA: snapshot 

Development Estimate: 2d

Triage

• may be bypassing existing truncation (going via SQL rather than GORM)

• options
  • truncate title
    
    • should already be done with resource name field before it is validated/saved
  • set longer arbitrary length limit
    • previously rejected this 
• can this be replicated without gokb ingest (ie, with lkb-admin)? 
• if not, add logging, trigger harvest at updated cursor for reference
• try truncating after 

Components and Changes

• Frontend

• Backend

Tests / Data / Dependencies

Known Unknowns

QA: snapshot | local | testing | other

Development Estimate

Triage

Components and Changes

• Frontend

• Backend

Tests / Data / Dependencies

Known Unknowns

QA: snapshot | local | testing | other

Development Estimate

Approach

• add backend support for source values
• add (multi-)select to frontend 
• potential typedown candidate, but not for Poppy

Components and Changes

• Frontend: ui-agreements

• Backend: mod-agreements

Tests / Data / Dependencies: minor adjustments to jest and cypress expected

Known Unknowns: NA

QA: snapshot 

Development Estimate

• license, SI and plugins seem to function
• new issues arising with mod-agreements (liquibase, hibernate)
  
  • concern that they may have been missed previously

• inspect hibernate and liquibase versions for discrepancies

• handover to Steve this week

• Pending clarification from Gill

• implement as directed

• cannot test whether checkbox is checked
  • conditional (if...else) is unreliable with DOM re-drawing
  • instead, test declaratively rather than via DOM
    • set the data via api (in SKC)
    • check the checkbox has been (un)checked
    • save the checkbox state
• toast message
  • where is the component? callout  interactor
  • what is the text? 
• after file upload, cannot reload
  • use await or cypress wait until 
• can we delete a package via API?
  • no, no endpoint
  • this will restrict how much cleanup we can do
  • instead be careful about package names being re-used in tests
• cannot check if row is selected in basket
  • try mcl interactor with within  and checkbox within that

• update local system

• ERM-2916 mostly done

• ERM-2916 final 
• ERM-2917 not started