No dev action for now. May result in UI changes. 

Fallout from ERM-2314

Currently :

• Every single user has a default dashboard on first Dashboard access

Issue;

• Cannot rely on existing mydashboard  default
• Not all users will have a mydashboard 

TBD:

• Prompt to create a dashboard or assign an existing dashboard as default when accessing Dashboard app
• Owen to review desired behaviour

• Approach

  • keep flat route to support easy migration in future: no change except to where (not what) stuff is displayed
  • read header url
    • if in Agreements or Agreements Line > Agreement Search
    • if in eResources or LocalKB Search > eResource Search (defaulting as normal)
  • this also determines what the primary is

• Components and Changes

  • Frontend: ui-agreements

  • Backend

• Tests / Data / Dependencies / Known Unknowns: NA

• QA: snapshot

• Development Estimate: <1d

• Approach

  • normally happens when a field is missing the  name
  • possibly a KiwtFieldArray / finalForm issue
  • reproduce locally for better stacktrace
  • if not, check snapshot is up to date

• Components and Changes

  • Frontend: ui-erm-comparison, comparison.fieldArray

  • Backend: none

• Tests / Data: NA

• Dependencies: NA

• Known Unknowns

• QA: snapshot | local 

• Development Estimate: ??

• Approach

  • AL type options are not from the same field, but constructed, in a way that it could 

• Components and Changes

  • Frontend: ui-agreements, AgreementLineFilters (or one step above)

  • Backend: none

• Tests / Data

• Dependencies

• Known Unknowns

• QA: snapshot 

• Development Estimate: ??

• Approach

  • Filter is gone, but option is not cleared from display and not removable
  • Logic to display is separate to lookup logic
  • Throws up an issue with the 
  • Preferably clear if not set (ie if URL is clear).  If not, intercept Reset All and clear all. 
  • Need to check for looping behaviour

• Components and Changes

  • Frontend: 

  • Backend: none

• Tests / Data

• Dependencies

• Known Unknowns

• QA: snapshot | local | testing | other

• Development Estimate: ??

• Approach

• Components and Changes

  • Frontend: ui-agreements

  • Backend: none

• Tests / Data / Dependencies

• Known Unknowns

• QA: snapshot 

• Development Estimate

• Approach

  • query parameters will include sort
  • inspect query object handed by sasquery (or, preferably kiwt
  • if it includes filter/terms, enable initial query - add enabled prop to the useInfiniteFetch (or useBatchedFetch or useQuery) options parameter (in ALroute - see line 53-54) 
  • if not, do not enable infiniteFetch (enabled = filter settings; line 77)
  • when isIdle is returned from query, show the prompt to select a filter

• Components and Changes

  • Frontend: ui-agreements (agreementLineRoute)

  • Backend: none

• Tests / Data /

• Dependencies

• Known Unknowns

• QA: snapshot | local | testing | other

• Development Estimate

• Approach

  • Expected
    • if no other filters, should set to default filters
    • if default, clear filters
  • may be state-driven, in which case it needs to be url-driven
    • ie, remove custom logic
    • (search and sort query will handle defaults as expected)
  • Check impacts on other filters

• Components and Changes

  • Frontend: ui-agreements

  • Backend

• Tests / Data

• Dependencies

• Known Unknowns

• QA: snapshot | local | testing | other

• Development Estimate

• Approach

  • add to package schema
  • add fields to ingest 
  • update explicitly comment the behaviour /  business rule in the code
  • Add logic (if / elseif) inside adaptor

• Components and Changes

  • Frontend: none

  • Backend: mod-agreements (adaptor)

• Tests / Data: packageViewSpec.groovy 

  • add to existing JSON object
  • add new test for fields/filters (on Set) 
  • add new test for update

  Dependencies: ERM-2288none

• Dependencies:

  • requires ERM-2306

  • enables ERM-2308

• Known Unknowns:  none

• QA: snapshot

• Development Estimate: Monday== ERM-2311

• Approach

  • explicitly comment the behaviour /  business rule in the code
  • Add logic (if / elseif) inside adaptoradd new logic to packageIngestService lines 212-218
  • ensure save after block
  • use existing patterns for updating PTI

• Components and Changes

  • Frontend: none

  • Backend: mod-agreements (adaptor)packageIngestService 

• Tests / Data: nonepackage test data

• Dependencies: ERM-2306no

• Known Unknowns: none

• QA: snapshotsnapshot 

• Development Estimate: == ERM-2311

• Approach

  • explicitly comment the behaviour /  business rule in the code
  • Add logic (if / elseif) inside adaptor

• Components and Changes

  • Frontend: yes

  • Backend: none

• Tests / Data: none

• Dependencies:

  • ERM-2306

  • Gill to review frontend mockups based on ERM-2306 shape

• Known Unknowns: none

• QA: snapshot

• Development Estimate: == ERM-2311small

• Current State
  • some backend changes
• TODO
  • check validation pattern for multiple user use-case with Gill
  • tests
• Development Estimate: 2.5d

• Current State
  • Parking test centralisation until approach has been defined
  • sonarLint changes is resolved
  • stripes list / list-item interactors is not ready to use yet: 
• TODO
  • tests need to be done for ui-agreements,, using html interactor as workaround for list
    • nothing shows up
    • 1 thing shows up
    • multiple things show up
• Development Estimate: ?

Approach:

• Can mock pluggable to check if plugin shows up
• Check if card is displayed

• Approach

  • add to package schema
  • add fields to ingest 
  • update adaptor

• Components and Changes

  • Frontend: none

  • Backend: mod-agreements

• Tests / Data: packageViewSpec.groovy 

  • add to existing JSON object
  • add new test for fields/filters (on Set) 
  • add new test for update

• Dependencies: ERM-2288

• Known Unknowns: 

• QA: snapshot

• Development Estimate: Monday

• Approach

  • explicitly comment the behaviour /  business rule in the code
  • Add logic (if / elseif) inside adaptor

• Components and Changes

  • Frontend: yes

  • Backend: none

• Tests / Data: none

• Dependencies:

  • ERM-2306

  • Gill to review frontend mockups based on ERM-2306 shape

• Known Unknowns: 

  • properties are in json, but not in gokb (ERM-2307)
    • Owen to provide JSON file

• QA: snapshot

• Development Estimate: == ERM-2311

• Approach

  • add accordian to package filters (Availability Constraints)
  • show list similiar to Tags  / External Source Data
  • use multiselect rather than checkboxes doing lookup
    
    • no default to be set 
    • no lookahead for now
  • filter on selection
• Components and Changes

  • Frontend: ui-agreement

  • Backend: none

• Tests / Data:

  • if we already have existing filter tests

• Dependencies: ERM-2306

• Known Unknowns

• • list size may encourage select rather than checkboxes
    • confirmed: expecting to be in the order of 10s, rather than 100s
    • therefore use single call (as opposed to tags)

• QA: snapshot 

• Development Estimate: 1d

Pending Dependency: ERM-2316. 

Moved to Sprint 149 to coincide with ERM-2316

Will be significant QA / UAT effort

Usergroup discussion this week

Can QA with JSON and provide file for ERM-2308/ERM-2309

Can regression test, but not migration from one to another model 9which has been dev tested). 

• Approach

  • Owen to update issue
  • Delete dashboard: present warning
  • Scenario 5: show user access level

• Components and Changes

  • Frontend

  • Backend: 

• Tests / Data

  • No tests to be written

• Dependencies

  • Should amend the current behaviour to not create a new dashboard in the backend, so a user comes to a splash screen on first access
    • Ethan to stub an issue for Owen to review and prioritise after ERM-2314
    • Est: 0.5d to add a splash screen once 2314 is done

• Known Unknowns

  • How will the order weight interact? Requires API.

• • Routing in tab group is non-trivial 
  • Drag and drop accessibility (existing handle should be fine for tabbing), will need custom keyboard management

• QA: snapshot 

• Development Estimate: 5d

  • expecting to carry over into Sprint 149