MultiSelectionFilter's accordion IDs incorrectly use labels

Description

Checkbox filter-sections in MultiSelectionFilter appear to use a label prop to derive the id attribute of their section accordions. The label is a FormattedMessage, however, not a string, and this results in element IDs such as [object Object]-1.

For example, see the "Patron group" accordion of the main ui-users page.

Per
This bug appears because filterConfig, passed to SearchAndFilter component, provides <FormattedMessage /> as a label. As a solution we can replace FormattedMessage with translation keys and translate label before passing to SearchAndFilter component. This should be done in all UI modules that use filterConfig. Link to PR for ui-requests https://github.com/folio-org/ui-requests/pull/326

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Zak Burke May 5, 2020 at 5:46 PM

The problem code was refactored away at some point in the distant past.

Cate Boerema May 5, 2020 at 1:47 PM

I'm trying to close old bugs. Is this still relevant/worth keeping? If so, could it be classified as tech debt?

Done

Details

Assignee

Reporter

Priority

Development Team

Prokopovych

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created April 10, 2019 at 1:50 PM
Updated May 5, 2020 at 5:46 PM
Resolved May 5, 2020 at 5:46 PM
TestRail: Cases
TestRail: Runs