Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

MultiSelectionFilter's accordion IDs incorrectly use labels

Description

Checkbox filter-sections in MultiSelectionFilter appear to use a label prop to derive the id attribute of their section accordions. The label is a FormattedMessage, however, not a string, and this results in element IDs such as [object Object]-1.

For example, see the "Patron group" accordion of the main ui-users page.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Khalilah Gambrell April 10, 2019 at 1:49 PM

, and I plan to do what you suggested.

Zak Burke April 10, 2019 at 1:48 AM

That's a good explanation, , I see what you're saying. It sounds like we can close this ticket since there is no change to make in stripes-smart-components. Can you create tickets (or clone this one) in ui-users, ui-inventory, and ui-search?

And if you want to add ui-requests too, just for the satisfaction of immediately crossing it off, I would understand!

Yurii Danylenko April 9, 2019 at 9:54 AM
Edited

, this bug appears because filterConfig, passed to SearchAndFilter component, provides <FormattedMessage /> as a label. As a solution we can replace FormattedMessage with translation keys and translate label before passing to SearchAndFilter component. This should be done in all UI modules that use filterConfig. Link to PR for ui-requests https://github.com/folio-org/ui-requests/pull/326

Khalilah Gambrell April 2, 2019 at 12:35 PM

, , , and , adding to the backlog in case the team needs something else to pull into this sprint. Definitely lower priority to Notes and Date Range component.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created March 4, 2019 at 1:18 PM
Updated January 27, 2020 at 11:24 AM
Resolved April 11, 2019 at 10:37 PM
Configure
TestRail: Cases
TestRail: Runs