Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Switch Users app from props.data to props.resources

Description

To make it easier to move to the new metadata-augmented data, the STRIPES-111 work now calls it props.resources. The shape is a bit different but the salient bit is that props.data.foo is now at props.resources.foo.records.

Environment

None

Potential Workaround

None

Attachments

1
  • 17 Aug 2017, 11:40 AM

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte Whitt August 18, 2017 at 11:54 AM

Manual test in FOLIO test http://folio-testing.aws.indexdata.com/, version @folio/users 2.9.100469, using Chrome.

All looks good now in the Users app, so I'll close this issue as done.

Michal Kuklis August 17, 2017 at 12:57 PM
Edited

https://folio-org.atlassian.net/browse/UIU-187#icft=UIU-187 should be now fixed. It looks like currently when a new address is being added the address type has to be also selected. I think we will need to introduce a validation on the address component at some point.

Charlotte Whitt August 17, 2017 at 12:01 PM

Np , I'll do that.

Michal Kuklis August 17, 2017 at 11:56 AM

thank you for testing this. Please assign these new issues to me. I will take a look at them.

Charlotte Whitt August 17, 2017 at 11:38 AM
Edited

Manual test in FOLIO test http://folio-testing.aws.indexdata.com/, version @folio/users 2.9.100467, using Chrome.

The change from `props.data` to `props.resources` is documented in https://github.com/folio-org/ui-users/commit/07534425ca630d78d84b4ac2abf028ffac002edc

But when browsing around in the Users app, to test the overall functionality, then I discover that the User app is not fully functional, e.g. adding the address to an existing user is broken (see screen dump - I'll file a separate bug https://folio-org.atlassian.net/browse/UIU-188#icft=UIU-188), and also the bug reported earlier today about the 'Edit' button which does not work in the user details view, see https://folio-org.atlassian.net/browse/UIU-187#icft=UIU-187).

I can't tell if the errors I get has something with this change to do, but with a reasonable level of testing, I can't close this issue yet.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created July 15, 2017 at 1:00 AM
Updated August 18, 2017 at 11:56 AM
Resolved August 18, 2017 at 11:55 AM
Configure
TestRail: Cases
TestRail: Runs

Flag notifications