Edit button does not work in user details view

Description

Nothing happens in UI on clicking the Edit icon.

The problem seems to have been introduced with this commit:

https://github.com/folio-org/ui-users/commit/7b3741ff2f4a255669ba2f3695bd4958762bac22

The last working commit (https://github.com/folio-org/ui-users/commit/39cf8488d798921fec0fc2b5ee8c51f274290710) has another problem: The edit modal comes up, but you can't immediately close it (on the X in the upper left corner). This issue wasn't introduced with that commit, though, so would have to go further back in git history to pinpoint that.

Attaching screen shot with all versions in local test setup (only varied version of ui-users)

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte Whitt August 17, 2017 at 1:29 PM

Manual test in FOLIO test in http://folio-testing.aws.indexdata.com/ @folio/users 2.9.100468, using Chrome.

All looks good, and I'll close the issue.

Niels Erik Nielsen August 17, 2017 at 1:20 PM

Awesome. Thank you.

Michal Kuklis August 17, 2017 at 12:48 PM

It seems like closing the edit modal also works now.

Michal Kuklis August 17, 2017 at 12:28 PM

this should be now fixed. I will review the entire users app again though just to make sure I didn't introduce other issues.

Michal Kuklis August 17, 2017 at 12:07 PM

It appears that this is related to the work in .

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created August 17, 2017 at 10:24 AM
Updated August 17, 2017 at 1:29 PM
Resolved August 17, 2017 at 1:29 PM
TestRail: Cases
TestRail: Runs