Permission Set for Patron Group CRUD
Description
Environment
Potential Workaround
Attachments
- 18 Sep 2017, 07:22 PM
- 03 Aug 2017, 06:38 PM
- 03 Aug 2017, 06:37 PM
- 03 Aug 2017, 06:17 PM
- 21 Jul 2017, 03:57 PM
- 21 Jul 2017, 03:57 PM
- 21 Jul 2017, 03:57 PM
- 21 Jul 2017, 03:57 PM
- 20 Jul 2017, 10:18 PM
- 20 Jul 2017, 01:31 PM
is blocked by
is cloned by
Checklist
hideTestRail: Results
Activity
Cate Boerema October 6, 2017 at 5:16 PM
Just tested and all is good! Closing!
Mike Taylor October 6, 2017 at 4:42 PM
Looks like I merged this yesterday after someone else did the pointless review. I checked on folio-testing, making a new user "fiona", password "fiona", whose only permission is "Settings (Users): Can create, edit and remove patron groups". Sure enough, when you login as fiona, you can see no applications, only settings; and within settings, the only group is Users; and within Users, the only available page is Patron Groups. So I think we are finally done here.
Charlotte Whitt October 2, 2017 at 10:54 AMEdited
@Jason Skomorowski - today FOLIO testing is up and running; therefor it would be awesome if you could find time to review @Mike Taylor's change, so I can follow up, do test and we can close this jira. Thanks
Mike Taylor September 29, 2017 at 10:35 PM
I fixed this, but we won't see the effect until Jason (or someone) reviews the two-line change.
https://github.com/folio-org/ui-users/pull/69
Mike Taylor September 29, 2017 at 10:20 PM
Seems the mistake here is that the settings page is checking for the old permission-name but the new one is being assigned. I've not been seeing this on local builds because (I think) I was until recently running an older VM that only knew about the older permission name.
Now we have a new ui-users module descriptor on the back-end, only the new form of the permission is visible. I did this the wrong way around.
At this point, things simplify. Since the new set of permissions is now deployed in the back-end, it suffices to change the front-end code to rely on them. I'll do that.
Purpose: To create a logical permission set for Patron Group CRUD
Scenarios:
Scenario :check_mark:
Given the Users module
When enabled
Then a logical permission set should be provided called "Settings (Users): Can create, edit and remove patron groups"
Scenario
Given User A has been given the permission set "Settings (Users): Can create, edit and remove patron groups" and no other permissions
When User A accesses FOLIO
Then:
The Settings app should be visible in the top nav
Users should be the only visible category under App Setting in Settings
Patron groups should be the only visible category under Users
Patron group CRUD should be fully accessible to User A
Scenario
Given User A has been given the permission set "Settings (Users): Can create, edit and remove patron groups" as part of a custom permission set
When User A accesses FOLIO
Then they should have all rights normally conferred by this permission (see scenario 2) plus whatever additional rights conferred by their custom permission set.