Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Clicking Current App In Top Nav Shouldn't Trigger Unsaved Changes Modal

Description

Steps to repro:

  1. Log into folio-testing

  2. Go to Requests and create a new request

  3. Add some data and then, before saving the record, click on Requests in the top nav (not the icon on the left, but the one up in the app bar)

Expected: Unsaved changes modal should not display because clicking the current app doesn't navigate you anywhere.

Actual: Unsaved changes modal does pop-up. If you click Discard, it discards your changes and leaves you on the current page.

Additional info: This behavior is the same in other records (users, instances etc) and we want to fix this across the board.

Environment

None

Potential Workaround

None

relates to

Checklist

hide

TestRail: Results

Activity

Show:

William Welling January 17, 2018 at 8:16 PM

this was easier than expected. Merged into master. https://github.com/folio-org/stripes-form/pull/10

William Welling January 11, 2018 at 2:15 PM

Thanks. If ok, I will add you as a reviewer on the pull request when finished.

Filip Jakobsen January 11, 2018 at 2:12 PM
Edited

It's very important that the solution for this is that the currently open app's icon in the App Switcher does nothing when clicked. This should not result in selectively diabling select modals or anything else of that nature. The solution is to disable actions on the current app's icon. This might even be done by adding a disabled prop to the button — it shouldn't affect the styling.

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created January 11, 2018 at 1:25 PM
Updated January 17, 2018 at 8:16 PM
Resolved January 17, 2018 at 8:16 PM
Configure
TestRail: Cases
TestRail: Runs

Flag notifications