Update all client-side permission names to match new backend

Description

The UI module hasn't yet caught up to this week's set of permission names.

I have it on my TO DO list, but I'm reluctant to leap in and do this work while the permission names may still be moving – see the end of FOLIO-552.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor April 26, 2017 at 12:48 PM

Release 1.2.0 of ui-users is out! https://github.com/folio-org/ui-users/blob/v1.2.0/CHANGELOG.md

It should work correctly in tomorrow's daily build of the test-site.

Mike Taylor April 26, 2017 at 12:26 PM
Edited

I note that no users-bl permissions are involved any more. I think this is correct, and as it should be: all the facilities used by ui-users are provided by mod-users, not by the users business-logic module.

(In a saner world, of course, the Business Logic module would provide an all-in-one create-new-user API, controlled by a single permission users-bl.user-create, to which we would pass all the relevant information in a single shot. No doubt that will turn up in due course.)

Mike Taylor April 26, 2017 at 12:21 PM
Edited

As of commit https://github.com/folio-org/ui-users/commit/0b1f376f562d9120f1a4580459cf9e64328446b4, we are finally done (for now!) on this pestilential work. So picky, so error-prone, so awkward to test, and so dependent on the shifting sands of the back-end!

I will make a new ui-users release before closing the issue, but the actual work is done.

The following permissions are now checked in the UI Users module, and have been experimentally confirmed to match the checks done in the back-end:

  • users.item.post, login.item.post, perms.users.item.post – "New user" button

  • users.item.put – "Edit User" button

  • users.item.get – view user in right pane

  • circulation.loans.collection.get – display user loan history

  • perms.users.get – display user permissions

  • perms.users.item.post – add a permission to a user

  • perms.users.item.delete – delete a permission from a user

  • perms.permissions.get – see permission sets

  • perms.users.item.put – add permissions to, or remove them from, a permission set

The last of these should be perms.permissions.item.put, but the back-end checks the wrong permission. It will be corrected in a subsequent release, which will require that the Users UI module be changed again to match this.

(I thought the relevant permissions for adding permissions to, and deleting them from, a permission set were perms.permissions.item.post and perms.permissions.item.delete; but these are for creating and deleting whole permission sets.)

Mike Taylor April 26, 2017 at 10:10 AM

I think that the present git head of ui-users is now permission-compatible with folio-backend-auth v0.12.0.

Mike Taylor April 26, 2017 at 9:57 AM

Unbelievably, the permission names seem to have changed again in the newest folio-backend-auth.

I am testing and changing them all again.

Done

Details

Assignee

Reporter

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created April 19, 2017 at 12:20 PM
Updated April 26, 2017 at 4:57 PM
Resolved April 26, 2017 at 12:48 PM
TestRail: Cases
TestRail: Runs