Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Copy <EntrySelector> into stripes-components

Description

As noted in STRIPES-426, the way to get permission-set addressability is for me to copy the <EntrySelector> (currently part of ui-circulation settings' Loan Policies editor) into stripes-components. Once it's there, I can rewire the Loan Policies editor to use it; and once it's been released I can remove the local copy.

The point of all this is of course so I can go on to also use it in the Permission Set editor.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor October 13, 2017 at 4:47 PM

PR merged.

Mike Taylor October 13, 2017 at 2:49 PM

The new issue is STCON-42.

Meanwhile, I am continuing using the last good stripes-connect.

I have added the necessary files to stripes-connect: https://github.com/folio-org/stripes-components/pull/70/commits/dfaf39c6d8759815e968ea43d30a67693337414e
And they are blocked on https://github.com/folio-org/stripes-components/pull/70

Mike Taylor October 13, 2017 at 2:09 PM

git bisect shows that the first bad commit in stripes-connect is 583d3b08c408edeb505f43c0b023a692f0d236dc

Unfortunately, that is a vast commit – the elimination of redux-crud in favour of our own simpler and more flexible use of the Redux store: https://github.com/folio-org/stripes-connect/commit/583d3b08c408edeb505f43c0b023a692f0d236dc

I don't really know where to start with this, so I will file a new issue on poor .

Mike Taylor October 13, 2017 at 1:30 PM

Aha! Reverting to stripes-connect v2.7.0 fixes this problem, corroborating my sense that the problem is indeed in stripes-connect.

So what I have here is a problem completely orthogonal to my attempts to move <EntrySelector>.

Sigh.

I guess I'll file a new issue and look into it.

Mike Taylor October 13, 2017 at 12:03 PM

Upgrading to newest stripes-connect does not help. I will try backing it off to the most recent release.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 12, 2017 at 2:37 PM
Updated October 13, 2017 at 4:47 PM
Resolved October 13, 2017 at 4:47 PM
TestRail: Cases
TestRail: Runs