Something went wrong when we dumped redux-crud

Description

As documented in , commit 583d3b08c408edeb505f43c0b023a692f0d236dc broke somthing in the Settings --> Circulation --> Loan Policies page. Most obviously, the set of existing loan policies is not listed. Low-level logging shows that the records are being successfully extracted from the HTTP response, but something goes wrong between that point and when they are added into the data and resources objects.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor October 13, 2017 at 5:10 PM

Well, I burnt most of today figuring this out and working around the edges of it.

The moral seems to be: don't push the "get rid of data" change to stripes-connect master until after the things that use data have all been updated.

Mike Taylor October 13, 2017 at 5:06 PM

Yep, looking good.

Sheesh, what a waste of time this is turning out to have been.

Mike Taylor October 13, 2017 at 4:58 PM

Here's what happened. When I was trying to debug this problem (using the most recent stripes-connect), I looked at component state in the browser tools, and found that props.data and props.resources were both empty – so I assumed that switching from data to resources () wouldn't help.

In fact, though, I was only seeing the state during the initial render. In subsequent calls to the same render method, after the Okapi response has come in, resources is set – and data is not, due to its deliberate removal. (I could quibble and say that it should not have been removed until and all the similar tasks are complete, but let it pass.)

Anyway – it now looks like will solve this problem after all. I was going to take that issue and make the relevant changes, but it looks like Michal was ahead of me. I'll check how his changes work out for me, and then it may be that this can be closed.

Mike Taylor October 13, 2017 at 4:43 PM

I think this may have been an error on my part – hurrah if so!

More details if I turn out to be correct about that.

Mike Taylor October 13, 2017 at 2:27 PM

Assigned to since it's his commit and he might know what the problem is.

Moved directly into sprint24, since this is a pretty fundamental breakage.

Cannot Reproduce

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 13, 2017 at 2:27 PM
Updated October 13, 2017 at 5:10 PM
Resolved October 13, 2017 at 5:10 PM
TestRail: Cases
TestRail: Runs