Update open order logic with holding ids storing

CSP Request Details

None

CSP Rejection Details

None

CSP Approved

Description

Purpose/Overview:
In order to support

In the Acquisition accordion for the holding need to show order details information

Requirements/Scope:

Update open order logic with holding ids storing

 

Use Cases:

Background: User Open order and not package poLines 

1. Location of the POL should contain reference only on holding (holdingId)   

Given “Create inventory” for physical or electronic have “INSTANCE_HOLDING”  OR "INSTANCE_HOLDING_ITEM" 

When open Order

Then order workflow status is "Open"

    And Location element of the POL should contain only "holdingId"

 

2. Location of the POL should contain reference only on location (locationId)   

Given “Create inventory” for physical or electronic have “INSTANCE"  OR "NONE" 

When open Order

Then order workflow status is "Open"

    And Location element of the POL should contain only "locationId"

 

Approach:

org.folio.helper.PurchaseOrderHelper#openOrder

Acceptance criteria:

  • Logic updated

  • Unit tests

  • API Tests updated or created

Environment

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Siarhei Hrabko June 7, 2021 at 1:45 PM

Andrei Makaranka May 27, 2021 at 10:17 AM
Edited

Verified on Rancher via UI : 

Karate API tests : https://github.com/folio-org/folio-integration-tests/pull/151

Andrei Makaranka May 4, 2021 at 7:48 AM

 Thanks a lot.

Dennis Bridges May 3, 2021 at 6:24 PM

 I have created a diagram to help work through this logic. It covers how I believe we will need to maintain the links when different actions are taken on the order. It also covers creating pieces and receiving pieces.

Andrei Makaranka May 3, 2021 at 1:17 PM

Hi

My point of view on the feature:
It can add additional complexity to the processing logic, since we have no mechanism to distinguish a "Pending" order from an order that was "UnOpen". Now an "UnOpen" order is the same for us as a "Pending".
Also, in my understanding, when an order is "UnOpen", the order is actually unlinked from the holding ( if it was linked). And why it is more logical to replace the "holdingId" link with the permanent location link from the holding.

Technically after "UnOpen" operation we will get permanent location of the holding and put it instead of "holdingId"

Thanks  

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 7, 2021 at 1:16 PM
Updated June 1, 2022 at 11:29 AM
Resolved June 7, 2021 at 1:45 PM
TestRail: Cases
TestRail: Runs