Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Edit quantity when Order is re-opened

CSP Request Details

None

CSP Rejection Details

None

CSP Approved

Description

Overview
When a User wants to edit quantity on an Open order can be done in 2 ways:
1) Re-open Order(Orders goes from Open-> Pending -> Open)
2) Edit already Open Order

The scope of this story is just 1. Reopening order
When Order is re opened (Order moved from Open to Pending and then to Open), the user is allowed to edit quantity. When the order is re-opened after the edit,
For PUT Orders call, while RE-Opening an order

  • check if there are more pieces than required or the location has been modified, throw an error stating that pieces need to be deleted.

  • Leave the Order in pending state, if there are pieces to be deleted

When the extra pieces are to be deleted
DELETE /pieces call,

  • Delete the corresponding Item, if there are no requests on the item

    • throw an error if there is an open request, and do not delete the piece or item

  • If there are no items in the holding, delete the holding DB: holding may relate to other orders even if they have no items so deleting them is problematic and we will avoid it for now

  • Do not delete Instance

Acceptance Criteria

  • Both the API changes are made

  • API tests are updated

  • unit tests are updated

Environment

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Andrei Makaranka June 11, 2020 at 10:34 AM

Verified on snapshot

Andrei Makaranka May 27, 2020 at 11:27 AM

Case 2. Edit already Open Order will be done in scope of https://folio-org.atlassian.net/browse/MODORDERS-397

Dennis Bridges May 14, 2020 at 6:32 PM

great question. We actually NEVER want to delete the item if there is ANY type of request on it. This will force the user to delete the request before they are able to edit the order this way.

Viachaslau Khandramai May 14, 2020 at 9:01 AM

Hi ,

I have a couple of questions here.

1) Does OPEN request mean one of status:

2) What is an expected scenario for case: there are requests on item but there are NO open requests?

Thank you,
Slava

Dennis Bridges April 29, 2020 at 4:24 PM


1) we actually might create pieces for e-resources. It depends on the users "Create inventory" setting.
2) There is no business requirement to allow the same location multiple references on a single POL. The user should only have one ref to a specific location and possibly physical and/or electronic quantity for that location. IF there are multiple POLs on the PO then each POL could have the same location with different or similar quantities.

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Parent

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 15, 2019 at 9:51 PM
Updated July 31, 2020 at 11:48 AM
Resolved June 11, 2020 at 10:35 AM
TestRail: Cases
TestRail: Runs