Include requests in loan history
Description
Environment
Potential Workaround
blocks
is blocked by
Checklist
hideTestRail: Results
Activity
Marc Johnson October 20, 2017 at 2:02 PM
Have raised for stopping request type from being editable (and linked it to )
Cate Boerema October 20, 2017 at 8:21 AM
Thanks !
From it appears that request type is read-only (we don’t currently enforce this on the back-end, do we want to?)
Yes, I suppose we should be enforcing editability controls on the back end as well as the front end. Maybe you can write up a backend story for the work needed and link it to UIREQ-8?
I think all your scenarios look good for now!
Marc Johnson October 11, 2017 at 2:37 PMEdited
Hi
It is my understanding that we don’t restrict requests to only an item that is checked out / has an open loan (though this may be introduced in the future). At the moment, loan action history records are created via making a change to a loan. And there isn't a direct relationship between a request and loan.
What should happen if there is no current (open) loan for the item the request is for? For the time being I shall assume that no action is recorded (as we don’t have a place to record it).
Should any action be recorded when an existing request is changed? From it appears that request type is read-only (we don’t currently enforce this on the back-end, do we want to?) so, for the time being, I shall assume that no action is recorded for changes to requests.
Scenarios
Below are the scenarios I’ve been using for this issue, mostly for information, but if I’ve missed something, any feedback on them is appreciated (asterix suggests that the scenario is likely to change as the request lifecycle evolves).
Given a Checked out item and an Open loan, when a Hold request is created, update the loan (in order to create a loan action history record) with the action of and item status Checked out - Hold
Given a Checked out item and an Open loan, when a Recall request is created, update the loan (in order to create a loan action history record) with the action of and item status Checked out - Recall
Given a Checked out item and an Open loan, when a Page request is created, the loan is not updated*
Given a Closed and Open loan for the same item, when a Hold request is created, the Closed loan is not changed
Given a Closed and Open loan for the same item, when a Recall request is created, the Closed loan is not changed
Given an Open loan for a different item, when a Hold request is created, the Open loan for the other item is not changed
Given an Open loan for a different item, when a Recall request is created, the Open loan for the other item is not changed
Given no loan (loan deleted after checkout), when a request is created, the request is rejected and the loan is not updated
In order to reflect requests in loan action history, it is necessary to include request related actions in loan action history