Allowed SP endpoint should support patronGroupId parameter

Description

/circulation/requests/allowed-service-points endpoint accepts requesterId parameter to determine requester’s patron group and use it for circulation rules execution. In ECS TLR context, this patron won’t exist in the data tenant when we’re requesting allowed service points because we only create (clone) the requester from central to data tenant during request creation. Allowed service points are needed by UI before request creation, obviously. To resolve this conflict, mod-circulation needs to accept a new parameter - patronGroupId. It can be used in circulation rules directly instead of requesterId, but one of these parameters (and only one) should always be present:

  • patronGroupId parameter only - VALID

  • requesterId parameter only - VALID

  • Both patronGroupId and requesterId

  • None of the patronGroupId and requesterId - INVALID

Important: Other parameters (such as instanceId, itemId, useStubItem, ecsRequestRouting) shouldn’t be affected by this change.

Note: This change only needs to be merged into ecs-tlr-feature branch.

Environment

None

Potential Workaround

None

Checklist

hide

Activity

Show:

Alexander Kurash July 22, 2024 at 5:04 PM

Works as expected. Accepts patronGroupId parameter, logs:

17:03:09 [] [] [] [] INFO uestPolicyRepository processRulesResponse:: successfully applied request rules

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

Release

Ramsons (R2 2024)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created July 2, 2024 at 11:21 AM
Updated November 30, 2024 at 5:01 PM
Resolved July 22, 2024 at 5:04 PM
TestRail: Cases
TestRail: Runs