Block Renewal With Existing Recall Request

Makes sense. can you file the story/bug about accumulating all possible reasons a renewal may be blocked? I'll close this one since I tested it an it looks good otherwise. Thanks all!

My inclination would be to file a new bug to describe the desired behavior, i.e. accumulate and return all possible reasons a renewal may be blocked. This story is about blocking a renewal with an existing recall request; this functionality is in place.

, and what is the next step on this? Do we want to re-open this issue to ensure all errors reasons are displayed?

Oh, I was misremembering the checkbox in the loan policy was being for holds and recalls together. I see that it's set up differently now, but I still think it could be helpful to staff to know if there's other reasons the renewal is a bad idea if they're considering an override. (Especially if they'd be told the other reasons if item had just a hold on it.)

I think we accumulate multiple reasons for rejection under some circumstances e.g. not renewable, won't change the due date etc

We treat some reasons as more important than others, for example, if an item cannot be found, we stop any further checks.

Yep, exactly. When the backend returns multiple failure reasons, they do accumulate in the UI:

I think we only get multiple error messages from the backend when a renewal fails because of one or more violations of a loan policy. When that's the case, we get a list of all the loan policy violations. But if a renewal fails because of an existing recall, the backend never even attempts to validate the request against the loan policy.